Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix snmp template unit conversion problem #1796

Merged
merged 2 commits into from
Apr 20, 2024
Merged

Fix snmp template unit conversion problem #1796

merged 2 commits into from
Apr 20, 2024

Conversation

TJxiaobao
Copy link
Contributor

What's changed?

:Fix snmp template unit conversion problem

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

@TJxiaobao TJxiaobao requested a review from tomsun28 April 20, 2024 03:32
@tomsun28 tomsun28 added the good first pull request Good for newcomers label Apr 20, 2024
@tomsun28 tomsun28 added this to the 1.6.0 milestone Apr 20, 2024
tomsun28
tomsun28 approved these changes Apr 20, 2024
View reviewed changes
Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tomsun28 tomsun28 merged commit 8ce4731 into master Apr 20, 2024
3 checks passed
@zqr10159 zqr10159 mentioned this pull request Apr 20, 2024
Closed
1 task
@zqr10159 zqr10159 linked an issue Apr 20, 2024 that may be closed by this pull request
[BUG] snmp interface speed unit conversion #1775
Closed
1 task
@zqr10159 zqr10159 deleted the fix_snmp_unit branch September 23, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomsun28 tomsun28 tomsun28 approved these changes

Assignees
No one assigned
Labels
backend good first pull request Good for newcomers monitoring-template
Projects
Apache HertzBeat (Incubating)
Status: Done
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.

[BUG] snmp interface speed unit conversion
2 participants
@TJxiaobao @tomsun28