Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[refactor] add override annotation #1782

Merged
merged 2 commits into from
Apr 20, 2024
Merged

[refactor] add override annotation #1782

merged 2 commits into from
Apr 20, 2024

Conversation

handy-git
Copy link
Contributor

What's changed?

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

@tomsun28 tomsun28 changed the title add @Override [improve] add override annotation Apr 19, 2024
@tomsun28 tomsun28 changed the title [improve] add override annotation [refactor] add override annotation Apr 19, 2024
tomsun28
tomsun28 approved these changes Apr 20, 2024
View reviewed changes
Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tomsun28 tomsun28 merged commit ac2c4c0 into apache:master Apr 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomsun28 tomsun28 tomsun28 approved these changes

Assignees
No one assigned
Labels
backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@handy-git @tomsun28