Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

monitor center add search type modal #1699

Merged
merged 8 commits into from
Mar 31, 2024
Merged

monitor center add search type modal #1699

merged 8 commits into from
Mar 31, 2024

Conversation

tomsun28
Copy link
Contributor

What's changed?

image

Checklist

  • I hereby agree to the terms of the HertzBeat CLA
  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

@tomsun28 tomsun28 added the enhancement New feature or request label Mar 31, 2024
@tomsun28
update
c7c7fa9 
Signed-off-by: tomsun28 <[email protected]>
@tomsun28
delete divider
fcad93b 
Signed-off-by: tomsun28 <[email protected]>
@tomsun28
update
6861e1f 
Signed-off-by: tomsun28 <[email protected]>
@tomsun28 tomsun28 requested a review from TJxiaobao March 31, 2024 08:54
@tomsun28 tomsun28 added this to the 1.5.1 milestone Mar 31, 2024
TJxiaobao
TJxiaobao approved these changes Mar 31, 2024
View reviewed changes
Copy link
Contributor

@TJxiaobao TJxiaobao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TJxiaobao TJxiaobao merged commit ae06022 into master Mar 31, 2024
2 checks passed
@zqr10159 zqr10159 deleted the refactor-monitors-menu branch September 23, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TJxiaobao TJxiaobao TJxiaobao approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@tomsun28 @TJxiaobao