Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HBASE-28443 Return too slow when scanning a table with non-existing REGION_REPLICA_ID #5764

Closed
wants to merge 6 commits into from
+230 −24
Closed

HBASE-28443 Return too slow when scanning a table with non-existing REGION_REPLICA_ID #5764

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2e80896
Fix issue of returning too slow
guluo2016 Mar 17, 2024
3017930
update message
guluo2016 Mar 17, 2024
cf64436
update unit test
guluo2016 Mar 17, 2024
eb976e8
splotless apply
guluo2016 Mar 18, 2024
b22f7d8
update error message
guluo2016 Mar 18, 2024
8b5be6c
Updating modifiers from public to private
guluo2016 Mar 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Loading
Loading status checks…
update error message
@guluo2016
guluo2016 committed Mar 18, 2024

Verified

This commit was signed with the committer’s verified signature.
djhi Gildas Garcia
GPG key ID: A0CFD7012AC9AD58
Verified
Learn about vigilant mode
commit b22f7d879d2163766c57f9e98c9cc0a977737727
4 changes: 2 additions & 2 deletions hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRegionLocator.java
View file
Original file line number Diff line number Diff line change
@@ -198,8 +198,8 @@ CompletableFuture<HRegionLocation> getRegionLocation(TableName tableName, byte[]
int regionReplicationCount = tdesc.getRegionReplication();
if (replicaId >= regionReplicationCount) {
future
.completeExceptionally(new DoNotRetryIOException("The specified region replica id '"
+ replicaId + "' does not exist, the REGION_REPLICATION of this table "
.completeExceptionally(new DoNotRetryIOException("The specified region replica id "
+ replicaId + " does not exist, the REGION_REPLICATION of this table "
+ tableName.getNameAsString() + " is " + regionReplicationCount + ","
+ " this means that the maximum region replica id you can specify is "
+ (regionReplicationCount - 1) + "."));
8 changes: 4 additions & 4 deletions ...t/java/org/apache/hadoop/hbase/client/TestAsyncTableRegionLocatorWithRegionReplicaId.java
View file
Original file line number Diff line number Diff line change
@@ -134,8 +134,8 @@ public void testMetaTableRegionLocatorWithNonExistingRegionReplicaId()
future.get();
} catch (ExecutionException e) {
assertTrue(e.getCause() instanceof DoNotRetryIOException);
String message = "The specified region replica id '" + NON_EXISTING_REGION_REPLICA_ID
+ "' does not exist, the REGION_REPLICATION of this table "
String message = "The specified region replica id " + NON_EXISTING_REGION_REPLICA_ID
+ " does not exist, the REGION_REPLICATION of this table "
+ TableName.META_TABLE_NAME.getNameAsString() + " is "
+ TableDescriptorBuilder.DEFAULT_REGION_REPLICATION + ", "
+ "this means that the maximum region replica id you can specify is "
@@ -163,8 +163,8 @@ public void testTableRegionLocatorWithNonExistingRegionReplicaId() throws Interr
future.get();
} catch (ExecutionException e) {
assertTrue(e.getCause() instanceof DoNotRetryIOException);
String message = "The specified region replica id '" + NON_EXISTING_REGION_REPLICA_ID
+ "' does not exist, the REGION_REPLICATION of this table " + tableName.getNameAsString()
String message = "The specified region replica id " + NON_EXISTING_REGION_REPLICA_ID
+ " does not exist, the REGION_REPLICATION of this table " + tableName.getNameAsString()
+ " is " + REGION_REPLICATION_COUNT + ", "
+ "this means that the maximum region replica id you can specify is "
+ (REGION_REPLICATION_COUNT - 1) + ".";