-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HBASE-26268: Provide coprocessor hooks for updateConfiguration and clearRegionBlockCache #5593
HBASE-26268: Provide coprocessor hooks for updateConfiguration and clearRegionBlockCache #5593
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
hbase-server/src/main/java/org/apache/hadoop/hbase/HBaseServerBase.java
Outdated
Show resolved
Hide resolved
hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/MasterObserver.java
Show resolved
Hide resolved
hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/RegionServerObserver.java
Show resolved
Hide resolved
((MasterCoprocessorHost) coprocessorHost).preUpdateConfiguration(conf); | ||
} | ||
} catch (IOException e) { | ||
LOG.error("Error while calling coprocessor preUpdateConfiguration()", e); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of catching there here, can we throw them up the call chain? In particular, this will show up in client log when the reload request comes in via RPC. Maybe the signal handler will have to log.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
If there is interest in backporting this to 2.5, I can make that branch once this is approved. It's not a super straightforward backport. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
@charlesconnell This new permission enforcement makes for a backward incompatible change that is not acceptable for a patch release, so as of now, there's no need for a branch-2.5 backport. After discussing it with the release managers, I think we'll prefer to accelerate the EOL of the 2.5 release line. |
…arRegionBlockCache (apache#5593) Co-authored-by: Charles Connell <[email protected]> Signed-off-by: Nick Dimiduk <[email protected]>
I've posted the backport to branch-3, #5609. However the backport to branch-2 has some conflicts. @charlesconnell would you mind working through those and putting up a new backport PR? Thanks. |
…arRegionBlockCache (#5593) Co-authored-by: Charles Connell <[email protected]> Signed-off-by: Nick Dimiduk <[email protected]>
…arRegionBlockCache (apache#5593) Co-authored-by: Charles Connell <[email protected]> Signed-off-by: Nick Dimiduk <[email protected]>
…arRegionBlockCache (apache#5593) Co-authored-by: Charles Connell <[email protected]> Signed-off-by: Nick Dimiduk <[email protected]>
…arRegionBlockCache (apache#5593) Co-authored-by: Charles Connell <[email protected]> Signed-off-by: Nick Dimiduk <[email protected]>
…arRegionBlockCache (#5593) Co-authored-by: Charles Connell <[email protected]> Signed-off-by: Nick Dimiduk <[email protected]>
…arRegionBlockCache (apache#5593) Co-authored-by: Charles Connell <[email protected]> Signed-off-by: Nick Dimiduk <[email protected]>
…arRegionBlockCache (#5593) Co-authored-by: Charles Connell <[email protected]> Signed-off-by: Nick Dimiduk <[email protected]>
Provide coprocessor hooks for updateConfiguration and clearRegionBlockCache. Also, use these new hooks in AccessController to gate access to these operations. This closes a minor security hole.