Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HBASE-27966 HBase Master/RS JVM metrics populated incorrectly #5364

Merged
merged 1 commit into from
Aug 29, 2023
Merged

HBASE-27966 HBase Master/RS JVM metrics populated incorrectly #5364

merged 1 commit into from
Aug 29, 2023

Conversation

NihalJain
Copy link
Contributor

Backports #5323

@NihalJain NihalJain added the backport This PR is a back port of some issue or issues already committed to master label Aug 21, 2023
@NihalJain
Copy link
Contributor Author

NihalJain commented Aug 21, 2023 •
edited
Loading

When trying to cherry-pick from master and apply patch locally in branch-2 and build: there was a compilation error as HBaseTestingUtil in master, does not exist and is called HBaseTestingUtility in branch-2.

Just curious, what is the practice followed by other committers for backports, when we have a reference of this class HBaseTestingUtil in a PR raised on master.

  • Do we raise a backport JIRA and merge, the way I have done here?
  • Or, Do we cherry-pick commit from master, resolve the issue locally and push to branch-2 directly?

CC: @Apache9, @bbeaudreault, @Reidddddd

@bbeaudreault
Copy link
Contributor

For this particular issue, I usually just edit locally after cherry picking, and commit with the fix applied. It's pretty annoying, I wonder if we can come up with a better way to make this a non-issue

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 34s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ branch-2 Compile Tests _
+1 💚 mvninstall 2m 48s branch-2 passed
+1 💚 compile 2m 23s branch-2 passed
+1 💚 checkstyle 0m 36s branch-2 passed
+1 💚 spotless 0m 43s branch has no errors when running spotless:check.
+1 💚 spotbugs 1m 28s branch-2 passed
_ Patch Compile Tests _
+1 💚 mvninstall 2m 36s the patch passed
+1 💚 compile 2m 23s the patch passed
+1 💚 javac 2m 23s the patch passed
+1 💚 checkstyle 0m 35s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 13m 8s Patch does not cause any errors with Hadoop 2.10.2 or 3.2.4 3.3.5.
+1 💚 spotless 0m 41s patch has no errors when running spotless:check.
+1 💚 spotbugs 1m 34s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 12s The patch does not generate ASF License warnings.
31m 29s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5364/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #5364
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname Linux 7a428ba94043 5.4.0-152-generic #169-Ubuntu SMP Tue Jun 6 22:23:09 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / fbd258f
Default Java Eclipse Adoptium-11.0.17+8
Max. process+thread count 79 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5364/1/console
versions git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 39s Docker mode activated.
-0 ⚠️ yetus 0m 5s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+1 💚 mvninstall 2m 31s branch-2 passed
+1 💚 compile 0m 35s branch-2 passed
+1 💚 shadedjars 4m 42s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 25s branch-2 passed
_ Patch Compile Tests _
+1 💚 mvninstall 2m 9s the patch passed
+1 💚 compile 0m 37s the patch passed
+1 💚 javac 0m 37s the patch passed
+1 💚 shadedjars 4m 44s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 21s the patch passed
_ Other Tests _
+1 💚 unit 210m 55s hbase-server in the patch passed.
231m 49s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5364/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR #5364
Optional Tests javac javadoc unit shadedjars compile
uname Linux f6b0ee8b75ed 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / fbd258f
Default Java Temurin-1.8.0_352-b08
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5364/1/testReport/
Max. process+thread count 4545 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5364/1/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 36s Docker mode activated.
-0 ⚠️ yetus 0m 5s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+1 💚 mvninstall 2m 51s branch-2 passed
+1 💚 compile 0m 48s branch-2 passed
+1 💚 shadedjars 4m 49s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 28s branch-2 passed
_ Patch Compile Tests _
+1 💚 mvninstall 2m 38s the patch passed
+1 💚 compile 0m 47s the patch passed
+1 💚 javac 0m 47s the patch passed
+1 💚 shadedjars 4m 49s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 26s the patch passed
_ Other Tests _
+1 💚 unit 216m 49s hbase-server in the patch passed.
239m 35s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5364/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #5364
Optional Tests javac javadoc unit shadedjars compile
uname Linux 01f551e5abb6 5.4.0-156-generic #173-Ubuntu SMP Tue Jul 11 07:25:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / fbd258f
Default Java Eclipse Adoptium-11.0.17+8
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5364/1/testReport/
Max. process+thread count 4477 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5364/1/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@NihalJain
Copy link
Contributor Author

For this particular issue, I usually just edit locally after cherry picking, and commit with the fix applied.

Thank you @bbeaudreault for clarifying.

@NihalJain
Copy link
Contributor Author

Code has already been reviewed as part of #5323. Will merge this tonight, if no concerns.

@NihalJain NihalJain merged commit 2713a3c into apache:branch-2 Aug 29, 2023
NihalJain added a commit that referenced this pull request Aug 29, 2023
@NihalJain
HBASE-27966 HBase Master/RS JVM metrics populated incorrectly (#5323) (…
8baae88 
…#5364)

Signed-off-by: Bryan Beaudreault <[email protected]>
Signed-off-by: Duo Zhang <[email protected]>
Signed-off-by: Reid Chan <[email protected]>
(cherry picked from commit 2713a3c)
bbeaudreault pushed a commit to HubSpot/hbase that referenced this pull request Dec 13, 2023
@NihalJain @bbeaudreault
HubSpot Backport: HBASE-27966 HBase Master/RS JVM metrics populated i…
28b2584 
…ncorrectly (apache#5323) (apache#5364)

Signed-off-by: Bryan Beaudreault <[email protected]>
Signed-off-by: Duo Zhang <[email protected]>
Signed-off-by: Reid Chan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport This PR is a back port of some issue or issues already committed to master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NihalJain @bbeaudreault @Apache-HBase