Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HBASE-27672 Read RPC threads may BLOCKED at the Configuration.get whe… #5075

Merged
merged 1 commit into from
Mar 6, 2023
Merged

HBASE-27672 Read RPC threads may BLOCKED at the Configuration.get whe… #5075

merged 1 commit into from
Mar 6, 2023

Conversation

sunhelly
Copy link
Contributor

@sunhelly sunhelly commented Mar 3, 2023

…n using java compression

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 23s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for branch
+1 💚 mvninstall 3m 46s master passed
+1 💚 compile 1m 11s master passed
+1 💚 shadedjars 4m 53s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 1s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 12s Maven dependency ordering for patch
+1 💚 mvninstall 3m 36s the patch passed
+1 💚 compile 1m 11s the patch passed
+1 💚 javac 1m 11s the patch passed
+1 💚 shadedjars 4m 53s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 0s the patch passed
_ Other Tests _
+1 💚 unit 0m 57s hbase-compression-aircompressor in the patch passed.
+1 💚 unit 0m 36s hbase-compression-brotli in the patch passed.
+1 💚 unit 0m 30s hbase-compression-lz4 in the patch passed.
+1 💚 unit 0m 29s hbase-compression-snappy in the patch passed.
+1 💚 unit 1m 2s hbase-compression-xz in the patch passed.
+1 💚 unit 4m 8s hbase-compression-zstd in the patch passed.
31m 40s
Subsystem Report/Notes
Docker ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5075/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #5075
Optional Tests javac javadoc unit shadedjars compile
uname Linux ee26f1f379d5 5.4.0-1094-aws #102~18.04.1-Ubuntu SMP Tue Jan 10 21:07:03 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / d2b0074
Default Java Eclipse Adoptium-11.0.17+8
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5075/1/testReport/
Max. process+thread count 699 (vs. ulimit of 30000)
modules C: hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-brotli hbase-compression/hbase-compression-lz4 hbase-compression/hbase-compression-snappy hbase-compression/hbase-compression-xz hbase-compression/hbase-compression-zstd U: hbase-compression
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5075/1/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 59s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 9s Maven dependency ordering for branch
+1 💚 mvninstall 2m 55s master passed
+1 💚 compile 1m 19s master passed
+1 💚 shadedjars 4m 20s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 8s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for patch
+1 💚 mvninstall 2m 48s the patch passed
+1 💚 compile 1m 19s the patch passed
+1 💚 javac 1m 19s the patch passed
+1 💚 shadedjars 4m 17s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 6s the patch passed
_ Other Tests _
+1 💚 unit 0m 47s hbase-compression-aircompressor in the patch passed.
+1 💚 unit 0m 36s hbase-compression-brotli in the patch passed.
+1 💚 unit 0m 29s hbase-compression-lz4 in the patch passed.
+1 💚 unit 0m 28s hbase-compression-snappy in the patch passed.
+1 💚 unit 0m 54s hbase-compression-xz in the patch passed.
+1 💚 unit 7m 28s hbase-compression-zstd in the patch passed.
33m 10s
Subsystem Report/Notes
Docker ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5075/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #5075
Optional Tests javac javadoc unit shadedjars compile
uname Linux e527c6251ce2 5.4.0-135-generic #152-Ubuntu SMP Wed Nov 23 20:19:22 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / d2b0074
Default Java Temurin-1.8.0_352-b08
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5075/1/testReport/
Max. process+thread count 832 (vs. ulimit of 30000)
modules C: hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-brotli hbase-compression/hbase-compression-lz4 hbase-compression/hbase-compression-snappy hbase-compression/hbase-compression-xz hbase-compression/hbase-compression-zstd U: hbase-compression
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5075/1/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 25s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for branch
+1 💚 mvninstall 3m 51s master passed
+1 💚 compile 1m 25s master passed
+1 💚 checkstyle 0m 38s master passed
+1 💚 spotless 0m 43s branch has no errors when running spotless:check.
+1 💚 spotbugs 1m 45s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for patch
+1 💚 mvninstall 3m 32s the patch passed
+1 💚 compile 1m 25s the patch passed
+1 💚 javac 1m 25s the patch passed
+1 💚 checkstyle 0m 36s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 14m 15s Patch does not cause any errors with Hadoop 3.2.4 3.3.4.
+1 💚 spotless 0m 42s patch has no errors when running spotless:check.
+1 💚 spotbugs 2m 31s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 43s The patch does not generate ASF License warnings.
42m 19s
Subsystem Report/Notes
Docker ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5075/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #5075
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname Linux a0fc014ebe0d 5.4.0-1092-aws #100~18.04.2-Ubuntu SMP Tue Nov 29 08:39:52 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / d2b0074
Default Java Eclipse Adoptium-11.0.17+8
Max. process+thread count 83 (vs. ulimit of 30000)
modules C: hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-brotli hbase-compression/hbase-compression-lz4 hbase-compression/hbase-compression-snappy hbase-compression/hbase-compression-xz hbase-compression/hbase-compression-zstd U: hbase-compression
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5075/1/console
versions git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

bbeaudreault
bbeaudreault approved these changes Mar 3, 2023
View reviewed changes
Copy link
Contributor

@bbeaudreault bbeaudreault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, we should avoid Configuration.get in any hot codepaths. Thanks for cleaning this up.

@sunhelly sunhelly merged commit 3eedc09 into apache:master Mar 6, 2023
sunhelly added a commit to sunhelly/hbase that referenced this pull request Mar 6, 2023
@sunhelly
HBASE-27672 Read RPC threads may BLOCKED at the Configuration.get whe…
6c69fc3 
…n using java compression (apache#5075)

Signed-off-by: Bryan Beaudreault <[email protected]>
sunhelly added a commit to sunhelly/hbase that referenced this pull request Mar 6, 2023
@sunhelly
HBASE-27672 Read RPC threads may BLOCKED at the Configuration.get whe…
bc31a30 
…n using java compression (apache#5075)

Signed-off-by: Bryan Beaudreault <[email protected]>
This was referenced Mar 6, 2023
Merged
Merged
sunhelly added a commit that referenced this pull request Mar 6, 2023
@sunhelly
HBASE-27672 Read RPC threads may BLOCKED at the Configuration.get whe…
505a901 
…n using java compression (#5075) (#5083)

Signed-off-by: Bryan Beaudreault <[email protected]>
sunhelly added a commit that referenced this pull request Mar 6, 2023
@sunhelly
HBASE-27672 Read RPC threads may BLOCKED at the Configuration.get whe…
6d463f7 
…n using java compression (#5075) (#5084)

Signed-off-by: Bryan Beaudreault <[email protected]>
charlesconnell pushed a commit to HubSpot/hbase that referenced this pull request Feb 7, 2024
@sunhelly @charlesconnell
Hubspot backport: HBASE-27672 Read RPC threads may BLOCKED at the Con…
2483e3b 
…figuration.get when using java compression (apache#5075) (apache#5084)

Signed-off-by: Bryan Beaudreault <[email protected]>
charlesconnell added a commit to HubSpot/hbase that referenced this pull request Feb 7, 2024
@charlesconnell @sunhelly
Hubspot backport: HBASE-27672 Read RPC threads may BLOCKED at the Con…
73223be 
…figuration.get when using java compression (apache#5075) (apache#5084) (#76)

Signed-off-by: Bryan Beaudreault <[email protected]>
Co-authored-by: Xiaolin Ha <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbeaudreault bbeaudreault bbeaudreault approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sunhelly @Apache-HBase @bbeaudreault