HBASE-27532 Add block bytes scanned metrics #5067

bbeaudreault · 2023-03-01T02:23:05Z

Adds countofBlockBytesScanned to ScanMetrics, and incorporates that into TestScannerBlockSizeLimits assertions.
Renames server side RpcCall's counter from responseBlockBytes to blockBytesScanned. This seems more straightforward in the context of a request.
Adds histograms for each of get, scan, increment, append, checkAndMutate, as well as an overall blockBytesScannedCount to Regionserver and TableLatencies metrics
Adds blockBytesScannedCount to user aggregate metric. This would be useful for tuning quotas for users.

This is mostly boilerplate. Since blockBytesScanned increments globally for a request, we have to treat it similarly to time when calling the various per-request update methods -- subtract after - before for multi's to get the per-action value.

Apache-HBase · 2023-03-01T03:18:31Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 24s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 31s	master passed
+1 💚	compile	3m 15s	master passed
+1 💚	checkstyle	0m 53s	master passed
+1 💚	spotless	0m 39s	branch has no errors when running spotless:check.
+1 💚	spotbugs	2m 18s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 9s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 14s	the patch passed
+1 💚	compile	3m 14s	the patch passed
+1 💚	javac	3m 14s	the patch passed
-0 ⚠️	checkstyle	0m 13s	hbase-client: The patch generated 1 new + 2 unchanged - 0 fixed = 3 total (was 2)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	12m 49s	Patch does not cause any errors with Hadoop 3.2.4 3.3.4.
+1 💚	spotless	0m 37s	patch has no errors when running spotless:check.
+1 💚	spotbugs	2m 40s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 23s	The patch does not generate ASF License warnings.
		43m 10s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5067/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5067
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux eb1280ae5a36 5.4.0-1092-aws #100~18.04.2-Ubuntu SMP Tue Nov 29 08:39:52 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `d2b0074`
Default Java	Eclipse Adoptium-11.0.17+8
checkstyle	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5067/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt
Max. process+thread count	86 (vs. ulimit of 30000)
modules	C: hbase-hadoop-compat hbase-client hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5067/1/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-03-01T06:20:06Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 23s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 29s	master passed
+1 💚	compile	1m 9s	master passed
+1 💚	shadedjars	4m 37s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 47s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 20s	the patch passed
+1 💚	compile	1m 9s	the patch passed
+1 💚	javac	1m 9s	the patch passed
+1 💚	shadedjars	4m 35s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 46s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 33s	hbase-hadoop-compat in the patch passed.
+1 💚	unit	1m 19s	hbase-client in the patch passed.
+1 💚	unit	197m 57s	hbase-server in the patch passed.
		224m 45s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5067/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5067
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 4c3a8a7ec0a5 5.4.0-1093-aws #102~18.04.2-Ubuntu SMP Wed Dec 7 00:31:59 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `d2b0074`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5067/1/testReport/
Max. process+thread count	2474 (vs. ulimit of 30000)
modules	C: hbase-hadoop-compat hbase-client hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5067/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-03-01T06:30:12Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 26s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 11s	master passed
+1 💚	compile	1m 6s	master passed
+1 💚	shadedjars	4m 43s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 46s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 49s	the patch passed
+1 💚	compile	1m 3s	the patch passed
+1 💚	javac	1m 3s	the patch passed
+1 💚	shadedjars	4m 39s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 44s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 31s	hbase-hadoop-compat in the patch passed.
+1 💚	unit	1m 9s	hbase-client in the patch passed.
+1 💚	unit	208m 51s	hbase-server in the patch passed.
		234m 53s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5067/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5067
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux cdbb890ba842 5.4.0-1092-aws #100~18.04.2-Ubuntu SMP Tue Nov 29 08:39:52 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `d2b0074`
Default Java	Temurin-1.8.0_352-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5067/1/testReport/
Max. process+thread count	2631 (vs. ulimit of 30000)
modules	C: hbase-hadoop-compat hbase-client hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5067/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-03-07T22:48:58Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 24s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 1s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 10s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 20s	master passed
+1 💚	compile	3m 12s	master passed
+1 💚	checkstyle	0m 50s	master passed
+1 💚	spotless	0m 38s	branch has no errors when running spotless:check.
+1 💚	spotbugs	2m 16s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 10s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 17s	the patch passed
+1 💚	compile	3m 15s	the patch passed
+1 💚	javac	3m 15s	the patch passed
-0 ⚠️	checkstyle	0m 13s	hbase-client: The patch generated 1 new + 2 unchanged - 0 fixed = 3 total (was 2)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	12m 58s	Patch does not cause any errors with Hadoop 3.2.4 3.3.4.
+1 💚	spotless	0m 38s	patch has no errors when running spotless:check.
-1 ❌	spotbugs	0m 29s	hbase-hadoop-compat generated 4 new + 0 unchanged - 0 fixed = 4 total (was 0)
-1 ❌	spotbugs	1m 31s	hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
		_ Other Tests _
+1 💚	asflicense	0m 23s	The patch does not generate ASF License warnings.
		42m 57s

Reason	Tests
FindBugs	module:hbase-hadoop-compat
	Inconsistent synchronization of org.apache.hadoop.hbase.regionserver.MetricsUserSourceImpl.appendHisto; locked 50% of time Unsynchronized access at MetricsUserSourceImpl.java:50% of time Unsynchronized access at MetricsUserSourceImpl.java:[line 253]
	Inconsistent synchronization of org.apache.hadoop.hbase.regionserver.MetricsUserSourceImpl.getHisto; locked 50% of time Unsynchronized access at MetricsUserSourceImpl.java:50% of time Unsynchronized access at MetricsUserSourceImpl.java:[line 241]
	Inconsistent synchronization of org.apache.hadoop.hbase.regionserver.MetricsUserSourceImpl.incrementHisto; locked 50% of time Unsynchronized access at MetricsUserSourceImpl.java:50% of time Unsynchronized access at MetricsUserSourceImpl.java:[line 247]
	Inconsistent synchronization of org.apache.hadoop.hbase.regionserver.MetricsUserSourceImpl.scanTimeHisto; locked 50% of time Unsynchronized access at MetricsUserSourceImpl.java:50% of time Unsynchronized access at MetricsUserSourceImpl.java:[line 264]
FindBugs	module:hbase-server
	Unread field:MetricsTableRequests.java:[line 77]

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5067/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5067
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux 4720e39ab5fa 5.4.0-1092-aws #100~18.04.2-Ubuntu SMP Tue Nov 29 08:39:52 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `16864c7`
Default Java	Eclipse Adoptium-11.0.17+8
checkstyle	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5067/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt
spotbugs	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5067/3/artifact/yetus-general-check/output/new-spotbugs-hbase-hadoop-compat.html
spotbugs	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5067/3/artifact/yetus-general-check/output/new-spotbugs-hbase-server.html
Max. process+thread count	83 (vs. ulimit of 30000)
modules	C: hbase-hadoop-compat hbase-client hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5067/3/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-03-08T01:58:39Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 23s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 10s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 21s	master passed
+1 💚	compile	1m 11s	master passed
+1 💚	shadedjars	4m 41s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 47s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 19s	the patch passed
+1 💚	compile	1m 13s	the patch passed
+1 💚	javac	1m 13s	the patch passed
+1 💚	shadedjars	4m 40s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 47s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 35s	hbase-hadoop-compat in the patch passed.
+1 💚	unit	1m 21s	hbase-client in the patch passed.
+1 💚	unit	205m 31s	hbase-server in the patch passed.
		232m 34s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5067/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5067
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 693512df20d3 5.4.0-1094-aws #102~18.04.1-Ubuntu SMP Tue Jan 10 21:07:03 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `16864c7`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5067/3/testReport/
Max. process+thread count	2669 (vs. ulimit of 30000)
modules	C: hbase-hadoop-compat hbase-client hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5067/3/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-03-08T02:04:15Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 24s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 25s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 7s	master passed
+1 💚	compile	1m 3s	master passed
+1 💚	shadedjars	4m 41s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 45s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 47s	the patch passed
+1 💚	compile	1m 2s	the patch passed
+1 💚	javac	1m 2s	the patch passed
+1 💚	shadedjars	4m 37s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 44s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 31s	hbase-hadoop-compat in the patch passed.
+1 💚	unit	1m 11s	hbase-client in the patch passed.
+1 💚	unit	212m 21s	hbase-server in the patch passed.
		238m 12s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5067/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5067
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 08797cbb5f28 5.4.0-1092-aws #100~18.04.2-Ubuntu SMP Tue Nov 29 08:39:52 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `16864c7`
Default Java	Temurin-1.8.0_352-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5067/3/testReport/
Max. process+thread count	2696 (vs. ulimit of 30000)
modules	C: hbase-hadoop-compat hbase-client hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5067/3/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-03-08T02:49:08Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 24s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 18s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 16s	master passed
+1 💚	compile	3m 10s	master passed
+1 💚	checkstyle	0m 49s	master passed
+1 💚	spotless	0m 37s	branch has no errors when running spotless:check.
+1 💚	spotbugs	2m 13s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 13s	the patch passed
+1 💚	compile	3m 10s	the patch passed
+1 💚	javac	3m 10s	the patch passed
-0 ⚠️	checkstyle	0m 13s	hbase-client: The patch generated 1 new + 2 unchanged - 0 fixed = 3 total (was 2)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	12m 44s	Patch does not cause any errors with Hadoop 3.2.4 3.3.4.
+1 💚	spotless	0m 37s	patch has no errors when running spotless:check.
-1 ❌	spotbugs	0m 28s	hbase-hadoop-compat generated 4 new + 0 unchanged - 0 fixed = 4 total (was 0)
-1 ❌	spotbugs	1m 29s	hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
		_ Other Tests _
+1 💚	asflicense	0m 21s	The patch does not generate ASF License warnings.
		42m 30s

Reason	Tests
FindBugs	module:hbase-hadoop-compat
	Inconsistent synchronization of org.apache.hadoop.hbase.regionserver.MetricsUserSourceImpl.appendHisto; locked 50% of time Unsynchronized access at MetricsUserSourceImpl.java:50% of time Unsynchronized access at MetricsUserSourceImpl.java:[line 253]
	Inconsistent synchronization of org.apache.hadoop.hbase.regionserver.MetricsUserSourceImpl.getHisto; locked 50% of time Unsynchronized access at MetricsUserSourceImpl.java:50% of time Unsynchronized access at MetricsUserSourceImpl.java:[line 241]
	Inconsistent synchronization of org.apache.hadoop.hbase.regionserver.MetricsUserSourceImpl.incrementHisto; locked 50% of time Unsynchronized access at MetricsUserSourceImpl.java:50% of time Unsynchronized access at MetricsUserSourceImpl.java:[line 247]
	Inconsistent synchronization of org.apache.hadoop.hbase.regionserver.MetricsUserSourceImpl.scanTimeHisto; locked 50% of time Unsynchronized access at MetricsUserSourceImpl.java:50% of time Unsynchronized access at MetricsUserSourceImpl.java:[line 264]
FindBugs	module:hbase-server
	Unread field:MetricsTableRequests.java:[line 77]

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5067/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5067
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux c313e2969017 5.4.0-1092-aws #100~18.04.2-Ubuntu SMP Tue Nov 29 08:39:52 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `16864c7`
Default Java	Eclipse Adoptium-11.0.17+8
checkstyle	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5067/4/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt
spotbugs	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5067/4/artifact/yetus-general-check/output/new-spotbugs-hbase-hadoop-compat.html
spotbugs	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5067/4/artifact/yetus-general-check/output/new-spotbugs-hbase-server.html
Max. process+thread count	86 (vs. ulimit of 30000)
modules	C: hbase-hadoop-compat hbase-client hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5067/4/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-03-08T05:54:43Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 24s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 31s	master passed
+1 💚	compile	1m 8s	master passed
+1 💚	shadedjars	4m 34s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 47s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 10s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 16s	the patch passed
+1 💚	compile	1m 7s	the patch passed
+1 💚	javac	1m 7s	the patch passed
+1 💚	shadedjars	4m 33s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 46s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 33s	hbase-hadoop-compat in the patch passed.
+1 💚	unit	1m 19s	hbase-client in the patch passed.
+1 💚	unit	201m 26s	hbase-server in the patch passed.
		228m 11s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5067/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5067
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 78ca929535d2 5.4.0-1094-aws #102~18.04.1-Ubuntu SMP Tue Jan 10 21:07:03 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `16864c7`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5067/4/testReport/
Max. process+thread count	2689 (vs. ulimit of 30000)
modules	C: hbase-hadoop-compat hbase-client hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5067/4/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-03-08T07:20:04Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 25s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 18s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 51s	master passed
+1 💚	compile	1m 3s	master passed
+1 💚	shadedjars	4m 39s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 44s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 47s	the patch passed
+1 💚	compile	1m 4s	the patch passed
+1 💚	javac	1m 4s	the patch passed
+1 💚	shadedjars	4m 39s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 44s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 30s	hbase-hadoop-compat in the patch passed.
+1 💚	unit	1m 8s	hbase-client in the patch passed.
-1 ❌	unit	287m 46s	hbase-server in the patch failed.
		313m 29s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5067/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5067
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux c9969a1b78e5 5.4.0-1092-aws #100~18.04.2-Ubuntu SMP Tue Nov 29 08:39:52 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `16864c7`
Default Java	Temurin-1.8.0_352-b08
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5067/4/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5067/4/testReport/
Max. process+thread count	2556 (vs. ulimit of 30000)
modules	C: hbase-hadoop-compat hbase-client hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5067/4/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

bbeaudreault · 2023-03-08T16:18:08Z

@Apache9 any chance you have some time to review this metrics PR? mostly boilerplate.

There are some spotbugs/checkstyle warnings, but they all are unrelated to my changes. For example, checkstyle doesn't like the code style of ServerSideScanMetrics where we expose public instance variables, but I can't change that here. And spotbugs doesn't like how MetricsUserSourceImpl has some weird synchronization for the LossyCounting stuff.

Apache-HBase · 2023-03-08T17:19:11Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 26s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 29s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 38s	master passed
+1 💚	compile	3m 21s	master passed
+1 💚	checkstyle	0m 53s	master passed
+1 💚	spotless	0m 40s	branch has no errors when running spotless:check.
+1 💚	spotbugs	2m 22s	master passed
-0 ⚠️	patch	1m 36s	Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 10s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 15s	the patch passed
+1 💚	compile	3m 14s	the patch passed
+1 💚	javac	3m 14s	the patch passed
-0 ⚠️	checkstyle	0m 12s	hbase-client: The patch generated 1 new + 2 unchanged - 0 fixed = 3 total (was 2)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	12m 55s	Patch does not cause any errors with Hadoop 3.2.4 3.3.4.
+1 💚	spotless	0m 38s	patch has no errors when running spotless:check.
-1 ❌	spotbugs	0m 29s	hbase-hadoop-compat generated 4 new + 0 unchanged - 0 fixed = 4 total (was 0)
		_ Other Tests _
+1 💚	asflicense	0m 22s	The patch does not generate ASF License warnings.
		44m 13s

Reason	Tests
FindBugs	module:hbase-hadoop-compat
	Inconsistent synchronization of org.apache.hadoop.hbase.regionserver.MetricsUserSourceImpl.appendHisto; locked 50% of time Unsynchronized access at MetricsUserSourceImpl.java:50% of time Unsynchronized access at MetricsUserSourceImpl.java:[line 253]
	Inconsistent synchronization of org.apache.hadoop.hbase.regionserver.MetricsUserSourceImpl.getHisto; locked 50% of time Unsynchronized access at MetricsUserSourceImpl.java:50% of time Unsynchronized access at MetricsUserSourceImpl.java:[line 241]
	Inconsistent synchronization of org.apache.hadoop.hbase.regionserver.MetricsUserSourceImpl.incrementHisto; locked 50% of time Unsynchronized access at MetricsUserSourceImpl.java:50% of time Unsynchronized access at MetricsUserSourceImpl.java:[line 247]
	Inconsistent synchronization of org.apache.hadoop.hbase.regionserver.MetricsUserSourceImpl.scanTimeHisto; locked 50% of time Unsynchronized access at MetricsUserSourceImpl.java:50% of time Unsynchronized access at MetricsUserSourceImpl.java:[line 264]

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5067/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5067
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux f3394fdb4b71 5.4.0-1092-aws #100~18.04.2-Ubuntu SMP Tue Nov 29 08:39:52 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `8bdabed`
Default Java	Eclipse Adoptium-11.0.17+8
checkstyle	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5067/5/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt
spotbugs	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5067/5/artifact/yetus-general-check/output/new-spotbugs-hbase-hadoop-compat.html
Max. process+thread count	85 (vs. ulimit of 30000)
modules	C: hbase-hadoop-compat hbase-client hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5067/5/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-03-08T20:33:17Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 28s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 58s	master passed
+1 💚	compile	1m 8s	master passed
+1 💚	shadedjars	4m 40s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 43s	master passed
-0 ⚠️	patch	5m 44s	Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 50s	the patch passed
+1 💚	compile	1m 3s	the patch passed
+1 💚	javac	1m 3s	the patch passed
+1 💚	shadedjars	4m 38s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 43s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 30s	hbase-hadoop-compat in the patch passed.
+1 💚	unit	1m 9s	hbase-client in the patch passed.
+1 💚	unit	212m 18s	hbase-server in the patch passed.
		238m 4s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5067/5/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5067
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 786189b84455 5.4.0-1092-aws #100~18.04.2-Ubuntu SMP Tue Nov 29 08:39:52 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `8bdabed`
Default Java	Temurin-1.8.0_352-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5067/5/testReport/
Max. process+thread count	2633 (vs. ulimit of 30000)
modules	C: hbase-hadoop-compat hbase-client hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5067/5/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-03-08T20:41:24Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 20s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 36s	master passed
+1 💚	compile	1m 20s	master passed
+1 💚	shadedjars	4m 25s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 56s	master passed
-0 ⚠️	patch	5m 47s	Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 21s	the patch passed
+1 💚	compile	1m 19s	the patch passed
+1 💚	javac	1m 19s	the patch passed
+1 💚	shadedjars	4m 22s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 54s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 39s	hbase-hadoop-compat in the patch passed.
+1 💚	unit	1m 21s	hbase-client in the patch passed.
+1 💚	unit	217m 38s	hbase-server in the patch passed.
		246m 7s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5067/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5067
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 0f948af5125b 5.4.0-135-generic #152-Ubuntu SMP Wed Nov 23 20:19:22 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `8bdabed`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5067/5/testReport/
Max. process+thread count	2579 (vs. ulimit of 30000)
modules	C: hbase-hadoop-compat hbase-client hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5067/5/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

bbeaudreault · 2023-03-09T12:29:32Z

@sunhelly any chance you can review this? Just metrics boilerplate. Thanks

bbeaudreault · 2023-03-09T19:13:45Z

...-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsUserSourceImpl.java

@@ -116,7 +119,7 @@ public MetricsUserSourceImpl(String user, MetricsUserAggregateSourceImpl agg) {
    this.user = user;
    this.registry = agg.getMetricsRegistry();

-    this.userNamePrefix = "user_" + user + "_metric_";
+    this.userNamePrefix = "User_" + user + "_metric_";


this change is ok because all of the existing newTimeHistogram calls already capitalize the first letter. So these end up in JMX like User_foo_metric_.... But newCounter doesn't do the same capitalization, so the new blockBytesScannedCount ends up user_foo_metric_blockBytesScannedCount (lowercase u). So this change here just ensures that all the metrics are similarly capitalized.

Apache-HBase · 2023-03-09T20:09:16Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 26s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 20s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 15s	master passed
+1 💚	compile	3m 14s	master passed
+1 💚	checkstyle	0m 51s	master passed
+1 💚	spotless	0m 37s	branch has no errors when running spotless:check.
+1 💚	spotbugs	2m 16s	master passed
-0 ⚠️	patch	1m 35s	Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 10s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 15s	the patch passed
+1 💚	compile	3m 14s	the patch passed
+1 💚	javac	3m 14s	the patch passed
-0 ⚠️	checkstyle	0m 13s	hbase-client: The patch generated 1 new + 2 unchanged - 0 fixed = 3 total (was 2)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	12m 52s	Patch does not cause any errors with Hadoop 3.2.4 3.3.4.
+1 💚	spotless	0m 38s	patch has no errors when running spotless:check.
-1 ❌	spotbugs	0m 27s	hbase-hadoop-compat generated 4 new + 0 unchanged - 0 fixed = 4 total (was 0)
		_ Other Tests _
+1 💚	asflicense	0m 21s	The patch does not generate ASF License warnings.
		43m 8s

Reason	Tests
FindBugs	module:hbase-hadoop-compat
	Inconsistent synchronization of org.apache.hadoop.hbase.regionserver.MetricsUserSourceImpl.appendHisto; locked 50% of time Unsynchronized access at MetricsUserSourceImpl.java:50% of time Unsynchronized access at MetricsUserSourceImpl.java:[line 253]
	Inconsistent synchronization of org.apache.hadoop.hbase.regionserver.MetricsUserSourceImpl.getHisto; locked 50% of time Unsynchronized access at MetricsUserSourceImpl.java:50% of time Unsynchronized access at MetricsUserSourceImpl.java:[line 241]
	Inconsistent synchronization of org.apache.hadoop.hbase.regionserver.MetricsUserSourceImpl.incrementHisto; locked 50% of time Unsynchronized access at MetricsUserSourceImpl.java:50% of time Unsynchronized access at MetricsUserSourceImpl.java:[line 247]
	Inconsistent synchronization of org.apache.hadoop.hbase.regionserver.MetricsUserSourceImpl.scanTimeHisto; locked 50% of time Unsynchronized access at MetricsUserSourceImpl.java:50% of time Unsynchronized access at MetricsUserSourceImpl.java:[line 264]

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5067/6/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5067
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux 12588f713727 5.4.0-1092-aws #100~18.04.2-Ubuntu SMP Tue Nov 29 08:39:52 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `0491524`
Default Java	Eclipse Adoptium-11.0.17+8
checkstyle	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5067/6/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt
spotbugs	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5067/6/artifact/yetus-general-check/output/new-spotbugs-hbase-hadoop-compat.html
Max. process+thread count	82 (vs. ulimit of 30000)
modules	C: hbase-hadoop-compat hbase-client hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5067/6/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Rename server side counter to blockBytesScanned Add to ScanMetrics as countOfBlockBytesScanned, and incorporate into TestScannerBlockSizeLimits

…er metrics in jmx

Apache-HBase · 2023-03-09T21:32:21Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 25s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 10s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 14s	master passed
+1 💚	compile	3m 14s	master passed
+1 💚	checkstyle	0m 52s	master passed
+1 💚	spotless	0m 38s	branch has no errors when running spotless:check.
+1 💚	spotbugs	2m 16s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 10s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 16s	the patch passed
+1 💚	compile	3m 14s	the patch passed
+1 💚	javac	3m 14s	the patch passed
-0 ⚠️	checkstyle	0m 12s	hbase-client: The patch generated 1 new + 2 unchanged - 0 fixed = 3 total (was 2)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	12m 48s	Patch does not cause any errors with Hadoop 3.2.4 3.3.4.
+1 💚	spotless	0m 37s	patch has no errors when running spotless:check.
-1 ❌	spotbugs	0m 27s	hbase-hadoop-compat generated 4 new + 0 unchanged - 0 fixed = 4 total (was 0)
		_ Other Tests _
+1 💚	asflicense	0m 23s	The patch does not generate ASF License warnings.
		42m 59s

Reason	Tests
FindBugs	module:hbase-hadoop-compat
	Inconsistent synchronization of org.apache.hadoop.hbase.regionserver.MetricsUserSourceImpl.appendHisto; locked 50% of time Unsynchronized access at MetricsUserSourceImpl.java:50% of time Unsynchronized access at MetricsUserSourceImpl.java:[line 253]
	Inconsistent synchronization of org.apache.hadoop.hbase.regionserver.MetricsUserSourceImpl.getHisto; locked 50% of time Unsynchronized access at MetricsUserSourceImpl.java:50% of time Unsynchronized access at MetricsUserSourceImpl.java:[line 241]
	Inconsistent synchronization of org.apache.hadoop.hbase.regionserver.MetricsUserSourceImpl.incrementHisto; locked 50% of time Unsynchronized access at MetricsUserSourceImpl.java:50% of time Unsynchronized access at MetricsUserSourceImpl.java:[line 247]
	Inconsistent synchronization of org.apache.hadoop.hbase.regionserver.MetricsUserSourceImpl.scanTimeHisto; locked 50% of time Unsynchronized access at MetricsUserSourceImpl.java:50% of time Unsynchronized access at MetricsUserSourceImpl.java:[line 264]

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5067/7/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5067
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux 497eefaa7b8b 5.4.0-1092-aws #100~18.04.2-Ubuntu SMP Tue Nov 29 08:39:52 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `0491524`
Default Java	Eclipse Adoptium-11.0.17+8
checkstyle	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5067/7/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt
spotbugs	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5067/7/artifact/yetus-general-check/output/new-spotbugs-hbase-hadoop-compat.html
Max. process+thread count	80 (vs. ulimit of 30000)
modules	C: hbase-hadoop-compat hbase-client hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5067/7/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-03-10T00:49:57Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	2m 10s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 17s	master passed
+1 💚	compile	1m 20s	master passed
+1 💚	shadedjars	4m 21s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 55s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 25s	the patch passed
+1 💚	compile	1m 15s	the patch passed
+1 💚	javac	1m 15s	the patch passed
+1 💚	shadedjars	4m 22s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 54s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 37s	hbase-hadoop-compat in the patch passed.
+1 💚	unit	1m 21s	hbase-client in the patch passed.
+1 💚	unit	211m 15s	hbase-server in the patch passed.
		240m 42s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5067/7/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5067
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 583a0040e9c7 5.4.0-135-generic #152-Ubuntu SMP Wed Nov 23 20:19:22 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `0491524`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5067/7/testReport/
Max. process+thread count	2543 (vs. ulimit of 30000)
modules	C: hbase-hadoop-compat hbase-client hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5067/7/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-03-10T00:50:09Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 26s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 24s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 48s	master passed
+1 💚	compile	1m 3s	master passed
+1 💚	shadedjars	4m 39s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 45s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 49s	the patch passed
+1 💚	compile	1m 4s	the patch passed
+1 💚	javac	1m 4s	the patch passed
+1 💚	shadedjars	4m 42s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 47s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 30s	hbase-hadoop-compat in the patch passed.
+1 💚	unit	1m 10s	hbase-client in the patch passed.
+1 💚	unit	214m 30s	hbase-server in the patch passed.
		240m 36s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5067/7/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5067
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 4d439ba6f2c8 5.4.0-1092-aws #100~18.04.2-Ubuntu SMP Tue Nov 29 08:39:52 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `0491524`
Default Java	Temurin-1.8.0_352-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5067/7/testReport/
Max. process+thread count	2665 (vs. ulimit of 30000)
modules	C: hbase-hadoop-compat hbase-client hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5067/7/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

sunhelly

+1

sunhelly · 2023-03-20T08:41:25Z

Please fix the spotless issues before committing, thanks.

bbeaudreault · 2023-03-26T19:33:02Z

Thanks for reviewing @sunhelly! The spotless is clear, but there is checkstyle/spotbugs that are all unrelated. I filed two JIRAs to clean them up, since they are distinct:

(checkstyle) https://issues.apache.org/jira/browse/HBASE-27757
(spotbugs) https://issues.apache.org/jira/browse/HBASE-27758

For now I just pushed a commit to at least suppress the checkstyle warning.

Apache-HBase · 2023-03-26T20:23:26Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 24s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 38s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 41s	master passed
+1 💚	compile	3m 15s	master passed
+1 💚	checkstyle	0m 52s	master passed
+1 💚	spotless	0m 39s	branch has no errors when running spotless:check.
+1 💚	spotbugs	2m 18s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 10s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 14s	the patch passed
+1 💚	compile	3m 11s	the patch passed
+1 💚	javac	3m 11s	the patch passed
+1 💚	checkstyle	0m 7s	The patch passed checkstyle in hbase-hadoop-compat
+1 💚	checkstyle	0m 12s	hbase-client: The patch generated 0 new + 0 unchanged - 2 fixed = 0 total (was 2)
+1 💚	checkstyle	0m 32s	The patch passed checkstyle in hbase-server
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	12m 25s	Patch does not cause any errors with Hadoop 3.2.4 3.3.4.
+1 💚	spotless	0m 37s	patch has no errors when running spotless:check.
-1 ❌	spotbugs	0m 28s	hbase-hadoop-compat generated 4 new + 0 unchanged - 0 fixed = 4 total (was 0)
		_ Other Tests _
+1 💚	asflicense	0m 22s	The patch does not generate ASF License warnings.
		42m 57s

Reason	Tests
FindBugs	module:hbase-hadoop-compat
	Inconsistent synchronization of org.apache.hadoop.hbase.regionserver.MetricsUserSourceImpl.appendHisto; locked 50% of time Unsynchronized access at MetricsUserSourceImpl.java:50% of time Unsynchronized access at MetricsUserSourceImpl.java:[line 253]
	Inconsistent synchronization of org.apache.hadoop.hbase.regionserver.MetricsUserSourceImpl.getHisto; locked 50% of time Unsynchronized access at MetricsUserSourceImpl.java:50% of time Unsynchronized access at MetricsUserSourceImpl.java:[line 241]
	Inconsistent synchronization of org.apache.hadoop.hbase.regionserver.MetricsUserSourceImpl.incrementHisto; locked 50% of time Unsynchronized access at MetricsUserSourceImpl.java:50% of time Unsynchronized access at MetricsUserSourceImpl.java:[line 247]
	Inconsistent synchronization of org.apache.hadoop.hbase.regionserver.MetricsUserSourceImpl.scanTimeHisto; locked 50% of time Unsynchronized access at MetricsUserSourceImpl.java:50% of time Unsynchronized access at MetricsUserSourceImpl.java:[line 264]

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5067/8/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5067
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux ee708783df42 5.4.0-1097-aws #105~18.04.1-Ubuntu SMP Mon Feb 13 17:50:57 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `735fb43`
Default Java	Eclipse Adoptium-11.0.17+8
spotbugs	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5067/8/artifact/yetus-general-check/output/new-spotbugs-hbase-hadoop-compat.html
Max. process+thread count	86 (vs. ulimit of 30000)
modules	C: hbase-hadoop-compat hbase-client hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5067/8/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-03-26T23:30:33Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 24s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 31s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 39s	master passed
+1 💚	compile	1m 11s	master passed
+1 💚	shadedjars	4m 35s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 46s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 18s	the patch passed
+1 💚	compile	1m 10s	the patch passed
+1 💚	javac	1m 10s	the patch passed
+1 💚	shadedjars	4m 32s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 46s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 33s	hbase-hadoop-compat in the patch passed.
+1 💚	unit	1m 22s	hbase-client in the patch passed.
+1 💚	unit	202m 29s	hbase-server in the patch passed.
		230m 2s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5067/8/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5067
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 6487f26dcda0 5.4.0-1094-aws #102~18.04.1-Ubuntu SMP Tue Jan 10 21:07:03 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `735fb43`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5067/8/testReport/
Max. process+thread count	2704 (vs. ulimit of 30000)
modules	C: hbase-hadoop-compat hbase-client hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5067/8/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-03-26T23:47:17Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 55s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 17s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 51s	master passed
+1 💚	compile	1m 12s	master passed
+1 💚	shadedjars	4m 22s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 51s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 50s	the patch passed
+1 💚	compile	1m 11s	the patch passed
+1 💚	javac	1m 11s	the patch passed
+1 💚	shadedjars	4m 21s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 51s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 36s	hbase-hadoop-compat in the patch passed.
+1 💚	unit	1m 7s	hbase-client in the patch passed.
+1 💚	unit	220m 26s	hbase-server in the patch passed.
		246m 49s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5067/8/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5067
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux f8665e8ff94b 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `735fb43`
Default Java	Temurin-1.8.0_352-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5067/8/testReport/
Max. process+thread count	2551 (vs. ulimit of 30000)
modules	C: hbase-hadoop-compat hbase-client hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5067/8/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Signed-off-by: Xiaolin Ha <[email protected]>

bbeaudreault requested a review from sunhelly March 3, 2023 12:54

bbeaudreault mentioned this pull request Mar 3, 2023

HBASE-27681 Refactor Table Latency Metrics #5072

Merged

bbeaudreault force-pushed the HBASE-27532 branch from ca0171d to 44ccb81 Compare March 7, 2023 21:38

bbeaudreault commented Mar 9, 2023

View reviewed changes

bbeaudreault added 2 commits March 9, 2023 15:32

HBASE-27532 Add block bytes scanned metrics

47b18ef

Rename server side counter to blockBytesScanned Add to ScanMetrics as countOfBlockBytesScanned, and incorporate into TestScannerBlockSizeLimits

Add overall counter and per-request histogram to table and regionserv…

6dc20c7

…er metrics in jmx

bbeaudreault force-pushed the HBASE-27532 branch from 99c7790 to 6dc20c7 Compare March 9, 2023 20:35

sunhelly approved these changes Mar 20, 2023

View reviewed changes

suppress checkstyle warning

54e6d6a

bbeaudreault merged commit c825c96 into apache:master Mar 27, 2023

bbeaudreault deleted the HBASE-27532 branch March 27, 2023 20:04

bbeaudreault added a commit to HubSpot/hbase that referenced this pull request Mar 27, 2023

HBASE-27532 Add block bytes scanned metrics (apache#5067)

3d4b279

Signed-off-by: Xiaolin Ha <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-27532 Add block bytes scanned metrics #5067

HBASE-27532 Add block bytes scanned metrics #5067

bbeaudreault commented Mar 1, 2023 •

edited

Loading

Apache-HBase commented Mar 1, 2023

Apache-HBase commented Mar 1, 2023

Apache-HBase commented Mar 1, 2023

Apache-HBase commented Mar 7, 2023

Apache-HBase commented Mar 8, 2023

Apache-HBase commented Mar 8, 2023

Apache-HBase commented Mar 8, 2023

Apache-HBase commented Mar 8, 2023

Apache-HBase commented Mar 8, 2023

bbeaudreault commented Mar 8, 2023

Apache-HBase commented Mar 8, 2023

Apache-HBase commented Mar 8, 2023

Apache-HBase commented Mar 8, 2023

bbeaudreault commented Mar 9, 2023

bbeaudreault Mar 9, 2023 •

edited

Loading

Apache-HBase commented Mar 9, 2023

Apache-HBase commented Mar 9, 2023

Apache-HBase commented Mar 10, 2023

Apache-HBase commented Mar 10, 2023

sunhelly left a comment

sunhelly commented Mar 20, 2023

bbeaudreault commented Mar 26, 2023

Apache-HBase commented Mar 26, 2023

Apache-HBase commented Mar 26, 2023

Apache-HBase commented Mar 26, 2023

HBASE-27532 Add block bytes scanned metrics #5067

HBASE-27532 Add block bytes scanned metrics #5067

Conversation

bbeaudreault commented Mar 1, 2023 • edited Loading

Apache-HBase commented Mar 1, 2023

Apache-HBase commented Mar 1, 2023

Apache-HBase commented Mar 1, 2023

Apache-HBase commented Mar 7, 2023

Apache-HBase commented Mar 8, 2023

Apache-HBase commented Mar 8, 2023

Apache-HBase commented Mar 8, 2023

Apache-HBase commented Mar 8, 2023

Apache-HBase commented Mar 8, 2023

bbeaudreault commented Mar 8, 2023

Apache-HBase commented Mar 8, 2023

Apache-HBase commented Mar 8, 2023

Apache-HBase commented Mar 8, 2023

bbeaudreault commented Mar 9, 2023

bbeaudreault Mar 9, 2023 • edited Loading

Choose a reason for hiding this comment

Apache-HBase commented Mar 9, 2023

Apache-HBase commented Mar 9, 2023

Apache-HBase commented Mar 10, 2023

Apache-HBase commented Mar 10, 2023

sunhelly left a comment

Choose a reason for hiding this comment

sunhelly commented Mar 20, 2023

bbeaudreault commented Mar 26, 2023

Apache-HBase commented Mar 26, 2023

Apache-HBase commented Mar 26, 2023

Apache-HBase commented Mar 26, 2023

bbeaudreault commented Mar 1, 2023 •

edited

Loading

bbeaudreault Mar 9, 2023 •

edited

Loading