HBASE-27632 Refactor WAL.Reader implementation so we can better suppo… #5055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
The PR is big, but most files are just boiler plate changes as we changed the class name for reading a WAL file. The most important things are:
Thanks. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
OK, good. All green! |
thangTang
reviewed
Mar 8, 2023
| /** | ||
| * Get the current reading position. | ||
| */ | ||
| long getPosition() throws IOException; |
There was a problem hiding this comment.
I noticed that WALTailingReader and WALStreamReader these two interfaces both declare this method, totally same. Then the specific implementation classes ProtobufWALStreamReader and ProtobufWALTailingReader do not implement it, but implements it through the parent abstract class AbstractProtobufWALReader.
So I think maybe you can delete it in these two interfaces.
There was a problem hiding this comment.
The upper layer can only get a WALTailingReader or WALStreamReader, they can not see the AbstractProtobufWALReader... So if we remove this method from these two interfaces, the upper layer classes can not use this method any more...
There was a problem hiding this comment.
Got it. Thank you.
I've read through the entire patch as best I can, and haven't found anything wrong.
thangTang
reviewed
Mar 8, 2023
…rt WAL splitting and replication
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
GeorryHuang
reviewed
Mar 9, 2023
| @@ -5669,12 +5676,17 @@ private long replayRecoveredEdits(final Path edits, Map<byte[], Long> maxSeqIdIn | |||
| coprocessorHost.postReplayWALs(this.getRegionInfo(), edits); | |||
| } | |||
| } catch (EOFException eof) { | |||
| Path p = WALSplitUtil.moveAsideBadEditsFile(walFS, edits); | |||
There was a problem hiding this comment.
Have we never ignored EOF before?
There was a problem hiding this comment.
In the old ProtobufLogReader implementation, usually we will not throw EOFException out, so in the past this is not a big problem. But anyway, we could open a issue to backport this change to branch-2.x.
| /** | ||
| * When outside clients need to consume persisted WALs, they rely on a provided Reader. | ||
| */ | ||
| interface Reader extends Closeable { |
| } catch (EOFException e) { | ||
| throw new WALHeaderEOFException("EOF while reading PB WAL magic", e); | ||
| } | ||
| if (!Arrays.equals(PB_WAL_MAGIC, magic)) { |
There was a problem hiding this comment.
Is it our first time checking PB_WAL_MAGIC? I found out we just skip its bytes length before.
There was a problem hiding this comment.
Yes, in the old implementation we just skip these bytes. I think it is OK here as the magic is short so we will not add too much pressure?
| return header; | ||
| } | ||
|
|
||
| private void initDecryptor(WALProtos.WALHeader header) throws IOException { |
There was a problem hiding this comment.
Great! we merge SecureProtobufLogReader and ProtobufLogReader here.
| // is a partial trailer | ||
| return true; | ||
| } | ||
| if (r != 0) { |
There was a problem hiding this comment.
Is the length of the current HBase implementation WALTrailer all 0?
There was a problem hiding this comment.
Yes, there is nothing in the trailer yet. There is a UT to confirm this, see this line
GeorryHuang
reviewed
Mar 9, 2023
| } | ||
| } | ||
|
|
||
| private Reader getReader(String wal) throws IOException { | ||
| private WALStreamReader getReader(String wal) throws IOException { |
There was a problem hiding this comment.
Why didn't we use TailingReader in this replication scenario?
There was a problem hiding this comment.
This is WAL replay. Although it is part of the sync replication implementation, it is not for 'replicating' data, it does not need to tail the WAL file, just read the file once and replay the edits.
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Apache9
added a commit
that referenced
this pull request
Mar 10, 2023
…rt WAL splitting and replication (#5055) Signed-off-by: GeorryHuang <[email protected]> (cherry picked from commit e48c448) Conflicts: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplaySyncReplicationWALCallable.java hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/WALEntryStream.java hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/AbstractTestProtobufLog.java hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/ProtobufLogTestHelper.java hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestCombinedAsyncWriter.java hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestSyncReplicationActive.java hbase-server/src/test/java/org/apache/hadoop/hbase/wal/TestSyncReplicationWALProvider.java hbase-server/src/test/java/org/apache/hadoop/hbase/wal/TestWALReaderOnSecureWAL.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rt WAL splitting and replication