HBASE-27644 Should not return false when WALKey has no following KVs … #5032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
virajjasani
reviewed
Feb 22, 2023
Comment on lines
411
to
412
| LOG.trace("WALKey has no KVs that follow it; trying the next one. current offset={}", | ||
| this.inputStream.getPos()); |
There was a problem hiding this comment.
Wow, that's a big one. When I saw dataloss explanation, I wanted to check for logs WALKey has no KVs that follow it; trying the next one. to see how many, if at all num of such references we see but then realized it is at TRACE level. Shall we make it at least DEBUG level?
There was a problem hiding this comment.
I'm OK with changing it to DEBUG, can file a new issue?
There was a problem hiding this comment.
Oh I thought this was a PR which has already been merged so I said we can file a new issue for this...
Let me change the log level and update the PR...
| @@ -410,8 +410,7 @@ protected boolean readNext(Entry entry) throws IOException { | |||
| if (!walKey.hasFollowingKvCount() || 0 == walKey.getFollowingKvCount()) { | |||
| LOG.trace("WALKey has no KVs that follow it; trying the next one. current offset={}", | |||
| this.inputStream.getPos()); | |||
| seekOnFs(originalPosition); | |||
| return false; | |||
| return true; | |||
There was a problem hiding this comment.
For the core change, I wonder if it might still be possible to have replication delays with specific encryption as explained on HBASE-20604.
(though possible dataloss during WAL splitting is definitely much serious case to consider)
There was a problem hiding this comment.
In general I do not think a partial data can cause the protobuf message to have wrong field values, it will just fail the parsing of the WALKey message and we will return earlier. So if we can successfully parse the WALKey message, and the following kv count is 0, it means that the kv count is 0 when writting, it does not mean the kv data is not available yet...
If this is not the case, then I think it should be a serious bug of CryptoInputStream, as it may return incorrect bytes...
There was a problem hiding this comment.
Yeah that is quite reasonable.
virajjasani
approved these changes
Feb 22, 2023
…while reading WAL file
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Apache9
added a commit
that referenced
this pull request
Feb 26, 2023
…while reading WAL file (#5032) Signed-off-by: Viraj Jasani <[email protected]> (cherry picked from commit 4a9cf99) Conflicts: hbase-server/src/test/java/org/apache/hadoop/hbase/wal/TestWALSplit.java
Apache9
added a commit
that referenced
this pull request
Feb 26, 2023
…while reading WAL file (#5032) Signed-off-by: Viraj Jasani <[email protected]> (cherry picked from commit 4a9cf99) Conflicts: hbase-server/src/test/java/org/apache/hadoop/hbase/wal/TestWALSplit.java
Apache9
added a commit
that referenced
this pull request
Feb 26, 2023
…while reading WAL file (#5032) Signed-off-by: Viraj Jasani <[email protected]> (cherry picked from commit 4a9cf99)
vinayakphegde
pushed a commit
to vinayakphegde/hbase
that referenced
this pull request
Apr 4, 2024
…while reading WAL file (apache#5032) Signed-off-by: Viraj Jasani <[email protected]> (cherry picked from commit 4a9cf99) Conflicts: hbase-server/src/test/java/org/apache/hadoop/hbase/wal/TestWALSplit.java (cherry picked from commit 22093cb) Change-Id: I77cda7c09a46b031848f637edfa09951ce512a7f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…while reading WAL file