-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HBASE-27560 fix consistencyCheck did not report the hole on last region #4950
Conversation
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
So the problem here is that, if the table is disabled, we will skip checking but in the old code, we will still record the previous region info, so the check for the previous table's last region will be skipped? The fix here is to not record the previous region for disabled table? What if there are only two tables, one is enabled and we check it first, the other is disabled? Do we still have chance to check the last region for the enabled table? |
🎊 +1 overall
This message was automatically generated. |
Think you for review, Exactly as you said, The old code just lose previous region info when the next table is disabled. In the scenario you mentioned, ReportMakingVisitor will keep the previous region info and check it on visitor close, just like it is the last table
|
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
…on (#4950) Signed-off-by: Duo Zhang <[email protected]> (cherry picked from commit c1b9d8b)
…on (#4950) Signed-off-by: Duo Zhang <[email protected]> (cherry picked from commit c1b9d8b)
…on (#4950) Signed-off-by: Duo Zhang <[email protected]> (cherry picked from commit c1b9d8b)
…on (apache#4950) Signed-off-by: Duo Zhang <[email protected]> (cherry picked from commit c1b9d8b) (cherry picked from commit 56ebf93) Change-Id: I7b604e9e2ac66866ddec0856df4dddb2c58941bd
No description provided.