-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HBASE-27541 Add support for defining restore hfile output path #4933
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
a76969c
to
5a29f8a
Compare
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/RestoreJob.java
Outdated
Show resolved
Hide resolved
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/RestoreTablesClient.java
Outdated
Show resolved
Hide resolved
f01b36c
to
18b2756
Compare
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/BackupInfo.java
Outdated
Show resolved
Hide resolved
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/BackupInfo.java
Outdated
Show resolved
Hide resolved
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/BackupRequest.java
Outdated
Show resolved
Hide resolved
c1c7201
to
25a283c
Compare
🎊 +1 overall
This message was automatically generated. |
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/util/BackupUtils.java
Outdated
Show resolved
Hide resolved
try { | ||
return BackupUtils.getBulkOutputDir("test", conf, false); | ||
try (FileSystem fs = FileSystem.get(conf)) { | ||
String tmp = conf.get(HConstants.TEMPORARY_FS_DIRECTORY_KEY, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should probably make this a util method somewhere rather than duplicate it in all the tests... it could be in BackupUtils or maybe CommonFSUtils
hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/TestRemoteRestore.java
Show resolved
Hide resolved
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
f388a5c
to
32eb542
Compare
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
32eb542
to
c4e6056
Compare
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we're almost ready to merge. One last request
hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/TestBackupUtils.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Bryan Beaudreault <[email protected]> Extract tmp restore output dir
c4e6056
to
c099a8c
Compare
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
…ystem (#4933) Signed-off-by: Bryan Beaudreault <[email protected]>
…o a separate filesystem (apache#4933) Signed-off-by: Bryan Beaudreault <[email protected]>
No description provided.