-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HBASE-27540: add client side counter metrics for failed rpc calls. #4929
Conversation
hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetricsConnection.java
Outdated
Show resolved
Hide resolved
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but I think you need to run mvn spotless:apply
Yes, just committed the changes. Thanks! |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good! i also like the log change.
branch-2 currently has a build issue. will merge and cherry-pick there once i see that resolved.
Signed-off-by: Bryan Beaudreault <[email protected]>
Signed-off-by: Bryan Beaudreault <[email protected]>
Signed-off-by: Bryan Beaudreault <[email protected]>
…che#4929) Signed-off-by: Bryan Beaudreault <[email protected]>
…che#4929) Signed-off-by: Bryan Beaudreault <[email protected]> (cherry picked from commit 7f7fe55) Change-Id: Ib70375dfd67967815c7c20e53e9f408fe38c1b61
No description provided.