HBASE-27484 FNFE on StoreFileScanner after a flush followed by a compaction #4882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…action Change-Id: I6d31a361f0198d0527d2a41309fc90950cf0cd76
|
💔 -1 overall
This message was automatically generated. |
Apache9
reviewed
Nov 15, 2022
| @@ -961,10 +961,10 @@ public List<KeyValueScanner> getScanners(boolean cacheBlocks, boolean usePread, | |||
| storeFilesToScan = this.storeEngine.getStoreFileManager().getFilesForScan(startRow, | |||
| includeStartRow, stopRow, includeStopRow); | |||
| memStoreScanners = this.memstore.getScanners(readPt); | |||
| storeFilesToScan.stream().forEach(f->f.getReader().incrementRefCount()); | |||
There was a problem hiding this comment.
Is it possible that the storefiles are deleted before we increment ref count here?
There was a problem hiding this comment.
We are inside a storeEngine.readLock here. The delete code also is under the same lock, so if we reach this point, we are sure the files were not deleted yet.
There was a problem hiding this comment.
Then there is no problem for the old code either? Since we are under the lock? I do not fully get the point why here we could fix the problem? Mind adding more comment in the code? Thanks.
There was a problem hiding this comment.
OK, we will release the lock immediately after getting the file list, so when we actually get the store file scanner, the file may have already been archived.
I think a simple fix is to just move the getting scanner code into the read lock section? As here you only increase the lock if the reader is not null, it is still possible that some files are archived later?
There was a problem hiding this comment.
I think one problem of moving the getting scanner code into the read lock section is that in StoreFileScanner.getScannersForStoreFiles method , it would call HStoreFile.initReader , which would make the storeEngine.readLock locked somewhat long time? Another option is that since StoreFileReader.refCount comes from StoreFileInfo.refCount, we can increase the StoreFileInfo.refCount by HStoreFile.fileInfo?
There was a problem hiding this comment.
it would call HStoreFile.initReader , which would make the storeEngine.readLock locked somewhat long time? Another option is that since StoreFileReader.refCount comes from StoreFileInfo.refCount, we can increase the StoreFileInfo.refCount by HStoreFile.fileInfo?
Yeah, didn't want to move the SFR/SFS initialisation inside this read lock. I had updated the code to inc refCount via StoreFileInfo, as @comnetwork suggested.
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
Change-Id: I7da97865ba0fc51015db7bbdf92286c643c387c9
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHStore.java
Show resolved
Hide resolved
Change-Id: Ib8d0df078cbb4daca8240792c2cbbfd7dae183bd
petersomogyi
approved these changes
Nov 15, 2022
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHStore.java
Show resolved
Hide resolved
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
…Reader Change-Id: Icca80de53a2021fd5d169cf03525fb6f59a8f874
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
wchevreuil
added a commit
that referenced
this pull request
Nov 26, 2022
…action (#4882) Signed-off-by: Peter Somogyi <[email protected]>
|
Sorry a bit late, but at least let's add more comments in code? |
wchevreuil
added a commit
that referenced
this pull request
Nov 29, 2022
…action (#4882) Signed-off-by: Peter Somogyi <[email protected]>
wchevreuil
added a commit
that referenced
this pull request
Nov 29, 2022
…action (#4882) Signed-off-by: Peter Somogyi <[email protected]>
vinayakphegde
pushed a commit
to vinayakphegde/hbase
that referenced
this pull request
Apr 4, 2024
…action (apache#4882) Signed-off-by: Peter Somogyi <[email protected]> (cherry picked from commit 6e562bb) Change-Id: I49a5514b3183017eb245e879fd1d6cc1885f88b6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.