-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HBASE-27444 Add tool commands list_enabled_tables and list_disabled_tables #4880
Conversation
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
0f29e3b
to
c93f07f
Compare
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
Please fix the checkstyle issue? |
OK, sir, I will solve the checkstyle issue with a new commit. |
🎊 +1 overall
This message was automatically generated. |
Is it possible to also fix the remaining rubocop issues? |
@Apache9 sir, One of the rubocop issues is "[Correctable] Style/FrozenStringLiteralComment: Missing frozen string literal comment", do we have a unified solution for this. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
I added the following content to the .rubocop.yml file to solve the rubocop issue: |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
The above solution seems to be not working well. I'm looking at how to solve it. |
Ah, let's not add the ignore file? I think we can merge the PR first, without fixing all the rubocop issues. Just align the shell code with master branch as much as possible is enough. Thanks. |
799b625
to
903c255
Compare
@Apache9 OK, sir. I have a new commit, please wait for the UT execution to complete. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
The failed UTs seems to have nothing to do with my modification. |
https://issues.apache.org/jira/browse/HBASE-27444