HBASE-27469 IllegalArgumentException is thrown by SnapshotScannerHDFS… #4865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
Apache9
reviewed
Nov 7, 2022
| @@ -132,8 +132,7 @@ public void preMasterInitialization(ObserverContext<MasterCoprocessorEnvironment | |||
| userProvider = UserProvider.instantiate(c.getEnvironment().getConfiguration()); | |||
| } else { | |||
| LOG.warn("Try to initialize the coprocessor SnapshotScannerHDFSAclController but failure " | |||
| + "because the config " + SnapshotScannerHDFSAclHelper.ACL_SYNC_TO_HDFS_ENABLE | |||
| + " is false."); | |||
| + "because the config {} is false.", SnapshotScannerHDFSAclHelper.ACL_SYNC_TO_HDFS_ENABLE); | |||
There was a problem hiding this comment.
Since SnapshotScannerHDFSAclHelper.ACL_SYNC_TO_HDFS_ENABLE is a constant, I think the old way can have better performance?
| @@ -610,7 +609,8 @@ private Set<String> filterUsersToRemoveNsAccessAcl(Table aclTable, TableName tab | |||
| PermissionStorage.isGlobalEntry(entry) | |||
| || (PermissionStorage.isNamespaceEntry(entry) | |||
| && Bytes.equals(PermissionStorage.fromNamespaceEntry(entry), namespace)) | |||
| || (!Bytes.equals(tableName.getName(), entry) | |||
| || (PermissionStorage.isTableEntry(entry) | |||
There was a problem hiding this comment.
So this is the problem we want to fix? Mind explaining more?
There was a problem hiding this comment.
Yes, this is the problem.
The userEntries from hbase:acl contains namespaces (beginning with '@' like '@ns1') and tables, before we call TableName.valueOf(entry), must make sure it is a table name and not a namespace name. If a namespace name goes there, TableName.valueOf(entry) will throw IllegalArgumentException since char '@'.
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
…AclController when dropping a table
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
The failed UT TestReplicationKillMasterRSWithSeparateOldWALs is not related. It seems like a bug, I'll try to fix it in HBASE-27476. |
Apache9
approved these changes
Nov 10, 2022
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
ddupg
added a commit
that referenced
this pull request
Nov 15, 2022
…AclController when dropping a table (#4865) Signed-off-by: Duo Zhang <[email protected]>
ddupg
added a commit
that referenced
this pull request
Nov 15, 2022
…AclController when dropping a table (#4865) Signed-off-by: Duo Zhang <[email protected]>
ddupg
added a commit
that referenced
this pull request
Nov 15, 2022
…AclController when dropping a table (#4865) Signed-off-by: Duo Zhang <[email protected]>
vinayakphegde
pushed a commit
to vinayakphegde/hbase
that referenced
this pull request
Apr 4, 2024
…AclController when dropping a table (apache#4865) Signed-off-by: Duo Zhang <[email protected]> (cherry picked from commit f7b2efc) Change-Id: I345b022035b43d5486b9eb513247134930f3a82e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…AclController when dropping a table