-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HBASE-27167 s390x: Skip tests on unsupported compression libs #4852
Conversation
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
Have you tried it locally on s390x to see whether it can skip the tests? I'm not sure whether the arch name is 's390x' or something else as I do not have a 390x machine... Thanks. |
Yes, I've been testing locally on s390x VMs and the profile is getting activated properly. The maven docs say to see the enforcer plugin for the os values and on s390x
for example. |
Signed-off-by: Duo Zhang <[email protected]> (cherry picked from commit d9713bf)
Signed-off-by: Duo Zhang <[email protected]> (cherry picked from commit d9713bf)
Thanks @Apache9 ! |
The brotli4j and aircompressor dependencies don't have s390x arch support yet. Even though aircompressor is pure java, it only supports little-endian right now.
This PR adds profiles to automatically set skipTests for
hbase-compression-aircompressor
andhbase-compression-brotli
on s390x so builds can complete successfully.