Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HBASE-27167 s390x: Skip tests on unsupported compression libs #4852

Merged
merged 1 commit into from
Oct 28, 2022

Conversation

jonathan-albrecht-ibm
Copy link
Contributor

The brotli4j and aircompressor dependencies don't have s390x arch support yet. Even though aircompressor is pure java, it only supports little-endian right now.

This PR adds profiles to automatically set skipTests for hbase-compression-aircompressor and hbase-compression-brotli on s390x so builds can complete successfully.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 28s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for branch
+1 💚 mvninstall 2m 22s master passed
+1 💚 compile 0m 26s master passed
+1 💚 shadedjars 3m 50s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 24s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for patch
+1 💚 mvninstall 2m 15s the patch passed
+1 💚 compile 0m 26s the patch passed
+1 💚 javac 0m 26s the patch passed
+1 💚 shadedjars 3m 47s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 23s the patch passed
_ Other Tests _
+1 💚 unit 0m 46s hbase-compression-aircompressor in the patch passed.
+1 💚 unit 0m 36s hbase-compression-brotli in the patch passed.
17m 19s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4852/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #4852
Optional Tests javac javadoc unit shadedjars compile
uname Linux d7d88d9a5eca 5.4.0-109-generic #123-Ubuntu SMP Fri Apr 8 09:10:54 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 5e251c4
Default Java Temurin-1.8.0_345-b01
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4852/1/testReport/
Max. process+thread count 814 (vs. ulimit of 30000)
modules C: hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-brotli U: hbase-compression
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4852/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 3m 17s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for branch
+1 💚 mvninstall 2m 36s master passed
+1 💚 compile 0m 24s master passed
+1 💚 shadedjars 3m 55s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 21s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for patch
+1 💚 mvninstall 2m 25s the patch passed
+1 💚 compile 0m 24s the patch passed
+1 💚 javac 0m 24s the patch passed
+1 💚 shadedjars 3m 53s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 19s the patch passed
_ Other Tests _
+1 💚 unit 0m 50s hbase-compression-aircompressor in the patch passed.
+1 💚 unit 0m 33s hbase-compression-brotli in the patch passed.
20m 41s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4852/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #4852
Optional Tests javac javadoc unit shadedjars compile
uname Linux 9d27a9f3afb6 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 5e251c4
Default Java Eclipse Adoptium-11.0.16.1+1
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4852/1/testReport/
Max. process+thread count 582 (vs. ulimit of 30000)
modules C: hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-brotli U: hbase-compression
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4852/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 44s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗 mvndep 0m 19s Maven dependency ordering for branch
+1 💚 mvninstall 2m 23s master passed
+1 💚 compile 0m 30s master passed
+1 💚 spotless 0m 38s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 10s Maven dependency ordering for patch
+1 💚 mvninstall 2m 5s the patch passed
+1 💚 compile 0m 27s the patch passed
+1 💚 javac 0m 27s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 2s The patch has no ill-formed XML file.
+1 💚 hadoopcheck 7m 51s Patch does not cause any errors with Hadoop 3.2.4 3.3.4.
+1 💚 spotless 0m 35s patch has no errors when running spotless:check.
_ Other Tests _
+1 💚 asflicense 0m 14s The patch does not generate ASF License warnings.
21m 19s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4852/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #4852
Optional Tests dupname asflicense javac hadoopcheck spotless xml compile
uname Linux 2a1385f1c57b 5.4.0-1088-aws #96~18.04.1-Ubuntu SMP Mon Oct 17 02:57:48 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 5e251c4
Default Java Temurin-1.8.0_345-b01
Max. process+thread count 69 (vs. ulimit of 30000)
modules C: hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-brotli U: hbase-compression
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4852/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache9
Copy link
Contributor

Apache9 commented Oct 27, 2022

Have you tried it locally on s390x to see whether it can skip the tests? I'm not sure whether the arch name is 's390x' or something else as I do not have a 390x machine...

Thanks.

@jonathan-albrecht-ibm
Copy link
Contributor Author

Yes, I've been testing locally on s390x VMs and the profile is getting activated properly. The maven docs say to see the enforcer plugin for the os values and on s390x mvn enforcer:display-info gives:

[INFO] OS Info: Arch: s390x Family: unix Name: linux Version: 5.15.0-52-generic

for example.

@Apache9 Apache9 merged commit d9713bf into apache:master Oct 28, 2022
Apache9 pushed a commit that referenced this pull request Oct 28, 2022
Apache9 pushed a commit that referenced this pull request Oct 28, 2022
@jonathan-albrecht-ibm
Copy link
Contributor Author

Thanks @Apache9 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants