HBASE-27369 BufferedMutator#mutate supports mutation type verification #4780

2005hithlj · 2022-09-13T15:53:30Z

https://issues.apache.org/jira/browse/HBASE-27369

Apache-HBase · 2022-09-13T16:23:20Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 41s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 48s	master passed
+1 💚	compile	0m 18s	master passed
+1 💚	shadedjars	3m 56s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 17s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 23s	the patch passed
+1 💚	compile	0m 17s	the patch passed
+1 💚	javac	0m 17s	the patch passed
+1 💚	shadedjars	3m 56s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 14s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 20s	hbase-client in the patch passed.
		17m 14s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4780/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4780
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux ca8f2affb216 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `b3a0489`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4780/1/testReport/
Max. process+thread count	197 (vs. ulimit of 30000)
modules	C: hbase-client U: hbase-client
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4780/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-09-13T16:25:48Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	3m 50s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 31s	master passed
+1 💚	compile	0m 16s	master passed
+1 💚	shadedjars	4m 0s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 15s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 4s	the patch passed
+1 💚	compile	0m 15s	the patch passed
+1 💚	javac	0m 15s	the patch passed
+1 💚	shadedjars	3m 58s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 13s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 7s	hbase-client in the patch passed.
		19m 33s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4780/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4780
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 4994194257ca 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `b3a0489`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4780/1/testReport/
Max. process+thread count	160 (vs. ulimit of 30000)
modules	C: hbase-client U: hbase-client
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4780/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-09-13T16:29:16Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 34s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	2m 23s	master passed
+1 💚	compile	0m 36s	master passed
+1 💚	checkstyle	0m 13s	master passed
+1 💚	spotless	0m 41s	branch has no errors when running spotless:check.
+1 💚	spotbugs	0m 37s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 5s	the patch passed
+1 💚	compile	0m 35s	the patch passed
+1 💚	javac	0m 35s	the patch passed
+1 💚	checkstyle	0m 13s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	8m 17s	Patch does not cause any errors with Hadoop 3.2.4 3.3.4.
+1 💚	spotless	0m 36s	patch has no errors when running spotless:check.
+1 💚	spotbugs	0m 40s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 8s	The patch does not generate ASF License warnings.
		22m 59s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4780/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4780
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux 4a407cc492fa 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `b3a0489`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count	64 (vs. ulimit of 30000)
modules	C: hbase-client U: hbase-client
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4780/1/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

2005hithlj · 2022-09-14T13:44:42Z

@carp84 sir. Could you take a look? Thanks.

Apache9

I think we should add the check in AsyncBufferedMutator? BufferedMutator is just a delegation of AsyncBufferedMutator.

2005hithlj · 2022-09-15T01:21:46Z

I think we should add the check in AsyncBufferedMutator? BufferedMutator is just a delegation of AsyncBufferedMutator.
@Apache9 sir. Thanks for your review.
Although BufferedMutator is a delegation of AsyncBufferedMutator, but BufferedMutatorOverAsyncBufferedMutator#mutate does not directly call AsyncBufferedMutator#mutate, so it needs to be done in both BufferedMutatorOverAsyncBufferedMutator#mutate and AsyncBufferedMutator#mutate.
And I did it in the new commit.

Apache9 · 2022-09-15T01:25:00Z

I think we should add the check in AsyncBufferedMutator? BufferedMutator is just a delegation of AsyncBufferedMutator.
@Apache9 sir. Thanks for your review.
Although BufferedMutator is a delegation of AsyncBufferedMutator, but BufferedMutatorOverAsyncBufferedMutator#mutate does not directly call AsyncBufferedMutator#mutate, so it needs to be done in both BufferedMutatorOverAsyncBufferedMutator#mutate and AsyncBufferedMutator#mutate.
And I did it in the new commit.

But finally they will go into the mutate(List) method? We just need to add checks there?

Apache-HBase · 2022-09-15T01:41:45Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 40s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 31s	master passed
+1 💚	compile	0m 16s	master passed
+1 💚	shadedjars	4m 6s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 15s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 1s	the patch passed
+1 💚	compile	0m 15s	the patch passed
+1 💚	javac	0m 15s	the patch passed
+1 💚	shadedjars	4m 1s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 13s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 7s	hbase-client in the patch passed.
		16m 25s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4780/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4780
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 2b68221c5bcb 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `00aba9c`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4780/2/testReport/
Max. process+thread count	158 (vs. ulimit of 30000)
modules	C: hbase-client U: hbase-client
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4780/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-09-15T01:42:53Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 5s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 46s	master passed
+1 💚	compile	0m 18s	master passed
+1 💚	shadedjars	3m 48s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 19s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 28s	the patch passed
+1 💚	compile	0m 20s	the patch passed
+1 💚	javac	0m 20s	the patch passed
+1 💚	shadedjars	3m 46s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 17s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 23s	hbase-client in the patch passed.
		17m 35s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4780/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4780
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux f2423487476c 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `00aba9c`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4780/2/testReport/
Max. process+thread count	191 (vs. ulimit of 30000)
modules	C: hbase-client U: hbase-client
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4780/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-09-15T01:48:09Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 36s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	2m 1s	master passed
+1 💚	compile	0m 35s	master passed
+1 💚	checkstyle	0m 11s	master passed
+1 💚	spotless	0m 40s	branch has no errors when running spotless:check.
-1 ❌	spotbugs	0m 36s	hbase-client in master has 10 extant spotbugs warnings.
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 3s	the patch passed
+1 💚	compile	0m 33s	the patch passed
+1 💚	javac	0m 33s	the patch passed
+1 💚	checkstyle	0m 11s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	7m 47s	Patch does not cause any errors with Hadoop 3.2.4 3.3.4.
+1 💚	spotless	0m 35s	patch has no errors when running spotless:check.
+1 💚	spotbugs	0m 41s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 7s	The patch does not generate ASF License warnings.
		22m 41s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4780/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4780
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux b1f60a90a363 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `00aba9c`
Default Java	AdoptOpenJDK-1.8.0_282-b08
spotbugs	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4780/2/artifact/yetus-general-check/output/branch-spotbugs-hbase-client-warnings.html
Max. process+thread count	64 (vs. ulimit of 30000)
modules	C: hbase-client U: hbase-client
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4780/2/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.7.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

2005hithlj · 2022-09-15T02:21:44Z

I think we should add the check in AsyncBufferedMutator? BufferedMutator is just a delegation of AsyncBufferedMutator.
@Apache9 sir. Thanks for your review.
Although BufferedMutator is a delegation of AsyncBufferedMutator, but BufferedMutatorOverAsyncBufferedMutator#mutate does not directly call AsyncBufferedMutator#mutate, so it needs to be done in both BufferedMutatorOverAsyncBufferedMutator#mutate and AsyncBufferedMutator#mutate.
And I did it in the new commit.

But finally they will go into the mutate(List) method? We just need to add checks there?

2005hithlj · 2022-09-15T02:35:39Z

I think we should add the check in AsyncBufferedMutator? BufferedMutator is just a delegation of AsyncBufferedMutator.
@Apache9 sir. Thanks for your review.
Although BufferedMutator is a delegation of AsyncBufferedMutator, but BufferedMutatorOverAsyncBufferedMutator#mutate does not directly call AsyncBufferedMutator#mutate, so it needs to be done in both BufferedMutatorOverAsyncBufferedMutator#mutate and AsyncBufferedMutator#mutate.
And I did it in the new commit.

But finally they will go into the mutate(List) method? We just need to add checks there?

According to the call chain, the check logic should be added to the AsyncBufferedMutatorImpl#mutate(List) method. However, AsyncBufferedMutatorImpl#mutate(List) is a public api, and there is no description of the mutate type restriction in the comments. Besides, AsyncBufferedMutatorImpl#mutate(List) will call the AsyncTable#batch(List) method, which supports the mutation types including Get, Put, Delete, Increment, Append, and RowMutations, so we should not add the check logic to the AsyncBufferedMutatorImpl#mutate(List).

Apache9 · 2022-09-15T02:38:51Z

The problem is about the API design. Increment and Append have return values but the current return values of BufferMutator methods do not return them...

2005hithlj · 2022-09-15T02:43:57Z

@Apache9 Sir. Do you still suggest adding check logic to AsyncBufferedMutatorImpl#mutate(List)?

Apache9 · 2022-09-15T02:45:16Z

@Apache9 Sir. Do you still suggest adding check logic to AsyncBufferedMutatorImpl#mutate(List)?

We'd better start a discssion thread on the dev list to discuss this.

2005hithlj · 2022-09-15T02:57:16Z

@Apache9 Sir. Do you still suggest adding check logic to AsyncBufferedMutatorImpl#mutate(List)?

We'd better start a discssion thread on the dev list to discuss this.

The logic of this part is really a bit confusing, but I may not be able to describe the relevant issues clearly, so I can't effectively start a discussion.

Apache9 · 2022-09-15T03:35:53Z

@Apache9 Sir. Do you still suggest adding check logic to AsyncBufferedMutatorImpl#mutate(List)?

We'd better start a discssion thread on the dev list to discuss this.

The logic of this part is really a bit confusing, but I may not be able to describe the relevant issues clearly, so I can't effectively start a discussion.

Then this could also be thing we should discuss :)

2005hithlj · 2022-09-15T04:35:56Z

@Apache9 sir. I get it. I will start a discussion.

Apache-HBase · 2023-03-03T10:17:41Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 19s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 34s	master passed
+1 💚	compile	0m 20s	master passed
+1 💚	shadedjars	4m 26s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 18s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 20s	the patch passed
+1 💚	compile	0m 19s	the patch passed
+1 💚	javac	0m 19s	the patch passed
+1 💚	shadedjars	4m 23s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 16s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 22s	hbase-client in the patch passed.
		19m 46s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4780/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4780
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux cedbfde8df7f 5.4.0-135-generic #152-Ubuntu SMP Wed Nov 23 20:19:22 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `d2b0074`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4780/1/testReport/
Max. process+thread count	190 (vs. ulimit of 30000)
modules	C: hbase-client U: hbase-client
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4780/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-03-03T10:17:57Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 23s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 3s	master passed
+1 💚	compile	0m 16s	master passed
+1 💚	shadedjars	4m 37s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 14s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 34s	the patch passed
+1 💚	compile	0m 20s	the patch passed
+1 💚	javac	0m 20s	the patch passed
+1 💚	shadedjars	5m 1s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 15s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 29s	hbase-client in the patch passed.
		20m 6s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4780/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4780
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 46155a46c5cb 5.4.0-1094-aws #102~18.04.1-Ubuntu SMP Tue Jan 10 21:07:03 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `d2b0074`
Default Java	Temurin-1.8.0_352-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4780/1/testReport/
Max. process+thread count	164 (vs. ulimit of 30000)
modules	C: hbase-client U: hbase-client
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4780/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-03-03T10:32:30Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 23s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	3m 55s	master passed
+1 💚	compile	0m 39s	master passed
+1 💚	checkstyle	0m 15s	master passed
+1 💚	spotless	0m 44s	branch has no errors when running spotless:check.
+1 💚	spotbugs	0m 46s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 35s	the patch passed
+1 💚	compile	0m 35s	the patch passed
+1 💚	javac	0m 35s	the patch passed
+1 💚	checkstyle	0m 13s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	13m 55s	Patch does not cause any errors with Hadoop 3.2.4 3.3.4.
+1 💚	spotless	0m 41s	patch has no errors when running spotless:check.
+1 💚	spotbugs	0m 48s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 9s	The patch does not generate ASF License warnings.
		34m 35s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4780/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4780
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux 2a727f3c4c7d 5.4.0-1094-aws #102~18.04.1-Ubuntu SMP Tue Jan 10 21:07:03 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `d2b0074`
Default Java	Eclipse Adoptium-11.0.17+8
Max. process+thread count	86 (vs. ulimit of 30000)
modules	C: hbase-client U: hbase-client
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4780/1/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

HBASE-27369 BufferedMutator#mutate supports mutation type verification

3f38dcd

Apache9 reviewed Sep 15, 2022

View reviewed changes

HBASE-27369 BufferedMutator#mutate supports mutation type verification

8a960d3

2005hithlj closed this Sep 15, 2022

2005hithlj reopened this Sep 15, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-27369 BufferedMutator#mutate supports mutation type verification #4780

HBASE-27369 BufferedMutator#mutate supports mutation type verification #4780

2005hithlj commented Sep 13, 2022

Apache-HBase commented Sep 13, 2022

Apache-HBase commented Sep 13, 2022

Apache-HBase commented Sep 13, 2022

2005hithlj commented Sep 14, 2022

Apache9 left a comment

2005hithlj commented Sep 15, 2022

Apache9 commented Sep 15, 2022

Apache-HBase commented Sep 15, 2022

Apache-HBase commented Sep 15, 2022

Apache-HBase commented Sep 15, 2022

2005hithlj commented Sep 15, 2022

2005hithlj commented Sep 15, 2022

Apache9 commented Sep 15, 2022

2005hithlj commented Sep 15, 2022

Apache9 commented Sep 15, 2022

2005hithlj commented Sep 15, 2022

Apache9 commented Sep 15, 2022

2005hithlj commented Sep 15, 2022

Apache-HBase commented Mar 3, 2023

Apache-HBase commented Mar 3, 2023

Apache-HBase commented Mar 3, 2023

HBASE-27369 BufferedMutator#mutate supports mutation type verification #4780

Are you sure you want to change the base?

HBASE-27369 BufferedMutator#mutate supports mutation type verification #4780

Conversation

2005hithlj commented Sep 13, 2022

Apache-HBase commented Sep 13, 2022

Apache-HBase commented Sep 13, 2022

Apache-HBase commented Sep 13, 2022

2005hithlj commented Sep 14, 2022

Apache9 left a comment

Choose a reason for hiding this comment

2005hithlj commented Sep 15, 2022

Apache9 commented Sep 15, 2022

Apache-HBase commented Sep 15, 2022

Apache-HBase commented Sep 15, 2022

Apache-HBase commented Sep 15, 2022

2005hithlj commented Sep 15, 2022

2005hithlj commented Sep 15, 2022

Apache9 commented Sep 15, 2022

2005hithlj commented Sep 15, 2022

Apache9 commented Sep 15, 2022

2005hithlj commented Sep 15, 2022

Apache9 commented Sep 15, 2022

2005hithlj commented Sep 15, 2022

Apache-HBase commented Mar 3, 2023

Apache-HBase commented Mar 3, 2023

Apache-HBase commented Mar 3, 2023