Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HBASE-27295 Correct the comment of list_deadservers method in admin.rb #4694

Merged
merged 1 commit into from
Aug 17, 2022
Merged

HBASE-27295 Correct the comment of list_deadservers method in admin.rb #4694

merged 1 commit into from
Aug 17, 2022

Conversation

2005hithlj
Copy link
Contributor

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 5s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+1 💚 mvninstall 2m 27s master passed
+1 💚 spotless 0m 43s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 💚 mvninstall 2m 13s the patch passed
+1 💚 rubocop 0m 5s There were no new rubocop issues.
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 spotless 0m 43s patch has no errors when running spotless:check.
_ Other Tests _
+1 💚 asflicense 0m 11s The patch does not generate ASF License warnings.
8m 49s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4694/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #4694
Optional Tests dupname asflicense javac spotless rubocop
uname Linux a2f9d041e1e8 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 39b496e
Default Java AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count 46 (vs. ulimit of 30000)
modules C: hbase-shell U: hbase-shell
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4694/1/console
versions git=2.17.1 maven=3.6.3 rubocop=0.80.0
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 38s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 2m 23s master passed
+1 💚 javadoc 0m 11s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 2m 6s the patch passed
+1 💚 javadoc 0m 8s the patch passed
_ Other Tests _
+1 💚 unit 7m 35s hbase-shell in the patch passed.
14m 5s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4694/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #4694
Optional Tests javac javadoc unit
uname Linux b2b97f56e963 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 39b496e
Default Java AdoptOpenJDK-1.8.0_282-b08
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4694/1/testReport/
Max. process+thread count 1464 (vs. ulimit of 30000)
modules C: hbase-shell U: hbase-shell
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4694/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 8s Docker mode activated.
-0 ⚠️ yetus 0m 2s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 2m 49s master passed
+1 💚 javadoc 0m 12s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 2m 44s the patch passed
+1 💚 javadoc 0m 10s the patch passed
_ Other Tests _
+1 💚 unit 7m 36s hbase-shell in the patch passed.
15m 41s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4694/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #4694
Optional Tests javac javadoc unit
uname Linux 4bf5d16230b4 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 39b496e
Default Java AdoptOpenJDK-11.0.10+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4694/1/testReport/
Max. process+thread count 1367 (vs. ulimit of 30000)
modules C: hbase-shell U: hbase-shell
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4694/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@2005hithlj
Copy link
Contributor Author

@carp84 sir, could you take a look? Thanks.

@Apache9
Copy link
Contributor

Apache9 commented Aug 15, 2022

List dead server or read server? Typo?

@2005hithlj 2005hithlj changed the title HBASE-27295 Correct the comment of list_readservers method in admin.rb HBASE-27295 Correct the comment of list_deadservers method in admin.rb Aug 15, 2022
@2005hithlj
Copy link
Contributor Author

List dead server or read server? Typo?
@Apache9 sir. Is list 'dead' server. I will correct PR/Issue title.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 41s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+1 💚 mvninstall 2m 22s master passed
+1 💚 spotless 0m 37s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 💚 mvninstall 2m 5s the patch passed
+1 💚 rubocop 0m 13s There were no new rubocop issues.
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 spotless 0m 35s patch has no errors when running spotless:check.
_ Other Tests _
+1 💚 asflicense 0m 9s The patch does not generate ASF License warnings.
7m 59s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4694/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #4694
Optional Tests dupname asflicense javac spotless rubocop
uname Linux 063f3c0a2b94 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 9215066
Default Java AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count 57 (vs. ulimit of 30000)
modules C: hbase-shell U: hbase-shell
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4694/2/console
versions git=2.17.1 maven=3.6.3 rubocop=0.80.0
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 41s Docker mode activated.
-0 ⚠️ yetus 0m 2s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 2m 46s master passed
+1 💚 javadoc 0m 10s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 2m 33s the patch passed
+1 💚 javadoc 0m 8s the patch passed
_ Other Tests _
+1 💚 unit 7m 32s hbase-shell in the patch passed.
14m 52s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4694/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #4694
Optional Tests javac javadoc unit
uname Linux 62fbd827f2b5 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 9215066
Default Java AdoptOpenJDK-11.0.10+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4694/2/testReport/
Max. process+thread count 1509 (vs. ulimit of 30000)
modules C: hbase-shell U: hbase-shell
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4694/2/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 19s Docker mode activated.
-0 ⚠️ yetus 0m 2s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 2m 59s master passed
+1 💚 javadoc 0m 10s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 2m 57s the patch passed
+1 💚 javadoc 0m 9s the patch passed
_ Other Tests _
+1 💚 unit 9m 58s hbase-shell in the patch passed.
18m 29s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4694/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #4694
Optional Tests javac javadoc unit
uname Linux eb4b7ecb78a3 5.4.0-122-generic #138-Ubuntu SMP Wed Jun 22 15:00:31 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 9215066
Default Java AdoptOpenJDK-1.8.0_282-b08
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4694/2/testReport/
Max. process+thread count 1365 (vs. ulimit of 30000)
modules C: hbase-shell U: hbase-shell
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4694/2/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

taklwu
taklwu approved these changes Aug 17, 2022
View reviewed changes
Copy link
Contributor

@taklwu taklwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@taklwu taklwu merged commit 74fd5b2 into apache:master Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Apache9 Apache9 Apache9 approved these changes

@taklwu taklwu taklwu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@2005hithlj @Apache-HBase @Apache9 @taklwu