HBASE-27269 The implementation of TestReplicationStatus.waitOnMetricsReport is incorrect #4678

2005hithlj · 2022-08-04T06:30:30Z

https://issues.apache.org/jira/browse/HBASE-27269

…Report is incorrect

Apache-HBase · 2022-08-04T07:21:44Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 33s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	3m 45s	master passed
+1 💚	compile	3m 12s	master passed
+1 💚	checkstyle	0m 46s	master passed
+1 💚	spotless	1m 7s	branch has no errors when running spotless:check.
+1 💚	spotbugs	1m 53s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 14s	the patch passed
+1 💚	compile	3m 11s	the patch passed
+1 💚	javac	3m 11s	the patch passed
+1 💚	checkstyle	0m 48s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	16m 52s	Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚	spotless	0m 57s	patch has no errors when running spotless:check.
+1 💚	spotbugs	2m 2s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 13s	The patch does not generate ASF License warnings.
		46m 24s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4678/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4678
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux 0369034cd410 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `d734acc`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count	64 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4678/1/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache9 · 2022-08-04T07:55:44Z

hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationStatus.java

@@ -139,6 +139,7 @@ private List<ReplicationLoadSource> waitOnMetricsReport(int greaterThan, ServerN
      metrics.getLiveServerMetrics().get(serverName).getReplicationLoadSourceList();
    while (list.size() <= greaterThan) {
      Threads.sleep(1000);
+      list = metrics.getLiveServerMetrics().get(serverName).getReplicationLoadSourceList();


This is still incorrect...

We need to call hbaseAdmin.getClusterMetrics every time when checking...

And here we'd better use the waitFor method to limit the max wait time?

Thanks for the review. @Apache9
Sorry, I made an obvious mistake.

…Report is incorrect

Apache-HBase · 2022-08-04T10:09:31Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 41s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 6s	master passed
+1 💚	compile	0m 43s	master passed
+1 💚	shadedjars	4m 7s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 26s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 43s	the patch passed
+1 💚	compile	0m 45s	the patch passed
+1 💚	javac	0m 45s	the patch passed
+1 💚	shadedjars	4m 3s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 26s	the patch passed
		_ Other Tests _
+1 💚	unit	194m 37s	hbase-server in the patch passed.
		214m 10s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4678/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4678
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux b4406fe5c126 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `d734acc`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4678/1/testReport/
Max. process+thread count	2676 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4678/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-08-04T10:56:17Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 21s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 37s	master passed
+1 💚	compile	0m 51s	master passed
+1 💚	shadedjars	5m 22s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 37s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 20s	the patch passed
+1 💚	compile	0m 47s	the patch passed
+1 💚	javac	0m 47s	the patch passed
+1 💚	shadedjars	5m 4s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 29s	the patch passed
		_ Other Tests _
+1 💚	unit	237m 23s	hbase-server in the patch passed.
		260m 46s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4678/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4678
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 606fd0c6ba69 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `d734acc`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4678/1/testReport/
Max. process+thread count	2523 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4678/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-08-04T11:45:36Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 45s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	3m 44s	master passed
+1 💚	compile	3m 45s	master passed
+1 💚	checkstyle	0m 46s	master passed
+1 💚	spotless	1m 3s	branch has no errors when running spotless:check.
+1 💚	spotbugs	2m 3s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 15s	the patch passed
+1 💚	compile	3m 22s	the patch passed
+1 💚	javac	3m 22s	the patch passed
+1 💚	checkstyle	0m 46s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	16m 6s	Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚	spotless	0m 59s	patch has no errors when running spotless:check.
+1 💚	spotbugs	2m 7s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 17s	The patch does not generate ASF License warnings.
		46m 58s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4678/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4678
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux 7a390474386a 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `d734acc`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count	64 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4678/2/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-08-04T14:34:25Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 39s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 49s	master passed
+1 💚	compile	0m 43s	master passed
+1 💚	shadedjars	4m 8s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 25s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 35s	the patch passed
+1 💚	compile	0m 44s	the patch passed
+1 💚	javac	0m 44s	the patch passed
+1 💚	shadedjars	4m 4s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 24s	the patch passed
		_ Other Tests _
-1 ❌	unit	197m 40s	hbase-server in the patch failed.
		215m 51s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4678/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4678
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux b7738eae6933 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `d734acc`
Default Java	AdoptOpenJDK-11.0.10+9
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4678/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4678/2/testReport/
Max. process+thread count	2680 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4678/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-08-04T14:39:56Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 40s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 18s	master passed
+1 💚	compile	0m 34s	master passed
+1 💚	shadedjars	4m 1s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 22s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 8s	the patch passed
+1 💚	compile	0m 34s	the patch passed
+1 💚	javac	0m 34s	the patch passed
+1 💚	shadedjars	3m 58s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 20s	the patch passed
		_ Other Tests _
+1 💚	unit	205m 15s	hbase-server in the patch passed.
		221m 20s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4678/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4678
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux ff612637cf12 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `d734acc`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4678/2/testReport/
Max. process+thread count	2645 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4678/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

…Report is incorrect (#4678) Signed-off-by: Duo Zhang <[email protected]> (cherry picked from commit 2dc2608)

…Report is incorrect (apache#4678) Signed-off-by: Duo Zhang <[email protected]> (cherry picked from commit 2dc2608) (cherry picked from commit 1183f06) Change-Id: Ic6898a0b9cfc6ef9da75c066687a8ac09ea8d58e

HBASE-27269 The implementation of TestReplicationStatus.waitOnMetrics…

a8604cd

…Report is incorrect

Apache9 reviewed Aug 4, 2022

View reviewed changes

HBASE-27269 The implementation of TestReplicationStatus.waitOnMetrics…

5a468c5

…Report is incorrect

Apache9 approved these changes Aug 4, 2022

View reviewed changes

Apache9 merged commit 2dc2608 into apache:master Aug 4, 2022

Apache9 pushed a commit that referenced this pull request Aug 4, 2022

HBASE-27269 The implementation of TestReplicationStatus.waitOnMetrics…

1183f06

…Report is incorrect (#4678) Signed-off-by: Duo Zhang <[email protected]> (cherry picked from commit 2dc2608)

Apache9 pushed a commit that referenced this pull request Aug 4, 2022

HBASE-27269 The implementation of TestReplicationStatus.waitOnMetrics…

a7f8dde

…Report is incorrect (#4678) Signed-off-by: Duo Zhang <[email protected]> (cherry picked from commit 2dc2608)

Apache9 pushed a commit that referenced this pull request Aug 4, 2022

HBASE-27269 The implementation of TestReplicationStatus.waitOnMetrics…

c5b22d9

…Report is incorrect (#4678) Signed-off-by: Duo Zhang <[email protected]> (cherry picked from commit 2dc2608)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-27269 The implementation of TestReplicationStatus.waitOnMetricsReport is incorrect #4678

HBASE-27269 The implementation of TestReplicationStatus.waitOnMetricsReport is incorrect #4678

2005hithlj commented Aug 4, 2022

Apache-HBase commented Aug 4, 2022

Apache9 Aug 4, 2022

2005hithlj Aug 4, 2022

Apache-HBase commented Aug 4, 2022

Apache-HBase commented Aug 4, 2022

Apache-HBase commented Aug 4, 2022

Apache-HBase commented Aug 4, 2022

Apache-HBase commented Aug 4, 2022

HBASE-27269 The implementation of TestReplicationStatus.waitOnMetricsReport is incorrect #4678

HBASE-27269 The implementation of TestReplicationStatus.waitOnMetricsReport is incorrect #4678

Conversation

2005hithlj commented Aug 4, 2022

Apache-HBase commented Aug 4, 2022

Apache9 Aug 4, 2022

Choose a reason for hiding this comment

2005hithlj Aug 4, 2022

Choose a reason for hiding this comment

Apache-HBase commented Aug 4, 2022

Apache-HBase commented Aug 4, 2022

Apache-HBase commented Aug 4, 2022

Apache-HBase commented Aug 4, 2022

Apache-HBase commented Aug 4, 2022