-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HBASE-27212 Implement a new table based replication queue storage and… #4672
HBASE-27212 Implement a new table based replication queue storage and… #4672
Conversation
Finally I could pass compilation. In this PR I tried to make claimQueue basically work so at least the failover UTs without replication can pass, and I also we could implement some low level UTs for claimQueue. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
OK good, at least we could finish the UT run. Let me check the failed UTs. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
TestRaceBetweenSCPAndTRSP also failed in other pre commit result so should not be related. TestAsyncReplicationAdminApi should be related. It is flaky in the recent pre commit build. Let me take a look. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
Tried TestAsyncReplicationAdminApi several times locally, no failure... And it is not failing in the newest pre commit result. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
This is a great beginning.
@@ -133,6 +133,7 @@ protected void updateLastPushedSequenceIdForSerialPeer(MasterProcedureEnv env) | |||
// removed from peer config | |||
for (String encodedRegionName : ReplicationBarrierFamilyFormat | |||
.getTableEncodedRegionNamesForSerialReplication(conn, tn)) { | |||
LOG.info("=============" + tn + ", " + encodedRegionName); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this log for debugging?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yes, let me remove this...
… make the minimum replication system work (#4672) Signed-off-by: Xin Sun <[email protected]>
… make the minimum replication system work (#4672) Signed-off-by: Xin Sun <[email protected]>
… make the minimum replication system work (#4672) Signed-off-by: Xin Sun <[email protected]>
… make the minimum replication system work (#4672) Signed-off-by: Xin Sun <[email protected]>
… make the minimum replication system work (#4672) Signed-off-by: Xin Sun <[email protected]>
… make the minimum replication system work (#4672) Signed-off-by: Xin Sun <[email protected]>
… make the minimum replication system work (#4672) Signed-off-by: Xin Sun <[email protected]>
… make the minimum replication system work (#4672) Signed-off-by: Xin Sun <[email protected]>
… make the minimum replication system work (#4672) Signed-off-by: Xin Sun <[email protected]>
… make the minimum replication system work (#4672) Signed-off-by: Xin Sun <[email protected]>
… make the minimum replication system work (#4672) Signed-off-by: Xin Sun <[email protected]>
… make the minimum replication system work (#4672) Signed-off-by: Xin Sun <[email protected]>
… make the minimum replication system work (#4672) Signed-off-by: Xin Sun <[email protected]>
… make the minimum replication system work (#4672) Signed-off-by: Xin Sun <[email protected]>
… make the minimum replication system work (#4672) Signed-off-by: Xin Sun <[email protected]>
… make the minimum replication system work (#4672) Signed-off-by: Xin Sun <[email protected]>
… make the minimum replication system work (#4672) Signed-off-by: Xin Sun <[email protected]>
… make the minimum replication system work (#4672) Signed-off-by: Xin Sun <[email protected]>
… make the minimum replication system work (#4672) Signed-off-by: Xin Sun <[email protected]>
… make the minimum replication system work (#4672) Signed-off-by: Xin Sun <[email protected]>
… make the minimum replication system work (#4672) Signed-off-by: Xin Sun <[email protected]>
… make the minimum replication system work (#4672) Signed-off-by: Xin Sun <[email protected]>
… make the minimum replication system work (#4672) Signed-off-by: Xin Sun <[email protected]>
… make the minimum replication system work (#4672) Signed-off-by: Xin Sun <[email protected]>
… make the minimum replication system work (#4672) Signed-off-by: Xin Sun <[email protected]>
… make the minimum replication system work (#4672) Signed-off-by: Xin Sun <[email protected]>
… make the minimum replication system work (#4672) Signed-off-by: Xin Sun <[email protected]>
… make the minimum replication system work (#4672) Signed-off-by: Xin Sun <[email protected]>
… make the minimum replication system work (#4672) Signed-off-by: Xin Sun <[email protected]>
… make the minimum replication system work (#4672) Signed-off-by: Xin Sun <[email protected]>
… make the minimum replication system work