HBASE-27203 Clean up error-prone findings in hbase-client #4644

apurtell · 2022-07-23T01:37:32Z

No description provided.

Apache-HBase · 2022-07-23T01:57:20Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 13s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 28s	master passed
+1 💚	compile	0m 18s	master passed
+1 💚	shadedjars	3m 45s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 17s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 19s	the patch passed
+1 💚	compile	0m 18s	the patch passed
+1 💚	javac	0m 18s	the patch passed
+1 💚	shadedjars	3m 43s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 16s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 13s	hbase-client in the patch passed.
		17m 8s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4644/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4644
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 08671c6059b5 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `31fc97e`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4644/1/testReport/
Max. process+thread count	159 (vs. ulimit of 30000)
modules	C: hbase-client U: hbase-client
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4644/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-07-23T01:58:19Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 40s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 59s	master passed
+1 💚	compile	0m 17s	master passed
+1 💚	shadedjars	4m 5s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 20s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 33s	the patch passed
+1 💚	compile	0m 17s	the patch passed
+1 💚	javac	0m 17s	the patch passed
+1 💚	shadedjars	3m 54s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 14s	hbase-client generated 0 new + 44 unchanged - 11 fixed = 44 total (was 55)
		_ Other Tests _
+1 💚	unit	1m 21s	hbase-client in the patch passed.
		17m 56s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4644/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4644
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 10f5b0b4bad4 5.4.0-1043-aws #45~18.04.1-Ubuntu SMP Fri Apr 9 23:32:25 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `31fc97e`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4644/1/testReport/
Max. process+thread count	189 (vs. ulimit of 30000)
modules	C: hbase-client U: hbase-client
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4644/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-07-23T02:07:45Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 36s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 1s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	2m 23s	master passed
+1 💚	compile	0m 35s	master passed
+1 💚	checkstyle	0m 14s	master passed
+1 💚	spotless	0m 42s	branch has no errors when running spotless:check.
+1 💚	spotbugs	0m 36s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 8s	the patch passed
+1 💚	compile	0m 33s	the patch passed
-0 ⚠️	javac	0m 33s	hbase-client generated 29 new + 5 unchanged - 118 fixed = 34 total (was 123)
+1 💚	checkstyle	0m 12s	hbase-client: The patch generated 0 new + 128 unchanged - 75 fixed = 128 total (was 203)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	11m 30s	Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚	spotless	0m 40s	patch has no errors when running spotless:check.
+1 💚	spotbugs	0m 40s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 8s	The patch does not generate ASF License warnings.
		27m 24s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4644/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4644
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux ffd6408f3fe7 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `31fc97e`
Default Java	AdoptOpenJDK-1.8.0_282-b08
javac	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4644/1/artifact/yetus-general-check/output/diff-compile-javac-hbase-client.txt
Max. process+thread count	64 (vs. ulimit of 30000)
modules	C: hbase-client U: hbase-client
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4644/1/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache9

Overall LGTM. Left some comments.

Thanks @apurtell for the hard work!

hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java

hbase-client/src/main/java/org/apache/hadoop/hbase/client/Append.java

hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncAdmin.java

...java/org/apache/hadoop/hbase/security/provider/AbstractSaslClientAuthenticationProvider.java

Apache9 · 2022-07-23T12:21:06Z

hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestScan.java

@@ -192,8 +187,7 @@ public void testSetStartRowAndSetStopRow() {
      scan.withStartRow(new byte[HConstants.MAX_ROW_LENGTH + 1]);
      fail("should've thrown exception");
    } catch (IllegalArgumentException iae) {
-    } catch (Exception e) {
-      fail("expected IllegalArgumentException to be thrown");
+      // Expected


I think we could file another issue to change these tests to use assertThrows. Anyway, the current modifications make the code better, can open a follow on issue for changing to assertThrows.

Apache9 · 2022-07-23T12:22:25Z

hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestSimpleRequestController.java

@@ -115,6 +116,7 @@ public long heapSize() {
  }

  @Test
+  @SuppressWarnings("ArrayAsKeyOfSetOrMap")


Since this is a test, let's just use TreeMap with Bytes.BYTES_COMPARATOR instead of HashMap to remove the warning?

I thought I went back and undid my changes related to ArrayAsKeyOfSetOrMap while revising the patch but see that I left this one in place.

Apache9 · 2022-07-23T12:22:41Z

hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestSimpleRequestController.java

@@ -277,6 +279,7 @@ public void testSubmittedSizeChecker() {
  }

  @Test
+  @SuppressWarnings("ArrayAsKeyOfSetOrMap")


hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestSimpleRequestController.java

apurtell · 2022-07-25T23:54:30Z

Rebase. Address review feedback. More javadoc cleanups.

Apache-HBase · 2022-07-26T00:16:26Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 40s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 21s	master passed
+1 💚	compile	0m 15s	master passed
+1 💚	shadedjars	3m 54s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 15s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 9s	the patch passed
+1 💚	compile	0m 15s	the patch passed
+1 💚	javac	0m 15s	the patch passed
+1 💚	shadedjars	3m 56s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 13s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 7s	hbase-client in the patch passed.
		16m 1s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4644/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4644
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 2567c5da8765 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `e10c15d`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4644/2/testReport/
Max. process+thread count	161 (vs. ulimit of 30000)
modules	C: hbase-client U: hbase-client
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4644/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-07-26T00:17:31Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 49s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 31s	master passed
+1 💚	compile	0m 17s	master passed
+1 💚	shadedjars	3m 53s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 14s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 31s	the patch passed
+1 💚	compile	0m 18s	the patch passed
+1 💚	javac	0m 18s	the patch passed
+1 💚	shadedjars	3m 58s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 15s	hbase-client generated 0 new + 44 unchanged - 11 fixed = 44 total (was 55)
		_ Other Tests _
+1 💚	unit	1m 23s	hbase-client in the patch passed.
		17m 12s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4644/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4644
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 78536caeb06c 5.4.0-1043-aws #45~18.04.1-Ubuntu SMP Fri Apr 9 23:32:25 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `e10c15d`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4644/2/testReport/
Max. process+thread count	195 (vs. ulimit of 30000)
modules	C: hbase-client U: hbase-client
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4644/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-07-26T00:31:32Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 19s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 1s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	2m 46s	master passed
+1 💚	compile	0m 47s	master passed
+1 💚	checkstyle	0m 18s	master passed
+1 💚	spotless	0m 54s	branch has no errors when running spotless:check.
+1 💚	spotbugs	0m 49s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 47s	the patch passed
+1 💚	compile	0m 42s	the patch passed
-0 ⚠️	javac	0m 42s	hbase-client generated 31 new + 5 unchanged - 118 fixed = 36 total (was 123)
+1 💚	checkstyle	0m 16s	hbase-client: The patch generated 0 new + 128 unchanged - 75 fixed = 128 total (was 203)
+1 💚	whitespace	0m 1s	The patch has no whitespace issues.
+1 💚	hadoopcheck	13m 7s	Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚	spotless	0m 50s	patch has no errors when running spotless:check.
+1 💚	spotbugs	0m 47s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 10s	The patch does not generate ASF License warnings.
		31m 14s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4644/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4644
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux 7c74a989c870 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `e10c15d`
Default Java	AdoptOpenJDK-1.8.0_282-b08
javac	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4644/2/artifact/yetus-general-check/output/diff-compile-javac-hbase-client.txt
Max. process+thread count	64 (vs. ulimit of 30000)
modules	C: hbase-client U: hbase-client
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4644/2/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache9

Only a minor nits, can change or not, not a big deal.

+1, thanks @apurtell for the hard work!

Apache9 · 2022-07-26T04:06:21Z

hbase-client/src/main/java/org/apache/hadoop/hbase/security/SaslUtil.java

@@ -62,7 +65,8 @@ public boolean matches(String stringQop) {

  /** Splitting fully qualified Kerberos name into parts */
  public static String[] splitKerberosName(String fullName) {
-    return fullName.split("[/@]");
+    List<String> result = Splitter.onPattern("[/@]").splitToList(fullName);


return Splitter.onPattern("[/@]").splitToStream(fullName).toArray(String[]::new);

You indicated a preference for using a stream to do toArray on the hbase-backup review, will apply the pattern to all such places, no problem

apurtell requested review from Apache9 and virajjasani July 23, 2022 01:37

Apache9 reviewed Jul 23, 2022

View reviewed changes

apurtell force-pushed the HBASE-27203 branch from d2454fb to 0c22a8c Compare July 25, 2022 23:54

apurtell requested a review from Apache9 July 25, 2022 23:54

Apache9 approved these changes Jul 26, 2022

View reviewed changes

apurtell added 3 commits July 26, 2022 14:47

HBASE-27203 Clean up error-prone findings in hbase-client

613323a

Address review feedback and additional cleanups

21ee02f

More review feedback

a26e02d

apurtell force-pushed the HBASE-27203 branch from 0c22a8c to a26e02d Compare July 26, 2022 22:02

apurtell merged commit 9573466 into apache:master Jul 26, 2022

apurtell deleted the HBASE-27203 branch July 26, 2022 22:08

Apache9 mentioned this pull request Jul 27, 2022

HBASE-26666 Add native TLS encryption support to RPC server/client #4125

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-27203 Clean up error-prone findings in hbase-client #4644

HBASE-27203 Clean up error-prone findings in hbase-client #4644

apurtell commented Jul 23, 2022

Apache-HBase commented Jul 23, 2022

Apache-HBase commented Jul 23, 2022

Apache-HBase commented Jul 23, 2022

Apache9 left a comment

Apache9 Jul 23, 2022

Apache9 Jul 23, 2022

apurtell Jul 25, 2022

Apache9 Jul 23, 2022

apurtell commented Jul 25, 2022

Apache-HBase commented Jul 26, 2022

Apache-HBase commented Jul 26, 2022

Apache-HBase commented Jul 26, 2022

Apache9 left a comment

Apache9 Jul 26, 2022

apurtell Jul 26, 2022 •

edited

Loading

HBASE-27203 Clean up error-prone findings in hbase-client #4644

HBASE-27203 Clean up error-prone findings in hbase-client #4644

Conversation

apurtell commented Jul 23, 2022

Apache-HBase commented Jul 23, 2022

Apache-HBase commented Jul 23, 2022

Apache-HBase commented Jul 23, 2022

Apache9 left a comment

Choose a reason for hiding this comment

Apache9 Jul 23, 2022

Choose a reason for hiding this comment

Apache9 Jul 23, 2022

Choose a reason for hiding this comment

apurtell Jul 25, 2022

Choose a reason for hiding this comment

Apache9 Jul 23, 2022

Choose a reason for hiding this comment

apurtell commented Jul 25, 2022

Apache-HBase commented Jul 26, 2022

Apache-HBase commented Jul 26, 2022

Apache-HBase commented Jul 26, 2022

Apache9 left a comment

Choose a reason for hiding this comment

Apache9 Jul 26, 2022

Choose a reason for hiding this comment

apurtell Jul 26, 2022 • edited Loading

Choose a reason for hiding this comment

apurtell Jul 26, 2022 •

edited

Loading