HBASE-27157 Potential race condition in WorkerAssigner #4577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
Skimmed the code, I think we'd better just fold the suspend method into acquire, and also fold the wake method into release. I do not see the necessity to expose these methods to upper layer. |
|
Good idea. I'll fix this. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
Apache9
reviewed
Jun 27, 2022
| if (!event.isReady()) { | ||
| event.wake(scheduler); | ||
| event.wake(master.getMasterProcedureExecutor().getEnvironment().getProcedureScheduler()); | ||
| } | ||
| } | ||
|
|
||
| @Override | ||
| public void serverAdded(ServerName worker) { |
There was a problem hiding this comment.
Better to also add synchronized here?
There was a problem hiding this comment.
sorry, miss here. will fix it. Thanks for reminding.
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
Some unit tests failed. A little weird. Let me see why. |
|
💔 -1 overall
This message was automatically generated. |
Apache9
reviewed
Jun 28, 2022
| @@ -60,27 +59,23 @@ public synchronized Optional<ServerName> acquire() { | |||
| .findAny(); | |||
| worker.ifPresent(name -> currentWorkers.compute(name, (serverName, | |||
| availableWorker) -> availableWorker == null ? maxTasks - 1 : availableWorker - 1)); | |||
| event.suspend(); | |||
There was a problem hiding this comment.
Should only suspend the procedure when there is no worker available? And I think here we could make the return value as ServerName instead of Optional, and throw ProcedureSuspendedException directly if worker is not available.
There was a problem hiding this comment.
Ok. Let me try. Thanks Duo.
|
💔 -1 overall
This message was automatically generated. |
Apache9
approved these changes
Jul 6, 2022
Apache9
pushed a commit
that referenced
this pull request
Jul 6, 2022
Co-authored-by: huiruan <[email protected]> Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: Lijin Bin <[email protected]> (cherry picked from commit f76d855)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.