HBASE-22395 Document RC voting guidelines in ref guide #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
busbey
requested changes
Jun 11, 2019
| * CHANGES.md if any | ||
| * RELEASENOTES.md (release notes) if any | ||
| * Generated API compatibility report | ||
| ** For what should be compatible please refer the [versioning guideline](https://hbase.apache.org/book.html#hbase.versioning), especially for items with marked as high severity |
There was a problem hiding this comment.
this didn't render correctly as a link in the qabot build of the ref guide.
There was a problem hiding this comment.
fixed, thanks for calling out
| @@ -899,6 +910,15 @@ Usage: hbase-vote.sh -s | --source <url> [-k | --key <signature>] [-f | --keys-f | |||
| http://www.apache.org/dist/hbase/KEYS | |||
| -o | --output-dir '</path>' directory which has the stdout and stderr of each verification target | |||
| ---- | |||
| ** If you see any unit test failures, please call out the solo test result and whether it's part of flaky (nightly) tests dashboard. Link to the dashboard is e.g. https://builds.apache.org/view/H-L/view/HBase/job/HBase-Find-Flaky-Tests/job/<branch-name>/lastSuccessfulBuild/artifact/dashboard.html | |||
There was a problem hiding this comment.
this rendered as a link to an incorrect URL. Can you make it an example of a working link with branch-2.2?
There was a problem hiding this comment.
fixed, I changed to master branch with a note one should change the test branch accordingly such we don't have to change this ref guide often.
taklwu
force-pushed
the
HBASE-22395
branch
2 times, most recently
from
d5a2cb6 to
657b37f
Compare
|
🎊 +1 overall
This message was automatically generated. |
busbey
approved these changes
Jun 11, 2019
|
🎊 +1 overall
This message was automatically generated. |
|
I found an extra |
|
🎊 +1 overall
This message was automatically generated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.