Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HBASE-22234 Fix flaky TestHbck#testRecoverSplitAfterMetaUpdated #148

Merged
merged 1 commit into from
Apr 14, 2019
Merged

HBASE-22234 Fix flaky TestHbck#testRecoverSplitAfterMetaUpdated #148

merged 1 commit into from
Apr 14, 2019

Conversation

tianjy1990
Copy link
Contributor

fix flakey test which is easily failed due to unfinished assign region procedure .

@tianjy1990 tianjy1990 merged commit cb84b27 into apache:master Apr 14, 2019
@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
0 reexec 22 Docker mode activated.
_ Prechecks _
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 1 new or modified test files.
_ master Compile Tests _
+1 mvninstall 257 master passed
+1 compile 54 master passed
+1 checkstyle 69 master passed
+1 shadedjars 268 branch has no errors when building our shaded downstream artifacts.
+1 findbugs 181 master passed
+1 javadoc 33 master passed
_ Patch Compile Tests _
+1 mvninstall 243 the patch passed
+1 compile 57 the patch passed
+1 javac 57 the patch passed
+1 checkstyle 68 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 265 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 498 Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0.
+1 findbugs 208 the patch passed
+1 javadoc 33 the patch passed
_ Other Tests _
+1 unit 8200 hbase-server in the patch passed.
+1 asflicense 31 The patch does not generate ASF License warnings.
10557
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-148/1/artifact/out/Dockerfile
GITHUB PR #148
Optional Tests dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux dce521c820ad 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /testptch/patchprocess/precommit/personality/provided.sh
git revision master / 01c26c5
maven version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java 1.8.0_181
findbugs v3.1.11
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-148/1/testReport/
Max. process+thread count 5086 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-148/1/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@tianjy1990 tianjy1990 deleted the HBASE-22234 branch April 15, 2019 04:07
stoty pushed a commit to stoty/hbase that referenced this pull request Nov 26, 2024
@BecseiL @ndimiduk
CDPD-72946: HBASE-28065 Corrupt HFile data is mishandled in several c…
5cd2e89 
…ases (apache#148)

* when no block size is provided and there's not a preread headerBuf, treat the value with
  caution.
* verify HBase checksums before making use of the block header.
* inline verifyOnDiskSizeMatchesHeader to keep throw/return logic in the method body.
* separate validation of onDiskSizeWithHeader as input parameter from as read from block header
* simplify branching around fetching and populating onDiskSizeWithHeader.
* inline retrieving nextOnDiskBlockSize ; add basic validation.
* whenever a read is determined to be corrupt and fallback to HDFS checksum is necessary, also
  invalidate the cached value of headerBuf.
* build out a test suite covering various forms of block header corruption, for blocks in first
  and second positions.

Signed-off-by: Bryan Beaudreault <[email protected]>
Change-Id: Ia2eb0b3c5a686c8b46daa2add5f7171f31c54675
(cherry picked from commit 71224a6)

Co-authored-by: Nick Dimiduk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Apache9 Apache9 Apache9 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tianjy1990 @Apache-HBase @Apache9