-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HBASE-7003 Moved backup examples into hbase-examples #145
Conversation
🎊 +1 overall
This message was automatically generated. |
I thought one of the consensus points for getting the backup/restore stuff into master was that it would be isolated in the one module. Maybe I'm misremembering though? |
Wasn't aware of it. Should I remove the changes to the backup/restore stuff from this patch? |
Yes, it was important that the backup be totally contained in a module. In fact, now we have alternatives, backup should be moved out of core to something like hbase-operator-tools. Can bring it up on dev lists. That said, your patch here looks like good cleanup @HorizonNet . You are fixing formatting, line lengths, over-imports. Is that the nature of this patch no? If so, lets get it in. |
Core of the patch is to move everything into |
Could we have a patch that has your cleanup only? i.e. no move to hbase-examples? There is good stuff in here. Would be shame to throw away? Maybe a new issue? Kill this one? |
💔 -1 overall
This message was automatically generated. |
Closing this one and will open a new ticket. @saintstack Should I also close the corresponding ticket? |
No description provided.