HBASE-23896 Snapshot owner cannot delete snapshot when ACL is enabled… #1211

guangxuCheng · 2020-02-26T11:39:44Z

… and Kerberos is not enabled

Apache-HBase · 2020-02-26T13:51:03Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 33s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-0 ⚠️	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+1 💚	mvninstall	5m 33s	master passed
+1 💚	compile	0m 57s	master passed
+1 💚	checkstyle	1m 8s	master passed
+1 💚	shadedjars	4m 41s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 39s	master passed
+0 🆗	spotbugs	4m 23s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	4m 22s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 58s	the patch passed
+1 💚	compile	0m 59s	the patch passed
+1 💚	javac	0m 59s	the patch passed
+1 💚	checkstyle	1m 7s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedjars	4m 44s	patch has no errors when building our shaded downstream artifacts.
+1 💚	hadoopcheck	16m 4s	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 💚	javadoc	0m 38s	the patch passed
+1 💚	findbugs	4m 34s	the patch passed
		_ Other Tests _
+1 💚	unit	62m 40s	hbase-server in the patch passed.
+1 💚	asflicense	0m 37s	The patch does not generate ASF License warnings.
		120m 50s

Subsystem	Report/Notes
Docker	Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1211/1/artifact/out/Dockerfile
GITHUB PR	#1211
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 47bd97fe1f10 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1211/out/precommit/personality/provided.sh
git revision	master / `ecbed33`
Default Java	1.8.0_181
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1211/1/testReport/
Max. process+thread count	9387 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1211/1/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

wchevreuil

Can you provide some UTs, together with the actual steps to reproduce it? Am trying create a snapshot as a given user, but am able to delete the snapshot without any problems, with ACLs enabled but no authentication set.

guangxuCheng · 2020-03-16T03:48:58Z

hi @wchevreuil, Is the given user only the owner of the table and don't have the all global permissions?

Apache-HBase · 2020-03-16T14:20:34Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 26s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	6m 16s	master passed
+1 💚	checkstyle	1m 18s	master passed
-1 ❌	spotbugs	2m 14s	hbase-server in master has 1 extant spotbugs warnings.
		_ Patch Compile Tests _
+1 💚	mvninstall	5m 38s	the patch passed
-0 ⚠️	checkstyle	1m 16s	hbase-server: The patch generated 1 new + 15 unchanged - 0 fixed = 16 total (was 15)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	19m 38s	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 💚	spotbugs	2m 21s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 13s	The patch does not generate ASF License warnings.
		47m 57s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1211/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1211
Optional Tests	dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname	Linux 8489bc2d6e28 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `f66cbe1`
spotbugs	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1211/2/artifact/yetus-general-check/output/branch-spotbugs-hbase-server-warnings.html
checkstyle	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1211/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count	83 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1211/2/console
versions	git=2.17.1 maven=2018-06-17T18:33:14Z) spotbugs=3.1.12
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-03-16T15:07:48Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 31s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	5m 32s	master passed
+1 💚	compile	0m 57s	master passed
+1 💚	shadedjars	4m 48s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 40s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	5m 12s	the patch passed
+1 💚	compile	1m 0s	the patch passed
+1 💚	javac	1m 0s	the patch passed
+1 💚	shadedjars	4m 52s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 36s	the patch passed
		_ Other Tests _
-1 ❌	unit	60m 24s	hbase-server in the patch failed.
		86m 22s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1211/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#1211
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux fd409c6b5b79 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `f66cbe1`
Default Java	1.8.0_232
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1211/2/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1211/2/testReport/
Max. process+thread count	5697 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1211/2/console
versions	git=2.17.1 maven=2018-06-17T18:33:14Z)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-03-16T15:54:55Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	2m 37s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	7m 40s	master passed
+1 💚	compile	1m 12s	master passed
+1 💚	shadedjars	5m 37s	branch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 42s	hbase-server in master failed.
		_ Patch Compile Tests _
+1 💚	mvninstall	7m 5s	the patch passed
+1 💚	compile	1m 12s	the patch passed
+1 💚	javac	1m 12s	the patch passed
+1 💚	shadedjars	5m 30s	patch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 40s	hbase-server in the patch failed.
		_ Other Tests _
-0 ⚠️	unit	96m 17s	hbase-server in the patch failed.
		130m 19s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1211/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#1211
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 8f5eba3593f0 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `f66cbe1`
Default Java	2020-01-14
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1211/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1211/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1211/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1211/2/testReport/
Max. process+thread count	4509 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1211/2/console
versions	git=2.17.1 maven=2018-06-17T18:33:14Z)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-03-17T11:52:55Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	4m 18s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	5m 57s	master passed
+1 💚	checkstyle	1m 7s	master passed
-1 ❌	spotbugs	2m 7s	hbase-server in master has 1 extant spotbugs warnings.
		_ Patch Compile Tests _
+1 💚	mvninstall	5m 21s	the patch passed
-0 ⚠️	checkstyle	1m 7s	hbase-server: The patch generated 1 new + 15 unchanged - 0 fixed = 16 total (was 15)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	17m 55s	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 💚	spotbugs	2m 13s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 14s	The patch does not generate ASF License warnings.
		47m 43s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1211/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1211
Optional Tests	dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname	Linux 0b58c261c85c 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `60de4c2`
spotbugs	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1211/3/artifact/yetus-general-check/output/branch-spotbugs-hbase-server-warnings.html
checkstyle	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1211/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count	93 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1211/3/console
versions	git=2.17.1 maven=2018-06-17T18:33:14Z) spotbugs=3.1.12
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-03-17T14:06:09Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	9m 36s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	7m 41s	master passed
+1 💚	compile	1m 17s	master passed
-1 ❌	shadedjars	0m 10s	branch has 7 errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 44s	hbase-server in master failed.
		_ Patch Compile Tests _
+1 💚	mvninstall	7m 19s	the patch passed
+1 💚	compile	1m 19s	the patch passed
+1 💚	javac	1m 19s	the patch passed
-1 ❌	shadedjars	0m 9s	patch has 7 errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 45s	hbase-server in the patch failed.
		_ Other Tests _
-0 ⚠️	unit	147m 10s	hbase-server in the patch failed.
		178m 32s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1211/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#1211
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 0f7abcc24c59 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `60de4c2`
Default Java	2020-01-14
shadedjars	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1211/3/artifact/yetus-jdk11-hadoop3-check/output/branch-shadedjars.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1211/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
shadedjars	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1211/3/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1211/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1211/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1211/3/testReport/
Max. process+thread count	4303 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1211/3/console
versions	git=2.17.1 maven=2018-06-17T18:33:14Z)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-03-17T14:13:19Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	8m 27s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	7m 11s	master passed
+1 💚	compile	1m 6s	master passed
+1 💚	shadedjars	5m 38s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 41s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	6m 2s	the patch passed
+1 💚	compile	1m 5s	the patch passed
+1 💚	javac	1m 5s	the patch passed
+1 💚	shadedjars	7m 12s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 1s	the patch passed
		_ Other Tests _
-1 ❌	unit	146m 56s	hbase-server in the patch failed.
		187m 17s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1211/3/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#1211
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux db8c10d4d71a 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `60de4c2`
Default Java	1.8.0_232
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1211/3/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1211/3/testReport/
Max. process+thread count	3935 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1211/3/console
versions	git=2.17.1 maven=2018-06-17T18:33:14Z)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-03-17T14:57:09Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 30s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	5m 45s	master passed
+1 💚	checkstyle	1m 11s	master passed
-1 ❌	spotbugs	2m 7s	hbase-server in master has 1 extant spotbugs warnings.
		_ Patch Compile Tests _
+1 💚	mvninstall	5m 12s	the patch passed
+1 💚	checkstyle	1m 6s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	16m 18s	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 💚	spotbugs	2m 14s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 15s	The patch does not generate ASF License warnings.
		41m 33s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1211/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1211
Optional Tests	dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname	Linux e82b4b506938 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `60de4c2`
spotbugs	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1211/4/artifact/yetus-general-check/output/branch-spotbugs-hbase-server-warnings.html
Max. process+thread count	93 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1211/4/console
versions	git=2.17.1 maven=2018-06-17T18:33:14Z) spotbugs=3.1.12
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-03-17T17:04:12Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 25s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	7m 30s	master passed
+1 💚	compile	1m 20s	master passed
-1 ❌	shadedjars	0m 10s	branch has 7 errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 45s	hbase-server in master failed.
		_ Patch Compile Tests _
+1 💚	mvninstall	7m 7s	the patch passed
+1 💚	compile	1m 15s	the patch passed
+1 💚	javac	1m 15s	the patch passed
-1 ❌	shadedjars	0m 9s	patch has 7 errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 41s	hbase-server in the patch failed.
		_ Other Tests _
-0 ⚠️	unit	147m 20s	hbase-server in the patch failed.
		168m 36s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1211/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#1211
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux d07175838cb4 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `60de4c2`
Default Java	2020-01-14
shadedjars	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1211/4/artifact/yetus-jdk11-hadoop3-check/output/branch-shadedjars.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1211/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
shadedjars	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1211/4/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1211/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1211/4/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1211/4/testReport/
Max. process+thread count	4151 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1211/4/console
versions	git=2.17.1 maven=2018-06-17T18:33:14Z)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-03-17T17:13:06Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 26s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	6m 26s	master passed
+1 💚	compile	1m 2s	master passed
+1 💚	shadedjars	5m 41s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 37s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	5m 56s	the patch passed
+1 💚	compile	1m 16s	the patch passed
+1 💚	javac	1m 16s	the patch passed
+1 💚	shadedjars	7m 58s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 59s	the patch passed
		_ Other Tests _
-1 ❌	unit	145m 23s	hbase-server in the patch failed.
		177m 33s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1211/4/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#1211
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 8de3beb3a916 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `60de4c2`
Default Java	1.8.0_232
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1211/4/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1211/4/testReport/
Max. process+thread count	3777 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1211/4/console
versions	git=2.17.1 maven=2018-06-17T18:33:14Z)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

… and Kerberos is not enabled

Apache-HBase · 2020-04-01T08:09:13Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 7s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	6m 1s	master passed
+1 💚	checkstyle	1m 16s	master passed
+1 💚	spotbugs	2m 14s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	5m 32s	the patch passed
+1 💚	checkstyle	1m 14s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	11m 26s	Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2.
+1 💚	spotbugs	2m 20s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 12s	The patch does not generate ASF License warnings.
		38m 32s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1211/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1211
Optional Tests	dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname	Linux bef4181e6338 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `52c1013`
Max. process+thread count	83 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1211/5/console
versions	git=2.17.1 maven=2018-06-17T18:33:14Z) spotbugs=3.1.12
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

guangxuCheng · 2020-04-01T08:34:37Z

All green. @wchevreuil Any other concerns?

Apache-HBase · 2020-04-01T09:00:41Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 32s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	5m 35s	master passed
+1 💚	compile	0m 58s	master passed
+1 💚	shadedjars	4m 46s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 37s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	5m 9s	the patch passed
+1 💚	compile	0m 59s	the patch passed
+1 💚	javac	0m 59s	the patch passed
+1 💚	shadedjars	4m 43s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 36s	the patch passed
		_ Other Tests _
+1 💚	unit	63m 40s	hbase-server in the patch passed.
		89m 57s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1211/5/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#1211
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 073e7a51b278 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `52c1013`
Default Java	1.8.0_232
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1211/5/testReport/
Max. process+thread count	5973 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1211/5/console
versions	git=2.17.1 maven=2018-06-17T18:33:14Z)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-04-01T09:11:33Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 42s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	7m 35s	master passed
+1 💚	compile	1m 12s	master passed
+1 💚	shadedjars	5m 57s	branch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 42s	hbase-server in master failed.
		_ Patch Compile Tests _
+1 💚	mvninstall	5m 55s	the patch passed
+1 💚	compile	1m 19s	the patch passed
+1 💚	javac	1m 19s	the patch passed
+1 💚	shadedjars	6m 51s	patch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 40s	hbase-server in the patch failed.
		_ Other Tests _
-0 ⚠️	unit	67m 35s	hbase-server in the patch failed.
		100m 47s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1211/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#1211
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 87e46b794c1b 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `52c1013`
Default Java	2020-01-14
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1211/5/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1211/5/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1211/5/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1211/5/testReport/
Max. process+thread count	5816 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1211/5/console
versions	git=2.17.1 maven=2018-06-17T18:33:14Z)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

binlijin

+1

… and Kerberos is not enabled (#1211) Signed-off-by: binlijin <[email protected]>

… and Kerberos is not enabled (apache#1211) Signed-off-by: binlijin <[email protected]>

… and Kerberos is not enabled (apache#1211) Signed-off-by: binlijin <[email protected]> (cherry picked from commit 5f7e55b) Change-Id: Ib229a5878ee67d7c587d10942ed2359026a9a6c1

… enabled and Kerberos is not enabled (apache#1211)" This reverts commit a10b081. Reason for revert: <INSERT REASONING HERE> Change-Id: If08ce7a2ed4cb91fd1757d90cf24691370d7e953

… and Kerberos is not enabled (apache#1211) Includes addendum Signed-off-by: binlijin <[email protected]> (cherry picked from commit 5f7e55b) (cherry picked from commit 333454d) Change-Id: I0b0b2115516f16955356a3f1682f8216eeb3d0b8

wchevreuil reviewed Mar 9, 2020

View reviewed changes

guangxuCheng force-pushed the HBASE-23896 branch from 60f852b to 5b7941c Compare March 17, 2020 02:42

HBASE-23896 Snapshot owner cannot delete snapshot when ACL is enabled…

5b97e53

… and Kerberos is not enabled

guangxuCheng force-pushed the HBASE-23896 branch from 8115a35 to 5b97e53 Compare April 1, 2020 07:28

binlijin approved these changes Apr 8, 2020

View reviewed changes

guangxuCheng merged commit bcacc4c into apache:master Apr 20, 2020

guangxuCheng added a commit that referenced this pull request Apr 20, 2020

HBASE-23896 Snapshot owner cannot delete snapshot when ACL is enabled…

5f7e55b

… and Kerberos is not enabled (#1211) Signed-off-by: binlijin <[email protected]>

guangxuCheng added a commit that referenced this pull request Apr 20, 2020

HBASE-23896 Snapshot owner cannot delete snapshot when ACL is enabled…

2762ddc

… and Kerberos is not enabled (#1211) Signed-off-by: binlijin <[email protected]>

guangxuCheng added a commit that referenced this pull request Apr 20, 2020

HBASE-23896 Snapshot owner cannot delete snapshot when ACL is enabled…

2335803

… and Kerberos is not enabled (#1211) Signed-off-by: binlijin <[email protected]>

infraio pushed a commit to infraio/hbase that referenced this pull request Aug 17, 2020

HBASE-23896 Snapshot owner cannot delete snapshot when ACL is enabled…

28784c1

… and Kerberos is not enabled (apache#1211) Signed-off-by: binlijin <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-23896 Snapshot owner cannot delete snapshot when ACL is enabled… #1211

HBASE-23896 Snapshot owner cannot delete snapshot when ACL is enabled… #1211

guangxuCheng commented Feb 26, 2020

Apache-HBase commented Feb 26, 2020

wchevreuil left a comment

guangxuCheng commented Mar 16, 2020

Apache-HBase commented Mar 16, 2020

Apache-HBase commented Mar 16, 2020

Apache-HBase commented Mar 16, 2020

Apache-HBase commented Mar 17, 2020

Apache-HBase commented Mar 17, 2020

Apache-HBase commented Mar 17, 2020

Apache-HBase commented Mar 17, 2020

Apache-HBase commented Mar 17, 2020

Apache-HBase commented Mar 17, 2020

Apache-HBase commented Apr 1, 2020

guangxuCheng commented Apr 1, 2020

Apache-HBase commented Apr 1, 2020

Apache-HBase commented Apr 1, 2020

binlijin left a comment

HBASE-23896 Snapshot owner cannot delete snapshot when ACL is enabled… #1211

HBASE-23896 Snapshot owner cannot delete snapshot when ACL is enabled… #1211

Conversation

guangxuCheng commented Feb 26, 2020

Apache-HBase commented Feb 26, 2020

wchevreuil left a comment

Choose a reason for hiding this comment

guangxuCheng commented Mar 16, 2020

Apache-HBase commented Mar 16, 2020

Apache-HBase commented Mar 16, 2020

Apache-HBase commented Mar 16, 2020

Apache-HBase commented Mar 17, 2020

Apache-HBase commented Mar 17, 2020

Apache-HBase commented Mar 17, 2020

Apache-HBase commented Mar 17, 2020

Apache-HBase commented Mar 17, 2020

Apache-HBase commented Mar 17, 2020

Apache-HBase commented Apr 1, 2020

guangxuCheng commented Apr 1, 2020

Apache-HBase commented Apr 1, 2020

Apache-HBase commented Apr 1, 2020

binlijin left a comment

Choose a reason for hiding this comment