Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HBASE-23696 Stop WALProcedureStore after migration finishes #1050

Closed
wants to merge 1 commit into from

Conversation

saintstack
Copy link
Contributor

No description provided.

Copy link
Contributor

@wchevreuil wchevreuil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a question regarding stopping it on the catch body. I had something similar in HBASE-23694 after observing the issues described there, but didn't enclose it in a try/catch.

throw new IOException("Failed to delete the WALProcedureStore migrated proc wal directory " +
procWALDir);
LOG.info("Migration of WALProcedureStore finished");
} catch (IOException ioe) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need the catch, or could just stop it on the finally and let the IOE be thrown upwards?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @wchevreuil . I only now noticed you'd just put up a fix for the same thing.

On this line, I should have rethrown the caught exception. I wanted to pass in 'true' for abort if exception as opposed to 'false' for the finally block. I might be overthinking it since IIRC, if problem here, we'll crash out the Master. Let me resolve this in favor of yours.

@saintstack
Copy link
Contributor Author

Closing as dupe of HBASE-23696

@saintstack saintstack closed this Jan 15, 2020
@saintstack
Copy link
Contributor Author

s/HBASE-23696/HBASE-23694/

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 11s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-0 ⚠️ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-2 Compile Tests _
+1 💚 mvninstall 5m 52s branch-2 passed
+1 💚 compile 1m 3s branch-2 passed
+1 💚 checkstyle 1m 35s branch-2 passed
+1 💚 shadedjars 4m 54s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 38s branch-2 passed
+0 🆗 spotbugs 4m 27s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 4m 26s branch-2 passed
_ Patch Compile Tests _
+1 💚 mvninstall 6m 31s the patch passed
+1 💚 compile 1m 13s the patch passed
+1 💚 javac 1m 13s the patch passed
-1 ❌ checkstyle 1m 39s hbase-server: The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 shadedjars 5m 10s patch has no errors when building our shaded downstream artifacts.
+1 💚 hadoopcheck 21m 29s Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 💚 javadoc 0m 41s the patch passed
+1 💚 findbugs 4m 48s the patch passed
_ Other Tests _
-1 ❌ unit 170m 12s hbase-server in the patch failed.
+1 💚 asflicense 0m 28s The patch does not generate ASF License warnings.
239m 44s
Reason Tests
Failed junit tests hadoop.hbase.master.TestMasterNoCluster
Subsystem Report/Notes
Docker Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1050/1/artifact/out/Dockerfile
GITHUB PR #1050
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux ec8679021fd8 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1050/out/precommit/personality/provided.sh
git revision branch-2 / ae95b1f
Default Java 1.8.0_181
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1050/1/artifact/out/diff-checkstyle-hbase-server.txt
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1050/1/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1050/1/testReport/
Max. process+thread count 4979 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1050/1/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants