HBASE-27993 AbstractFSWAL causes ArithmeticException due to improper …

…logRollSize value checking (#5390) Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: Wei-Chiu Chuang <[email protected]> (cherry picked from commit 8be9e51)
apache · Mar 28, 2024 · c2a41cb · c2a41cb
1 parent 55bb08f
commit c2a41cb
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AbstractFSWAL.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AbstractFSWAL.java
@@ -379,6 +379,9 @@ protected long getFileNumFromFileName(Path fileName) {
   }
 
   private int calculateMaxLogFiles(Configuration conf, long logRollSize) {
+    checkArgument(logRollSize > 0,
+      "The log roll size cannot be zero or negative when calculating max log files, "
+        + "current value is " + logRollSize);
     Pair<Long, MemoryType> globalMemstoreSize = MemorySizeUtil.getGlobalMemStoreSize(conf);
     return (int) ((globalMemstoreSize.getFirst() * 2) / logRollSize);
   }