HBASE-22571 made changes according to Jan's 2nd feedback

apache · Jun 17, 2019 · bc1a635 · bc1a635
1 parent e5008c8
commit bc1a635
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 15 deletions.
diff --git a/hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapred/TestTableInputFormat.java b/hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapred/TestTableInputFormat.java
@@ -143,12 +143,11 @@ public static Table createTable(byte[] tableName, byte[][] families) throws IOEx
   /**
    * Verify that the result and key have expected values.
    *
-   * @param r
-   * @param key
-   * @param expectedKey
-   * @param expectedValue
-   * @return true if result and key have expected values, false otherwise. Where result is a single
-   *         row result.
+   * @param r single row result
+   * @param key the row key
+   * @param expectedKey the expected key
+   * @param expectedValue the expected value
+   * @return true if the result contains the expected key and value, false otherwise.
    */
   static boolean checkResult(Result r, ImmutableBytesWritable key,
       byte[] expectedKey, byte[] expectedValue) {

diff --git a/hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapreduce/TestTableInputFormat.java b/hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapreduce/TestTableInputFormat.java
@@ -141,12 +141,11 @@ public static Table createTable(byte[] tableName, byte[][] families) throws IOEx
   /**
    * Verify that the result and key have expected values.
    *
-   * @param r
-   * @param key
-   * @param expectedKey
-   * @param expectedValue
-   * @return true if result and key have expected values, false otherwise. Where result is a single
-   *         row result.
+   * @param r single row result
+   * @param key the row key
+   * @param expectedKey the expected key
+   * @param expectedValue the expected value
+   * @return true if the result contains the expected key and value, false otherwise.
    */
   static boolean checkResult(Result r, ImmutableBytesWritable key,
       byte[] expectedKey, byte[] expectedValue) {

diff --git a/...server/src/test/java/org/apache/hadoop/hbase/TestServerSideScanMetricsFromClientSide.java b/...server/src/test/java/org/apache/hadoop/hbase/TestServerSideScanMetricsFromClientSide.java
@@ -114,7 +114,7 @@ public static void tearDownAfterClass() throws Exception {
    * @param qualifiers the column qualifiers to use
    * @param value the value to put
    * @return the putted input values added in puts
-   * @throws IOException If IO problem is encountered
+   * @throws IOException If an IO problem is encountered
    */
   static ArrayList<Put> createPuts(byte[][] rows, byte[][] families, byte[][] qualifiers,
       byte[] value) throws IOException {

diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHStore.java b/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHStore.java
@@ -794,7 +794,7 @@ private static void flushStore(HStore store, long id) throws IOException {
    * @param numRows
    * @param qualifier
    * @param family
-   * @return row KeyValues list
+   * @return the rows key-value list
    */
   List<Cell> getKeyValueSet(long[] timestamps, int numRows,
       byte[] qualifier, byte[] family) {

diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHStoreFile.java b/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHStoreFile.java
@@ -844,7 +844,7 @@ private HStoreFile mockStoreFile(boolean bulkLoad,
    * @param numRows
    * @param qualifier
    * @param family
-   * @return row KeyValues list
+   * @return the rows key-value list
    */
   List<KeyValue> getKeyValueSet(long[] timestamps, int numRows,
       byte[] qualifier, byte[] family) {