HBASE-22174 Remove error prone from our precommit javac check

apache · Apr 6, 2019 · 86f9443 · 86f9443
1 parent 6abf408
commit 86f9443
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/dev-support/Jenkinsfile_GitHub b/dev-support/Jenkinsfile_GitHub
@@ -153,6 +153,7 @@ pipeline {
                         YETUS_ARGS+=("--whitespace-tabs-ignore-list=.*/generated/.*")
                         YETUS_ARGS+=("--personality=${SOURCEDIR}/dev-support/hbase-personality.sh")
                         YETUS_ARGS+=("--quick-hadoopcheck")
+                        YETUS_ARGS+=("--skip-errorprone")
                         # effectively treat dev-support as a custom maven module
                         YETUS_ARGS+=("--skip-dir=dev-support")
                         # help keep the ASF boxes clean

diff --git a/dev-support/hbase-personality.sh b/dev-support/hbase-personality.sh
@@ -94,6 +94,9 @@ function personality_parse_args
       --hadoop-profile=*)
         HADOOP_PROFILE=${i#*=}
       ;;
+      --skip-errorprone)
+        SKIP_ERRORPRONE=true
+      ;;
     esac
   done
 }
@@ -166,7 +169,7 @@ function personality_modules
     return
   fi
 
-  if [[ ${testtype} == compile ]]; then
+  if [[ ${testtype} == compile ]] && [[ "${SKIP_ERRORPRONE}" != "true" ]]; then
     extra="${extra} -PerrorProne"
   fi