Skip to content

Commit

Permalink
HBASE-24126 Up the container nproc uplimit from 10000 to 12500 (#1504)
Browse files Browse the repository at this point in the history
  • Loading branch information
saintstack committed Apr 15, 2020
1 parent f61aa02 commit 62a488b
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 8 deletions.
6 changes: 1 addition & 5 deletions dev-support/hbase-personality.sh
Original file line number Diff line number Diff line change
Expand Up @@ -81,11 +81,8 @@ function personality_globals

# Yetus 0.7.0 enforces limits. Default proclimit is 1000.
# Up it. See HBASE-19902 for how we arrived at this number.
# NOTE: I don't think changing this has an effect. Set the
# --proclimit passed to yetus. This seems to do what we
# need changing proclimit.
#shellcheck disable=SC2034
PROCLIMIT=12500
PROC_LIMIT=12500

# Set docker container to run with 20g. Default is 4g in yetus.
# See HBASE-19902 for how we arrived at 20g.
Expand Down Expand Up @@ -519,7 +516,6 @@ function hadoopcheck_parse_args
## @stability evolving
function hadoopcheck_docker_support
{
DOCKER_EXTRAARGS=("${DOCKER_EXTRAARGS[@]}" "--ulimit" "nproc=12500")
DOCKER_EXTRAARGS=("${DOCKER_EXTRAARGS[@]}" "--env=QUICK_HADOOPCHECK=${QUICK_HADOOPCHECK}")
}

Expand Down
2 changes: 0 additions & 2 deletions dev-support/hbase_nightly_yetus.sh
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,6 @@ YETUS_ARGS=("--sentinel" "${YETUS_ARGS[@]}")
YETUS_ARGS=("--branch=${BRANCH_NAME}" "${YETUS_ARGS[@]}")
YETUS_ARGS=("--tests-filter=${TESTS_FILTER}" "${YETUS_ARGS[@]}")
YETUS_ARGS=("--ignore-unknown-options=true" "${YETUS_ARGS[@]}")
# Why are these not being picked up from hbase-personality?
YETUS_ARGS=("--proclimit=12500" "${YETUS_ARGS[@]}")
YETUS_ARGS=("--dockermemlimit=20g" "${YETUS_ARGS[@]}")

if [[ -n "${EXCLUDE_TESTS_URL}" ]]; then
Expand Down
1 change: 0 additions & 1 deletion dev-support/jenkins_precommit_github_yetus.sh
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,6 @@ YETUS_ARGS+=("--reapermode=kill")
# set relatively high limits for ASF machines
# changing these to higher values may cause problems
# with other jobs on systemd-enabled machines
YETUS_ARGS+=("--proclimit=12500")
YETUS_ARGS+=("--dockermemlimit=20g")
# -1 spotbugs issues that show up prior to the patch being applied
YETUS_ARGS+=("--spotbugs-strict-precheck")
Expand Down

0 comments on commit 62a488b

Please sign in to comment.