Skip to content

Commit

Permalink
Revert "HBASE-24126 Up the container nproc uplimit from 10000 to 12500 (
Browse files Browse the repository at this point in the history
#1450)"

This reverts commit 14342b6.
  • Loading branch information
saintstack committed Apr 13, 2020
1 parent b6b8c69 commit 3cf2df2
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 8 deletions.
2 changes: 1 addition & 1 deletion dev-support/flaky-tests/flaky-reporting.Jenkinsfile
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ pipeline {
flaky_args=("${flaky_args[@]}" --urls "${JENKINS_URL}/job/HBase%20Nightly/job/${BRANCH_NAME}" --is-yetus True --max-builds 10)
flaky_args=("${flaky_args[@]}" --urls "${JENKINS_URL}/job/HBase-Flaky-Tests/job/${BRANCH_NAME}" --is-yetus False --max-builds 30)
docker build -t hbase-dev-support dev-support
docker run --ulimit nproc=12500 -v "${WORKSPACE}":/hbase --workdir=/hbase hbase-dev-support python dev-support/flaky-tests/report-flakies.py --mvn -v "${flaky_args[@]}"
docker run -v "${WORKSPACE}":/hbase --workdir=/hbase hbase-dev-support python dev-support/flaky-tests/report-flakies.py --mvn -v "${flaky_args[@]}"
'''
}
}
Expand Down
5 changes: 1 addition & 4 deletions dev-support/hbase-personality.sh
Original file line number Diff line number Diff line change
Expand Up @@ -81,11 +81,8 @@ function personality_globals

# Yetus 0.7.0 enforces limits. Default proclimit is 1000.
# Up it. See HBASE-19902 for how we arrived at this number.
# NOTE: I don't think changing this has an effect. Set the
# --proclimit passed to yetus. This seems to do what we
# need changing proclimit.
#shellcheck disable=SC2034
PROCLIMIT=12500
PROCLIMIT=10000

# Set docker container to run with 20g. Default is 4g in yetus.
# See HBASE-19902 for how we arrived at 20g.
Expand Down
2 changes: 1 addition & 1 deletion dev-support/hbase_docker.sh
Original file line number Diff line number Diff line change
Expand Up @@ -159,4 +159,4 @@ done
echo "Successfully built ${IMAGE_NAME}."

echo "Starting hbase shell..."
docker run --ulimit nproc=12500 -it ${IMAGE_NAME}
docker run -it ${IMAGE_NAME}
2 changes: 1 addition & 1 deletion dev-support/hbase_nightly_yetus.sh
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ YETUS_ARGS=("--branch=${BRANCH_NAME}" "${YETUS_ARGS[@]}")
YETUS_ARGS=("--tests-filter=${TESTS_FILTER}" "${YETUS_ARGS[@]}")
YETUS_ARGS=("--ignore-unknown-options=true" "${YETUS_ARGS[@]}")
# Why are these not being picked up from hbase-personality?
YETUS_ARGS=("--proclimit=12500" "${YETUS_ARGS[@]}")
YETUS_ARGS=("--proclimit=10000" "${YETUS_ARGS[@]}")
YETUS_ARGS=("--dockermemlimit=20g" "${YETUS_ARGS[@]}")

if [[ -n "${EXCLUDE_TESTS_URL}" ]]; then
Expand Down
2 changes: 1 addition & 1 deletion dev-support/jenkins_precommit_github_yetus.sh
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ YETUS_ARGS+=("--reapermode=kill")
# set relatively high limits for ASF machines
# changing these to higher values may cause problems
# with other jobs on systemd-enabled machines
YETUS_ARGS+=("--proclimit=12500")
YETUS_ARGS+=("--proclimit=10000")
YETUS_ARGS+=("--dockermemlimit=20g")
# -1 spotbugs issues that show up prior to the patch being applied
YETUS_ARGS+=("--spotbugs-strict-precheck")
Expand Down

0 comments on commit 3cf2df2

Please sign in to comment.