HBASE-26048 [JDK17] Replace the usage of deprecated API ThreadGroup.d…

…estroy() (#5913) Signed-off-by: Xin Sun <[email protected]> (cherry picked from commit 6c84d39)
apache · May 17, 2024 · 02ab90b · 02ab90b
1 parent 8fe524d
commit 02ab90b
Showing 1 changed file with 5 additions and 8 deletions.
diff --git a/hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/ProcedureExecutor.java b/hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/ProcedureExecutor.java
@@ -735,14 +735,11 @@ public void join() {
       Thread.currentThread().interrupt();
     }
 
-    // Destroy the Thread Group for the executors
-    // TODO: Fix. #join is not place to destroy resources.
-    try {
-      threadGroup.destroy();
-    } catch (IllegalThreadStateException e) {
-      LOG.error("ThreadGroup {} contains running threads; {}: See STDOUT", this.threadGroup, e);
-      // This dumps list of threads on STDOUT.
-      this.threadGroup.list();
+    // log the still active threads, ThreadGroup.destroy is deprecated in JDK17 and it is not
+    // necessary for us to must destroy it here, so we just do a check and log
+    if (threadGroup.activeCount() > 0) {
+      LOG.error("There are still active thread in group {}, see STDOUT", threadGroup);
+      threadGroup.list();
     }
 
     // reset the in-memory state for testing