-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDDS-1503. Reduce garbage generated by non-netty threads in datanode ratis server #813
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, the patch looks good to me.
Lets add a link to the grpc-java or RATIS issue here for details.
@mukul1987 I have added the corresponding Ratis issue link. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
+1 from me too. Do we need to update ozone with a new Ratis release to take the newly added config? |
@xiaoyuyao That is not needed. The JVM parameter sets a static field in netty - PooledByteBufAllocator#DEFAULT_USE_CACHE_FOR_ALL_THREADS. Therefore it does not require new Ratis release. |
@mukul1987 @xiaoyuyao Thanks for reviewing the PR! I have merged it to trunk. |
We use GRPC protocol for rpc communication in Ratis. By default thread caches are generated even for non-netty threads. This Jira aims to add a default JVM parameter for disabling thread caches for non-netty threads in datanode ratis server.