-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDDS-1491. Ozone KeyInputStream seek() should not read the chunk file. #795
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Thanks @hanishakoneru for working on this. The patch overall looks good to me. Some minor comments:
|
Thank you @bshashikant for the review. I have addressed your review comments. |
This comment has been minimized.
This comment has been minimized.
Thanks @hanishakoneru for updating the patch. Test failures are related to the patch. Can you please check? |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Thanks @hanishakoneru for updating the patch. The patch looks good to me. I am +1 on this. We can also add tests with read failures in TestKeyInputStream, but these can be added as a part of separate jira. |
💔 -1 overall
This message was automatically generated. |
/retest |
Thank you @bshashikant . |
No description provided.