Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDDS-1468. Inject configuration values to Java objects #772

Closed
wants to merge 4 commits into from

Conversation

elek
Copy link
Member

@elek elek commented Apr 25, 2019

According to the design doc in the parent issue we would like to support java configuration objects which are simple POJO but the fields/setters are annotated. As a first step we can introduce the OzoneConfiguration.getConfigObject() api which can create the config object and inject configuration.

Later we can improve it with annotation processor which can generate the ozone-default.xml.

See: https://issues.apache.org/jira/browse/HDDS-1468

@elek elek added the ozone label Apr 25, 2019
@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 23 Docker mode activated.
_ Prechecks _
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 4 new or modified test files.
_ trunk Compile Tests _
0 mvndep 40 Maven dependency ordering for branch
+1 mvninstall 1207 trunk passed
+1 compile 74 trunk passed
+1 checkstyle 31 trunk passed
+1 mvnsite 76 trunk passed
+1 shadedclient 833 branch has no errors when building and testing our client artifacts.
+1 findbugs 113 trunk passed
+1 javadoc 58 trunk passed
_ Patch Compile Tests _
0 mvndep 11 Maven dependency ordering for patch
+1 mvninstall 74 the patch passed
+1 compile 70 the patch passed
+1 javac 70 the patch passed
-0 checkstyle 25 hadoop-hdds: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 mvnsite 61 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 804 patch has no errors when building and testing our client artifacts.
+1 findbugs 119 the patch passed
+1 javadoc 54 the patch passed
_ Other Tests _
+1 unit 78 common in the patch passed.
-1 unit 88 server-scm in the patch failed.
+1 asflicense 27 The patch does not generate ASF License warnings.
3896
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-772/1/artifact/out/Dockerfile
GITHUB PR #772
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 8e6273679b38 4.4.0-143-generic #169~14.04.2-Ubuntu SMP Wed Feb 13 15:00:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 0b3d41b
maven version: Apache Maven 3.3.9
Default Java 1.8.0_191
findbugs v3.1.0-RC1
checkstyle https://builds.apache.org/job/hadoop-multibranch/job/PR-772/1/artifact/out/diff-checkstyle-hadoop-hdds.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-772/1/artifact/out/patch-unit-hadoop-hdds_server-scm.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-772/1/testReport/
Max. process+thread count 464 (vs. ulimit of 5500)
modules C: hadoop-hdds/common hadoop-hdds/server-scm U: hadoop-hdds
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-772/1/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 32 Docker mode activated.
_ Prechecks _
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 4 new or modified test files.
_ trunk Compile Tests _
0 mvndep 59 Maven dependency ordering for branch
+1 mvninstall 1152 trunk passed
+1 compile 89 trunk passed
+1 checkstyle 31 trunk passed
+1 mvnsite 77 trunk passed
-1 shadedclient 264 branch has errors when building and testing our client artifacts.
-1 findbugs 16 common in trunk failed.
-1 findbugs 26 server-scm in trunk failed.
-1 javadoc 26 common in trunk failed.
_ Patch Compile Tests _
0 mvndep 15 Maven dependency ordering for patch
-1 mvninstall 27 common in the patch failed.
-1 mvninstall 20 server-scm in the patch failed.
+1 compile 80 the patch passed
+1 javac 80 the patch passed
+1 checkstyle 30 the patch passed
-1 mvnsite 23 server-scm in the patch failed.
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 627 patch has no errors when building and testing our client artifacts.
-1 findbugs 19 server-scm in the patch failed.
-1 javadoc 40 hadoop-hdds_common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
-1 javadoc 21 hadoop-hdds_server-scm generated 6 new + 5 unchanged - 0 fixed = 11 total (was 5)
_ Other Tests _
+1 unit 78 common in the patch passed.
-1 unit 24 server-scm in the patch failed.
+1 asflicense 34 The patch does not generate ASF License warnings.
3007
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-772/2/artifact/out/Dockerfile
GITHUB PR #772
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 42a19cb93db1 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / c35abcd
maven version: Apache Maven 3.3.9
Default Java 1.8.0_191
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-772/2/artifact/out/branch-findbugs-hadoop-hdds_common.txt
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-772/2/artifact/out/branch-findbugs-hadoop-hdds_server-scm.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-772/2/artifact/out/branch-javadoc-hadoop-hdds_common.txt
mvninstall https://builds.apache.org/job/hadoop-multibranch/job/PR-772/2/artifact/out/patch-mvninstall-hadoop-hdds_common.txt
mvninstall https://builds.apache.org/job/hadoop-multibranch/job/PR-772/2/artifact/out/patch-mvninstall-hadoop-hdds_server-scm.txt
mvnsite https://builds.apache.org/job/hadoop-multibranch/job/PR-772/2/artifact/out/patch-mvnsite-hadoop-hdds_server-scm.txt
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-772/2/artifact/out/patch-findbugs-hadoop-hdds_server-scm.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-772/2/artifact/out/diff-javadoc-javadoc-hadoop-hdds_common.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-772/2/artifact/out/diff-javadoc-javadoc-hadoop-hdds_server-scm.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-772/2/artifact/out/patch-unit-hadoop-hdds_server-scm.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-772/2/testReport/
Max. process+thread count 445 (vs. ulimit of 5500)
modules C: hadoop-hdds/common hadoop-hdds/server-scm U: hadoop-hdds
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-772/2/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@anuengineer
Copy link
Contributor

+1, Looks good. Thanks.

@elek elek closed this in a2887f5 May 2, 2019
@elek
Copy link
Member Author

elek commented May 2, 2019

Thanks the review @anuengineer . Merging it right now...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants