YARN-9509: Added a configuration for admins to be able to capped per-container cpu usage based on a multiplier #766
+47
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pu usage based on a multiplier
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
jiwq
suggested changes
May 4, 2019
| @@ -138,13 +139,18 @@ void initConfig() throws IOException { | |||
| .NM_LINUX_CONTAINER_CGROUPS_STRICT_RESOURCE_USAGE, | |||
| YarnConfiguration | |||
| .DEFAULT_NM_LINUX_CONTAINER_CGROUPS_STRICT_RESOURCE_USAGE); | |||
| this.cappedMultiplier = | |||
There was a problem hiding this comment.
Suggested change
| this.cappedMultiplier = | |
| this.cappedMultiplier = conf.getFloat( |
| @@ -138,13 +139,18 @@ void initConfig() throws IOException { | |||
| .NM_LINUX_CONTAINER_CGROUPS_STRICT_RESOURCE_USAGE, | |||
| YarnConfiguration | |||
| .DEFAULT_NM_LINUX_CONTAINER_CGROUPS_STRICT_RESOURCE_USAGE); | |||
| this.cappedMultiplier = | |||
| conf | |||
| @@ -138,13 +139,18 @@ void initConfig() throws IOException { | |||
| .NM_LINUX_CONTAINER_CGROUPS_STRICT_RESOURCE_USAGE, | |||
| YarnConfiguration | |||
| .DEFAULT_NM_LINUX_CONTAINER_CGROUPS_STRICT_RESOURCE_USAGE); | |||
| this.cappedMultiplier = | |||
| conf | |||
| .getFloat( | |||
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a multiplier configuration on strict resource usage to authorize container to use spare cpu up to a limit.
Currently with strict resource usage you can't get more than what you request which is sometime not good for jobs that doesn't have a constant usage of cpu (for ex. spark jobs with multiple stages).
But without strict resource usage we have seen some bad behaviour from our users that don't tune at all their needs and it leads to some containers requesting 2 vcore but constantly using 20.
The idea here is to still authorize containers to get more cpu than what they request if some are free but also to avoid too big differencies so SLA on jobs is not breached if the cluster is full (at least increase of runtime is contain)