HDDS-1430. NPE if secure ozone if KMS uri is not defined. Contributed by Ajay Kumar. #752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaoyuyao
reviewed
Apr 18, 2019
| } catch (IOException ioe) { | ||
| LOG.error("Error retrieving KeyProvider.", ioe); | ||
| return null; | ||
| } | ||
| if (keyProvider instanceof DelegationTokenIssuer) { |
There was a problem hiding this comment.
Why don't we just check keyProvider!=null on Line 69 before check if keyProvider instanceof? This way, we don't need other changes.
Note getKeyProvider() will be eventually fixed when OM returns its KMS uri to the client as part of it service discovery.
|
💔 -1 overall
This message was automatically generated. |
xiaoyuyao
reviewed
Apr 26, 2019
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/rpc/OzoneKMSUtil.java
Show resolved
Hide resolved
|
+1 |
shanthoosh
pushed a commit
to shanthoosh/hadoop
that referenced
this pull request
Oct 15, 2019
ClientHelper changed the log-print, which the integration test relies on. Author: [email protected] <[email protected]> Reviewers: Jagadish<[email protected]> Closes apache#752 from rmatharu/integ-test-fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.