HDFS-17565. EC: dfs.datanode.ec.reconstruction.threads should support… #6928
+70
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… dynamic reconfigured.
|
💔 -1 overall
This message was automatically generated. |
zeekling
approved these changes
Jul 8, 2024
...-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
Show resolved
Hide resolved
ayushtkn
reviewed
Jul 9, 2024
| throws ReconfigurationException { | ||
| String result = null; | ||
| try { | ||
| if (property.equals(DFS_DN_EC_RECONSTRUCTION_THREADS_KEY)) { |
There was a problem hiding this comment.
do we need this if condition? it would be always true?
There was a problem hiding this comment.
do we need this if condition? it would be always true?
For now, this if condition is not necessary. I wanted to use this method to handle all about the striped block configuration refresh. Sine only one configuration, I will remove this if condition.
Comment on lines
1093
to
1094
| Integer.parseInt(newVal)); | ||
| result = Long.toString(size); |
There was a problem hiding this comment.
what are we doing here? converting newVal to Integer & then again converting into string? shouldn't we just check null & directly pass the string, rather than this conversion
There was a problem hiding this comment.
There is special case, if the string passed is null, the default value will be used. So there's an extra conversion from int to string.
|
💔 -1 overall
This message was automatically generated. |
haiyang1987
reviewed
Jul 12, 2024
| try { | ||
| int size = (newVal == null ? DFS_DN_EC_RECONSTRUCTION_THREADS_DEFAULT : | ||
| Integer.parseInt(newVal)); | ||
| result = Long.toString(size); |
There was a problem hiding this comment.
result = Integer.toString(size); ?
haiyang1987
reviewed
Jul 12, 2024
| @@ -37,6 +38,9 @@ | |||
| import java.util.concurrent.TimeUnit; | |||
| import java.util.concurrent.atomic.AtomicInteger; | |||
|
|
|||
| import static org.apache.hadoop.hdfs.DFSConfigKeys.DFS_DATANODE_SLOW_IO_WARNING_THRESHOLD_KEY; | |||
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
ayushtkn
approved these changes
Sep 21, 2024
Comment on lines
189
to
190
| Preconditions.checkArgument(poolSize == this.stripedReconstructionPool.getMaximumPoolSize(), | ||
| "The maximum pool size should be equal to core pool size"); |
There was a problem hiding this comment.
I think this isn't required, this looks like validating the ThreadPoolExecutor, that ain't a hadoop thing & isn't required here in the scope either
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
dfs.datanode.ec.reconstruction.threads should support dynamic reconfigured, then we can adjust the speed of ec block copy. Especially HDFS-17550 wanna decommissioning DataNode by EC block reconstruction.
How was this patch tested?
unit test
For code changes: