-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HDDS-1363] ozone.metadata.dirs doesn't pick multiple dirs #691
Conversation
💔 -1 overall
This message was automatically generated. |
@nandakumar131 @hanishakoneru please review |
Thanks @adoroszlai for the analysis and PR. The change looks good. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, LGTM.
What changes were proposed in this pull request?
ozone.metadata.dirs
is a global fallback for per-component directory configurations, eg.ozone.om.db.dirs
,ozone.scm.db.dirs
, etc. All of these handle only a single location, but values with multiple comma-separated paths (eg./data/dir1,/data/dir2
) are treated in different ways:The goal of this change is to reject comma-separated paths for
ozone.metadata.dirs
, too, by applying the same logic that is already used for the per-component configs.In addition, the following minor fixes are included:
ServerUtils#getDirectoryFromConfig
, which referenced the component name (eg.SCM
) instead of the config item name (eg.ozone.om.db.dirs
) as "configuration setting".ServerUtils
to the newServerUtilsTest
class fromTestHddsServerUtils
ScmUtils.getDBPath
, reuseServerUtils#getDirectoryFromConfig
https://issues.apache.org/jira/browse/HDDS-1363
How was this patch tested?
Unit tests (new and existing).
Tested manually using
ozone
docker-compose setup.