-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HADOOP-19084. Prune hadoop-common transitive dependencies (#6574) #6582
Merged
steveloughran
merged 1 commit into
apache:trunk
from
steveloughran:build/HADOOP-19084-prune-deps
Mar 1, 2024
Merged
HADOOP-19084. Prune hadoop-common transitive dependencies (#6574) #6582
steveloughran
merged 1 commit into
apache:trunk
from
steveloughran:build/HADOOP-19084-prune-deps
Mar 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exclude more artifacts which are dependencies of hadoop-* modules, with the goal of keeping conflict out of downstream applications. In particular we have pruned the dependencies of of: -zookeeper -other libraries referencing logging This keeps slf4j-log4j12 and log4j12 off the classpath of applications importing hadoop-common. Somehow logback references do still surface; applications pulling in hadoop-common directly or indirectly should review their imports carefully. Contributed by Steve Loughran
💔 -1 overall
This message was automatically generated. |
slfan1989
approved these changes
Feb 26, 2024
dineshchitlangia
approved these changes
Feb 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 LGTM, thanks Steve
@steveloughran Thank you for the contribution! We can merge this PR now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6574 for trunk
Exclude more artifacts which are dependencies of hadoop-* modules, with the goal of keeping conflict out of downstream applications.
In particular we have pruned the dependencies of of: -zookeeper
-other libraries referencing logging
This keeps slf4j-log4j12 and log4j12 off the classpath of applications importing hadoop-common.
Somehow logback references do still surface; applications pulling in hadoop-common directly or indirectly should review their imports carefully.
Description of PR
How was this patch tested?
For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?