-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDFS-17393. Remove unused FSNamesysteLock cond
in FSNamesystem
#6567
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Jenkins has not been performing well recently, and thus there are no CI comments. However, the change clearly looks good and I believe it is good for merging.
I'm really looking forward to FGL. However, I suggest we remove 'FGL' from the title and the commit comment as this change is a regular refactoring and not only related to FGL. |
@tasanuma I agree with your point, and I greatly appreciate @ZanderXu contribution; it's incredibly valuable. I have a suggestion: could we complete some of the description information? |
Thanks @tasanuma @slfan1989 for your review, let me modify this ticket. |
cond
in FSNamesystemcond
in FSNamesystem
@ZanderXu Thanks for pushing it forward. |
@tasanuma @slfan1989 Thanks for reviewing it. Merged. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
FSNamesystemLock
cond
in FSNamesystem is unused, so we can remove it first.