HDFS-17272. NNThroughputBenchmark should support specifying the base directory for multi-client test #6319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 +1 overall
This message was automatically generated. |
ayushtkn
reviewed
Dec 3, 2023
| @@ -736,7 +746,7 @@ class OpenFileStats extends CreateFileStats { | |||
| static final String OP_OPEN_NAME = "open"; | |||
| static final String OP_USAGE_ARGS = | |||
| " [-threads T] [-files N] [-blockSize S] [-filesPerDir P]" | |||
| + " [-useExisting]"; | |||
| + " [-baseDirName D] [-useExisting]"; | |||
There was a problem hiding this comment.
add the new parameter towards the end
| @@ -1348,7 +1363,7 @@ class ReplicationStats extends OperationStatsBase { | |||
| static final String OP_REPLICATION_USAGE = | |||
| "-op replication [-datanodes T] [-nodesToDecommission D] " + | |||
| "[-nodeReplicationLimit C] [-totalBlocks B] [-blockSize S] " | |||
| + "[-replication R]"; | |||
| + "[-replication R] [-baseDirName N]"; | |||
There was a problem hiding this comment.
somewhere us baseDirName D and here it is baseDirName N
Shouldn't be inconsistent I believe
| nameDir.getAbsolutePath()); | ||
| DFSTestUtil.formatNameNode(conf); | ||
| NNThroughputBenchmark.runBenchmark(conf, | ||
| new String[] {"-op", "all", "-baseDirName", "/nnThroughputBenchmark1"}); |
There was a problem hiding this comment.
test should check nnThroughputBenchmark1 was used & the default directory wasn't created nor used.
try with other operations as well apart from all
|
@ayushtkn Thank you for your review. I have updated based on your suggestions. |
|
🎊 +1 overall
This message was automatically generated. |
tomscut
reviewed
Dec 5, 2023
ayushtkn
reviewed
Dec 5, 2023
Comment on lines
1349
to
1379
| "-op replication [-datanodes T] [-nodesToDecommission D] " + | ||
| "-op replication [-datanodes T] [-nodesToDecommission N] " + |
There was a problem hiding this comment.
we can't change the existing commands, that is an incomatible change, whatever needs to be done should be done for new commands only.
btw. what does this letter denote?
There was a problem hiding this comment.
Can we both -nodesToDecommission and -baseDirName use D?
There was a problem hiding this comment.
If it has no physical meaning, then yes, can check if other alphabets are not used, so can explore using them P as in Path or B as in BaseDir or some similar, else use whichever you like :-)
There was a problem hiding this comment.
P and B has also been used, such as -blocksPerReport B and -filesPerDir P. And other alphabets cannot be related to directory I think. Could I keep using D?
There was a problem hiding this comment.
ok, just double check they don't have any specific usage apart from just being alphabets in the description
There was a problem hiding this comment.
ok. Only -nodesToDecommission used the D alphabet.
ayushtkn
reviewed
Dec 5, 2023
...oop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNNThroughputBenchmark.java
Outdated
Show resolved
Hide resolved
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
lfxy
force-pushed
the
feature/HDFS-17272
branch
from
d6b7c88 to
14566b7
Compare
|
🎊 +1 overall
This message was automatically generated. |
jiajunmao
pushed a commit
to jiajunmao/hadoop-MLEC
that referenced
this pull request
Feb 6, 2024
…directory for multi-client test (apache#6319). Contributed by caozhiqiang. Reviewed-by: Tao Li <[email protected]> Signed-off-by: Ayush Saxena <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, NNThroughputBenchmark does not support specifying the base directory, therefore does not support multiple clients performing stress testing at the same time. However, for high-performance namenode machine, only one client submitting stress test can not make the namenode rpc access reach the bottleneck. Therefore, multiple clients are required for parallel testing to make the namenode pressure reach the level of the large-scale production cluster.
So I specify the base directory through the -baseDirName parameter to support multiple clients submitting stress tests at the same time.