YARN-11614. [Federation] Add Federation PolicyManager Validation Rules. #6271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
goiri
reviewed
Nov 15, 2023
| @@ -170,6 +170,26 @@ public static void checkHeadRoomAlphaValid(String headRoomAlpha) throws YarnExce | |||
| } | |||
| } | |||
|
|
|||
| public static void checkPolicyManagerValid(String policyManager) throws YarnException { | |||
| switch (policyManager) { | |||
| case "org.apache.hadoop.yarn.server.federation.policies.manager.HashBroadcastPolicyManager": | |||
There was a problem hiding this comment.
Can we use some of the getClass().getSimpleName() or similar methods?
There was a problem hiding this comment.
This is a good idea! I will improve this part of the code. I will add verification on the router side.
| case "org.apache.hadoop.yarn.server.federation.policies.manager.HashBroadcastPolicyManager": | ||
| throw new YarnException("HashBroadcastPolicyManager does not support the use of queue weights."); | ||
| case "org.apache.hadoop.yarn.server.federation.policies.manager.HomePolicyManager": | ||
| throw new YarnException("HomePolicyManager does not support the use of queue weights."); |
There was a problem hiding this comment.
I think we can do a list for the ones that support weights, and if it's not there, return the exception,
There was a problem hiding this comment.
I will improve this part of the code.
|
💔 -1 overall
This message was automatically generated. |
goiri
approved these changes
Nov 16, 2023
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
@goiri Thank you very much for your help in reviewing the code! |
jiajunmao
pushed a commit
to jiajunmao/hadoop-MLEC
that referenced
this pull request
Feb 6, 2024
…s. (apache#6271) Contributed by Shilun Fan. Reviewed-by: Inigo Goiri <[email protected]> Signed-off-by: Shilun Fan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
JIRA: YARN-11614. [Federation] Add Federation PolicyManager Validation Rules.
When entering queue weights in Federation, it is essential to enhance the validation rules. If a policy manager does not support weights, a prompt should be provided to the user.
How was this patch tested?
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?