HDFS-17249. Fix TestDFSUtil.testIsValidName() unit test failure #6249

LiuGuH · 2023-11-03T05:47:45Z

Description of PR

TestDFSUtil.testIsValidName runs failed when assertFalse(DFSUtil.isValidName("/foo/:/bar")) , fixed it.
HDFS-17249.

How was this patch tested?

Add test case in TestDFSUtil.testIsValidName.

hadoop-yetus · 2023-11-03T07:21:40Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 30s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+1 💚	mvninstall	33m 51s		trunk passed
+1 💚	compile	0m 44s		trunk passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04
+1 💚	compile	0m 40s		trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	checkstyle	0m 23s		trunk passed
+1 💚	mvnsite	0m 40s		trunk passed
+1 💚	javadoc	0m 39s		trunk passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	0m 32s		trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	spotbugs	1m 38s		trunk passed
+1 💚	shadedclient	21m 50s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 32s		the patch passed
+1 💚	compile	0m 34s		the patch passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04
+1 💚	javac	0m 34s		the patch passed
+1 💚	compile	0m 30s		the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	javac	0m 30s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 15s		the patch passed
+1 💚	mvnsite	0m 32s		the patch passed
+1 💚	javadoc	0m 26s		the patch passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	0m 26s		the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	spotbugs	1m 31s		the patch passed
+1 💚	shadedclient	21m 13s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	1m 54s		hadoop-hdfs-client in the patch passed.
+1 💚	asflicense	0m 28s		The patch does not generate ASF License warnings.
		92m 9s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6249/1/artifact/out/Dockerfile
GITHUB PR	#6249
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux 1647ddffbe6c 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `9f7aac6`
Default Java	Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6249/1/testReport/
Max. process+thread count	726 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs-client U: hadoop-hdfs-project/hadoop-hdfs-client
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6249/1/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

LiuGuH · 2023-11-03T07:24:51Z

@GauthamBanasandra , hello sir，do you have time to review it，Thanks

GauthamBanasandra

Could you please enhance the unit test testIsValidName with the following -

if (Shell.WINDOWS) {
  assertTrue(DFSUtil.isValidName("/C:/some/path"));
} else {
  assertFalse(DFSUtil.isValidName("/C:/some/path"));
}

GauthamBanasandra · 2023-11-03T10:43:26Z

hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSUtilClient.java

@@ -661,9 +661,12 @@ public static boolean isValidName(String src) {
    String[] components = StringUtils.split(src, '/');
    for (int i = 0; i < components.length; i++) {
      String element = components[i];
+      // For Windows, we must allow the : in the drive letter.
+      if (Shell.WINDOWS && i == 1 && element.contains(":")) {


Could you please make an endsWith check for : instead of element.contains?

GauthamBanasandra

@LiuGuH could you please file a new bug on issues.apache.org and use it instead of tagging to HDFS-17248?

LiuGuH · 2023-11-03T13:01:53Z

@LiuGuH could you please file a new bug on issues.apache.org and use it instead of tagging to HDFS-17248?

Sure. I can. But what's the difference between them that I need to notice？ Thanks

GauthamBanasandra · 2023-11-03T14:33:12Z

@LiuGuH could you please file a new bug on issues.apache.org and use it instead of tagging to HDFS-17248?

Sure. I can. But what's the difference between them that I need to notice？ Thanks

@LiuGuH in the Hadoop community we normally follow the convention where the bug title in JIRA matches that of the Github PR.

In this case, HDFS-17248 in JIRA has the title Fix shaded client for building Hadoop on Windows. So, it can't have the title that you have put currently (Fix isValidName error).

Thus, you'll need to create a new JIRA for this.

LiuGuH · 2023-11-03T15:10:53Z

@GauthamBanasandra I create a new JIRA for this. If the title is not matches, please give me a suggestion .Thanks.

hadoop-yetus · 2023-11-03T18:06:40Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 28s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+0 🆗	mvndep	13m 52s		Maven dependency ordering for branch
+1 💚	mvninstall	19m 49s		trunk passed
+1 💚	compile	3m 13s		trunk passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04
+1 💚	compile	3m 5s		trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	checkstyle	0m 53s		trunk passed
+1 💚	mvnsite	1m 40s		trunk passed
+1 💚	javadoc	1m 25s		trunk passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	1m 46s		trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	spotbugs	3m 29s		trunk passed
+1 💚	shadedclient	21m 33s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 27s		Maven dependency ordering for patch
+1 💚	mvninstall	1m 15s		the patch passed
+1 💚	compile	3m 7s		the patch passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04
+1 💚	javac	3m 7s		the patch passed
+1 💚	compile	2m 58s		the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	javac	2m 58s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 42s		the patch passed
+1 💚	mvnsite	1m 20s		the patch passed
+1 💚	javadoc	1m 8s		the patch passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	1m 29s		the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	spotbugs	3m 27s		the patch passed
+1 💚	shadedclient	23m 56s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	2m 3s		hadoop-hdfs-client in the patch passed.
+1 💚	unit	199m 52s		hadoop-hdfs in the patch passed.
+1 💚	asflicense	0m 37s		The patch does not generate ASF License warnings.
		315m 16s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6249/2/artifact/out/Dockerfile
GITHUB PR	#6249
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux c6e98e525e7d 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `5a5ede8`
Default Java	Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6249/2/testReport/
Max. process+thread count	3744 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6249/2/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

GauthamBanasandra · 2023-11-04T15:19:38Z

@LiuGuH could you please file a new bug on issues.apache.org and use it instead of tagging to HDFS-17248?

Sure. I can. But what's the difference between them that I need to notice？ Thanks

@LiuGuH in the Hadoop community we normally follow the convention where the bug title in JIRA matches that of the Github PR.

In this case, HDFS-17248 in JIRA has the title Fix shaded client for building Hadoop on Windows. So, it can't have the title that you have put currently (Fix isValidName error).

Thus, you'll need to create a new JIRA for this.

@LiuGuH I apologize for the confusion. The JIRA that you had created originally (HDFS-17248) had no issues. I overlooked the number and thought it was the same as HDFS-17246.

Anyway, we can go ahead with what you've tagged currently.

GauthamBanasandra

These changes look good to me. I've started a Windows CI run to make sure we don't break anything on Windows - https://ci-hadoop.apache.org/view/Hadoop/job/hadoop-qbt-trunk-java8-win10-x86_64/306/console

We can merge once the CI run finishes. It'll take around 1.5 days to finish.

GauthamBanasandra · 2023-11-06T14:43:29Z

Seems like the run was aborted due to a restart -

15:18:17  Elapsed:   8m 13s
15:25:25  cd /c/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
15:25:25  mvn --batch-mode -Ptest-patch -Pdist -Dtar -Pnative-win -Dhttps.protocols=TLSv1.2 -Drequire.openssl -Drequire.test.libhadoop -Dshell-executable=/c/Git/bin/bash.exe -Dopenssl.prefix=/c/vcpkg/installed/x64-windows -Dcmake.prefix.path=/c/vcpkg/installed/x64-windows -Dwindows.cmake.toolchain.file=/c/vcpkg/scripts/buildsystems/vcpkg.cmake -Dwindows.cmake.build.type=RelWithDebInfo -Dwindows.build.hdfspp.dll=off -Dwindows.no.sasl=on -Duse.platformToolsetVersion=v142 -Dsurefire.rerunFailingTestsCount=2 -Pparallel-tests -Pshelltest -Drequire.test.libhadoop -Drequire.snappy -Pdist -Dtar -Pnative-win -Dhttps.protocols=TLSv1.2 -Drequire.openssl -Drequire.test.libhadoop -Dshell-executable=/c/Git/bin/bash.exe -Dopenssl.prefix=/c/vcpkg/installed/x64-windows -Dcmake.prefix.path=/c/vcpkg/installed/x64-windows -Dwindows.cmake.toolchain.file=/c/vcpkg/scripts/buildsystems/vcpkg.cmake -Dwindows.cmake.build.type=RelWithDebInfo -Dwindows.build.hdfspp.dll=off -Dwindows.no.sasl=on -Duse.platformToolsetVersion=v142 clean test -fae > /c/out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt 2>&1
Resuming build at Sun Nov 05 14:23:08 UTC 2023 after Jenkins restart
Waiting to resume part of Apache Hadoop Nightly Build on Windows 10 #306: Finished waiting
Waiting to resume part of Apache Hadoop Nightly Build on Windows 10 #306: Finished waiting
Waiting to resume part of Apache Hadoop Nightly Build on Windows 10 #306: Jenkins is about to shut down

I've started a new run - https://ci-hadoop.apache.org/view/Hadoop/job/hadoop-qbt-trunk-java8-win10-x86_64/310/console

steveloughran · 2023-11-08T14:18:51Z

having hit this myself, I'm going to say "this PR needss to include the name passed in rather than just assert true/false"

proposed,

assertValidName(String name) {
 assertFalse("Should have been rejected '" + name + "'", isValidName(name);
}

...and all asserts in the test case switched over to this. think how much easier it will be debugging yetus falures the next time there's a regressoin.

steveloughran

proposed changes to the test case to remove duplication and assist in analysing future test failures. It is always good to clean up tests when the opportunity arises, with my ideal "you can understand what the assertion failure was without trying to correlate the line in your IDE"

LiuGuH · 2023-11-09T07:56:53Z

I've started a new run - https://ci-hadoop.apache.org/view/Hadoop/job/hadoop-qbt-trunk-java8-win10-x86_64/310/console

When this run finished ， I will add all asserts in the test case switched over to this @steveloughran Thanks

assertValidName(String name) {
assertFalse("Should have been rejected '" + name + "'", isValidName(name);
}

hadoop-yetus · 2023-11-10T07:21:31Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	9m 11s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+0 🆗	mvndep	14m 17s		Maven dependency ordering for branch
+1 💚	mvninstall	20m 12s		trunk passed
+1 💚	compile	3m 11s		trunk passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04
+1 💚	compile	3m 4s		trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	checkstyle	0m 53s		trunk passed
+1 💚	mvnsite	1m 35s		trunk passed
+1 💚	javadoc	1m 25s		trunk passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	1m 45s		trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	spotbugs	3m 28s		trunk passed
+1 💚	shadedclient	25m 34s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 22s		Maven dependency ordering for patch
+1 💚	mvninstall	1m 37s		the patch passed
+1 💚	compile	3m 50s		the patch passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04
+1 💚	javac	3m 50s		the patch passed
+1 💚	compile	3m 21s		the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	javac	3m 21s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	0m 45s	/results-checkstyle-hadoop-hdfs-project.txt	hadoop-hdfs-project: The patch generated 2 new + 81 unchanged - 0 fixed = 83 total (was 81)
+1 💚	mvnsite	1m 18s		the patch passed
+1 💚	javadoc	1m 5s		the patch passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	1m 25s		the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	spotbugs	3m 31s		the patch passed
+1 💚	shadedclient	21m 39s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	1m 59s		hadoop-hdfs-client in the patch passed.
+1 💚	unit	199m 6s		hadoop-hdfs in the patch passed.
+1 💚	asflicense	0m 38s		The patch does not generate ASF License warnings.
		326m 54s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6249/3/artifact/out/Dockerfile
GITHUB PR	#6249
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux 77c4ea86da58 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `8eec4d1`
Default Java	Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6249/3/testReport/
Max. process+thread count	3576 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6249/3/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2023-11-10T09:44:49Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	15m 10s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+0 🆗	detsecrets	0m 1s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+0 🆗	mvndep	14m 23s		Maven dependency ordering for branch
+1 💚	mvninstall	31m 48s		trunk passed
+1 💚	compile	6m 8s		trunk passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04
+1 💚	compile	6m 37s		trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	checkstyle	1m 33s		trunk passed
+1 💚	mvnsite	2m 26s		trunk passed
+1 💚	javadoc	1m 55s		trunk passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	2m 27s		trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	spotbugs	5m 57s		trunk passed
+1 💚	shadedclient	35m 10s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 31s		Maven dependency ordering for patch
+1 💚	mvninstall	1m 56s		the patch passed
+1 💚	compile	5m 50s		the patch passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04
+1 💚	javac	5m 50s		the patch passed
+1 💚	compile	5m 57s		the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	javac	5m 57s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	1m 18s	/results-checkstyle-hadoop-hdfs-project.txt	hadoop-hdfs-project: The patch generated 2 new + 82 unchanged - 0 fixed = 84 total (was 82)
+1 💚	mvnsite	2m 32s		the patch passed
+1 💚	javadoc	1m 34s		the patch passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	2m 11s		the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	spotbugs	6m 5s		the patch passed
+1 💚	shadedclient	37m 4s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	2m 28s		hadoop-hdfs-client in the patch passed.
+1 💚	unit	272m 47s		hadoop-hdfs in the patch passed.
+1 💚	asflicense	0m 50s		The patch does not generate ASF License warnings.
		466m 52s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6249/5/artifact/out/Dockerfile
GITHUB PR	#6249
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux ac59176a1fd1 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `8eec4d1`
Default Java	Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6249/5/testReport/
Max. process+thread count	2992 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6249/5/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2023-11-10T09:45:59Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	17m 8s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 1s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+0 🆗	mvndep	14m 23s		Maven dependency ordering for branch
+1 💚	mvninstall	33m 2s		trunk passed
+1 💚	compile	6m 30s		trunk passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04
+1 💚	compile	6m 18s		trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	checkstyle	1m 27s		trunk passed
+1 💚	mvnsite	2m 31s		trunk passed
+1 💚	javadoc	2m 2s		trunk passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	2m 23s		trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	spotbugs	5m 59s		trunk passed
+1 💚	shadedclient	36m 58s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 31s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 7s		the patch passed
+1 💚	compile	6m 32s		the patch passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04
+1 💚	javac	6m 32s		the patch passed
+1 💚	compile	5m 53s		the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	javac	5m 53s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	1m 16s	/results-checkstyle-hadoop-hdfs-project.txt	hadoop-hdfs-project: The patch generated 2 new + 82 unchanged - 0 fixed = 84 total (was 82)
+1 💚	mvnsite	2m 13s		the patch passed
+1 💚	javadoc	1m 37s		the patch passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	2m 6s		the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	spotbugs	5m 57s		the patch passed
+1 💚	shadedclient	35m 53s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	2m 28s		hadoop-hdfs-client in the patch passed.
+1 💚	unit	272m 4s		hadoop-hdfs in the patch passed.
+1 💚	asflicense	0m 47s		The patch does not generate ASF License warnings.
		469m 56s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6249/4/artifact/out/Dockerfile
GITHUB PR	#6249
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux ca870b294a07 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `8eec4d1`
Default Java	Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6249/4/testReport/
Max. process+thread count	3465 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6249/4/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

GauthamBanasandra · 2023-11-13T08:45:11Z

@steveloughran could you please review this PR?

…he#6249) Contributed by liuguanghua.

Fix isValidName error

9f7aac6

github-actions bot added HDFS trunk labels Nov 3, 2023

GauthamBanasandra requested changes Nov 3, 2023

View reviewed changes

GauthamBanasandra assigned LiuGuH Nov 3, 2023

GauthamBanasandra requested changes Nov 3, 2023

View reviewed changes

add test case

5a5ede8

LiuGuH requested a review from GauthamBanasandra November 3, 2023 13:04

LiuGuH changed the title ~~HDFS-17248. Fix isValidName error~~ HDFS-17249. Add test case for DFSUtil.isValidName Nov 3, 2023

LiuGuH changed the title ~~HDFS-17249. Add test case for DFSUtil.isValidName~~ HDFS-17249. TestDFSUtil.testIsValidName() run failure Nov 3, 2023

goiri approved these changes Nov 3, 2023

View reviewed changes

GauthamBanasandra changed the title ~~HDFS-17249. TestDFSUtil.testIsValidName() run failure~~ HDFS-17249. Fix TestDFSUtil.testIsValidName() unit test failure Nov 4, 2023

GauthamBanasandra approved these changes Nov 4, 2023

View reviewed changes

steveloughran requested changes Nov 8, 2023

View reviewed changes

steveloughran mentioned this pull request Nov 8, 2023

HDFS-16791. Add getEnclosingRoot() API to filesystem interface and implementations #6198

Merged

4 tasks

LiuGuH force-pushed the isValidName branch from cc1d50e to e0d9eac Compare November 10, 2023 01:54

change test case to output more info

8eec4d1

LiuGuH force-pushed the isValidName branch from e0d9eac to 8eec4d1 Compare November 10, 2023 01:56

LiuGuH requested a review from steveloughran November 10, 2023 01:57

GauthamBanasandra approved these changes Nov 10, 2023

View reviewed changes

gp1314 mentioned this pull request Nov 13, 2023

HDFS-17223. Add journalnode maintenance node list #6183

Open

4 tasks

steveloughran approved these changes Nov 13, 2023

View reviewed changes

steveloughran merged commit 342e6ca into apache:trunk Nov 13, 2023
2 checks passed

LiuGuH deleted the isValidName branch January 12, 2024 05:55

jiajunmao pushed a commit to jiajunmao/hadoop-MLEC that referenced this pull request Feb 6, 2024

HDFS-17249. Fix TestDFSUtil.testIsValidName() unit test failure (apac…

573ff7e

…he#6249) Contributed by liuguanghua.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HDFS-17249. Fix TestDFSUtil.testIsValidName() unit test failure #6249

HDFS-17249. Fix TestDFSUtil.testIsValidName() unit test failure #6249

LiuGuH commented Nov 3, 2023 •

edited by goiri

Loading

hadoop-yetus commented Nov 3, 2023

LiuGuH commented Nov 3, 2023

GauthamBanasandra left a comment •

edited

Loading

GauthamBanasandra Nov 3, 2023

LiuGuH Nov 3, 2023

GauthamBanasandra left a comment

LiuGuH commented Nov 3, 2023

GauthamBanasandra commented Nov 3, 2023

LiuGuH commented Nov 3, 2023

hadoop-yetus commented Nov 3, 2023

GauthamBanasandra commented Nov 4, 2023

GauthamBanasandra left a comment

GauthamBanasandra commented Nov 6, 2023

steveloughran commented Nov 8, 2023

steveloughran left a comment

LiuGuH commented Nov 9, 2023

hadoop-yetus commented Nov 10, 2023

hadoop-yetus commented Nov 10, 2023

hadoop-yetus commented Nov 10, 2023

GauthamBanasandra commented Nov 13, 2023

HDFS-17249. Fix TestDFSUtil.testIsValidName() unit test failure #6249

HDFS-17249. Fix TestDFSUtil.testIsValidName() unit test failure #6249

Conversation

LiuGuH commented Nov 3, 2023 • edited by goiri Loading

Description of PR

How was this patch tested?

hadoop-yetus commented Nov 3, 2023

LiuGuH commented Nov 3, 2023

GauthamBanasandra left a comment • edited Loading

Choose a reason for hiding this comment

GauthamBanasandra Nov 3, 2023

Choose a reason for hiding this comment

LiuGuH Nov 3, 2023

Choose a reason for hiding this comment

GauthamBanasandra left a comment

Choose a reason for hiding this comment

LiuGuH commented Nov 3, 2023

GauthamBanasandra commented Nov 3, 2023

LiuGuH commented Nov 3, 2023

hadoop-yetus commented Nov 3, 2023

GauthamBanasandra commented Nov 4, 2023

GauthamBanasandra left a comment

Choose a reason for hiding this comment

GauthamBanasandra commented Nov 6, 2023

steveloughran commented Nov 8, 2023

steveloughran left a comment

Choose a reason for hiding this comment

LiuGuH commented Nov 9, 2023

hadoop-yetus commented Nov 10, 2023

hadoop-yetus commented Nov 10, 2023

hadoop-yetus commented Nov 10, 2023

GauthamBanasandra commented Nov 13, 2023

LiuGuH commented Nov 3, 2023 •

edited by goiri

Loading

GauthamBanasandra left a comment •

edited

Loading