-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HADOOP-18962. Upgrade kafka to 3.4.0 #6247
Conversation
💔 -1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking at the other import changes. #6842 updates org.lz4:lz4-java:1.8.0 as well.
can someone do a full hadoop distro build and show what's in the lib folders so we can see what is really there?
@@ -376,7 +376,7 @@ hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/io/com | |||
hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/fuse-dfs/util/tree.h | |||
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/compat/{fstatat|openat|unlinkat}.h | |||
|
|||
com.github.luben:zstd-jni:1.4.9-1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where does this change come from? a transient import of kafka?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated LICENSE-binary based on the following result.
$mvn dependency:tree -pl hadoop-tools/hadoop-kafka
...
[INFO] +- org.apache.kafka:kafka-clients:jar:3.4.0:compile
[INFO] | +- com.github.luben:zstd-jni:jar:1.5.2-1:runtime
[INFO] | \- org.lz4:lz4-java:jar:1.7.1:runtime
it's right, org.lz4:lz4-java does not require updates.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
+1
ok, merged. can someone do cherrypick PRs for
so that the next release of either of these gets the fix too. thanks! |
Upgrade Kafka Client due to CVEs * CVE-2023-25194 * CVE-2021-38153 * CVE-2018-17196 Contributed by Murali Krishna Change-Id: I4014018f28523f629f9318adafc1f71e9b0845de
Upgrade Kafka Client due to CVEs * CVE-2023-25194 * CVE-2021-38153 * CVE-2018-17196 Contributed by Murali Krishna
Upgrade Kafka Client due to CVEs * CVE-2023-25194 * CVE-2021-38153 * CVE-2018-17196 Contributed by Murali Krishna
Description of PR
Upgrade kafka to 3.4.0 to fix CVE
How was this patch tested?
Built on local. ran unit tests of hadoop-tools/hadoop-kafka project
For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?