[Federtion]YARN-11604 Fix code annotation errors such as class DefaultClientRequ… #6242

singer-bin · 2023-11-02T02:52:57Z

…estInterceptor

hadoop-yetus · 2023-11-02T05:09:44Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	1m 15s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+1 💚	mvninstall	47m 53s		trunk passed
+1 💚	compile	0m 31s		trunk passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04
+1 💚	compile	0m 28s		trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	checkstyle	0m 27s		trunk passed
+1 💚	mvnsite	0m 32s		trunk passed
+1 💚	javadoc	0m 36s		trunk passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	0m 28s		trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	spotbugs	0m 56s		trunk passed
+1 💚	shadedclient	37m 18s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 23s		the patch passed
+1 💚	compile	0m 24s		the patch passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04
+1 💚	javac	0m 24s		the patch passed
+1 💚	compile	0m 20s		the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	javac	0m 20s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 17s		the patch passed
+1 💚	mvnsite	0m 23s		the patch passed
+1 💚	javadoc	0m 23s		the patch passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	0m 20s		the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	spotbugs	0m 55s		the patch passed
+1 💚	shadedclient	37m 12s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	0m 27s		hadoop-yarn-server-router in the patch passed.
+1 💚	asflicense	0m 34s		The patch does not generate ASF License warnings.
		135m 32s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6242/1/artifact/out/Dockerfile
GITHUB PR	#6242
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux bf82728e3cab 5.15.0-78-generic #85-Ubuntu SMP Fri Jul 7 15:25:09 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `773b68b`
Default Java	Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6242/1/testReport/
Max. process+thread count	532 (vs. ulimit of 5500)
modules	C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6242/1/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

slfan1989 · 2023-11-02T08:18:33Z

...src/main/java/org/apache/hadoop/yarn/server/router/webapp/DefaultRequestInterceptorREST.java

@@ -71,7 +71,7 @@
 import org.apache.hadoop.yarn.webapp.util.WebAppUtils;

 /**
- * Extends the AbstractRequestInterceptorClient class and provides an
+ * Extends the AbstractClientRequestInterceptor class and provides an


AbstractClientRequestInterceptor -> AbstractRESTRequestInterceptor

slfan1989 · 2023-11-02T08:34:23Z

@singer-bin Thank you for your contribution! LGTM.

…erceptorREST.java

hadoop-yetus · 2023-11-07T09:01:07Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	8m 52s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+0 🆗	detsecrets	0m 1s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+1 💚	mvninstall	44m 5s		trunk passed
+1 💚	compile	0m 37s		trunk passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04
+1 💚	compile	0m 33s		trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	checkstyle	0m 34s		trunk passed
+1 💚	mvnsite	0m 40s		trunk passed
+1 💚	javadoc	0m 41s		trunk passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	0m 34s		trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	spotbugs	1m 1s		trunk passed
+1 💚	shadedclient	34m 4s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 26s		the patch passed
+1 💚	compile	0m 26s		the patch passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04
+1 💚	javac	0m 26s		the patch passed
+1 💚	compile	0m 23s		the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	javac	0m 23s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 18s		the patch passed
+1 💚	mvnsite	0m 27s		the patch passed
+1 💚	javadoc	0m 25s		the patch passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	0m 23s		the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	spotbugs	1m 0s		the patch passed
+1 💚	shadedclient	33m 9s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	0m 31s		hadoop-yarn-server-router in the patch passed.
+1 💚	asflicense	0m 40s		The patch does not generate ASF License warnings.
		134m 37s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6242/2/artifact/out/Dockerfile
GITHUB PR	#6242
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux 23ba2b47de94 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `ead8376`
Default Java	Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6242/2/testReport/
Max. process+thread count	557 (vs. ulimit of 5500)
modules	C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6242/2/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

singer-bin · 2023-11-07T10:09:22Z

@slfan1989 Thank you very much for your help in reviewing the code!The error has nothing to do with PR！

YARN-11604 Fix code annotation errors such as class DefaultClientRequ…

773b68b

…estInterceptor

github-actions bot added YARN trunk labels Nov 2, 2023

slfan1989 reviewed Nov 2, 2023

View reviewed changes

singer-bin added 2 commits November 7, 2023 14:35

Merge branch 'trunk' of https://github.com/apache/hadoop into YARN-11604

082da77

YARN-11604 Fix code annotation errors such as class DefaultRequestInt…

ead8376

…erceptorREST.java

singer-bin requested a review from slfan1989 November 23, 2023 06:34

singer-bin changed the title ~~YARN-11604 Fix code annotation errors such as class DefaultClientRequ…~~ [Federtion]YARN-11604 Fix code annotation errors such as class DefaultClientRequ… Jan 10, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Federtion]YARN-11604 Fix code annotation errors such as class DefaultClientRequ… #6242

[Federtion]YARN-11604 Fix code annotation errors such as class DefaultClientRequ… #6242

singer-bin commented Nov 2, 2023

hadoop-yetus commented Nov 2, 2023

slfan1989 Nov 2, 2023

slfan1989 commented Nov 2, 2023

hadoop-yetus commented Nov 7, 2023

singer-bin commented Nov 7, 2023

[Federtion]YARN-11604 Fix code annotation errors such as class DefaultClientRequ… #6242

Are you sure you want to change the base?

[Federtion]YARN-11604 Fix code annotation errors such as class DefaultClientRequ… #6242

Conversation

singer-bin commented Nov 2, 2023

hadoop-yetus commented Nov 2, 2023

slfan1989 Nov 2, 2023

Choose a reason for hiding this comment

slfan1989 commented Nov 2, 2023

hadoop-yetus commented Nov 7, 2023

singer-bin commented Nov 7, 2023