HDFS-17243. Add the parameter storage type for getBlocks method #6238

haiyang1987 · 2023-10-30T11:26:42Z

Description of PR

When Balancer is running, it is found that there are many logs, such as

INFO balancer.Dispatcher (Dispatcher.java:markMovedIfGoodBlock(306)) - No striped internal block on source xxx:50010:SSD, block blk_-xxx_xxx size=982142783. Skipping.
these logs show that Balancer cannot to balancer SSD type source， and it causes that Balancer will frequently get blocks from NN through getBlocks RPC.

The main reason is the storage type in the current Source is SSD, but now getBlocks obtains all list of blocks belonging to datanode, so need add the parameter storage type for getBlocks method

hadoop-yetus · 2023-10-30T14:39:39Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	1m 13s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	buf	0m 1s		buf was not available.
+0 🆗	buf	0m 1s		buf was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 4 new or modified test files.
			_ trunk Compile Tests _
+0 🆗	mvndep	15m 32s		Maven dependency ordering for branch
+1 💚	mvninstall	36m 29s		trunk passed
+1 💚	compile	6m 49s		trunk passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04
+1 💚	compile	6m 38s		trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	checkstyle	1m 34s		trunk passed
+1 💚	mvnsite	3m 5s		trunk passed
+1 💚	javadoc	1m 56s		trunk passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	2m 5s		trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	spotbugs	5m 37s		trunk passed
-1 ❌	shadedclient	41m 25s		branch has errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s		Maven dependency ordering for patch
-1 ❌	mvninstall	0m 27s	/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs.txt	hadoop-hdfs in the patch failed.
-1 ❌	mvninstall	0m 46s	/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs-rbf.txt	hadoop-hdfs-rbf in the patch failed.
-1 ❌	compile	2m 31s	/patch-compile-hadoop-hdfs-project-jdkUbuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04.txt	hadoop-hdfs-project in the patch failed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04.
-1 ❌	cc	2m 31s	/patch-compile-hadoop-hdfs-project-jdkUbuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04.txt	hadoop-hdfs-project in the patch failed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04.
-1 ❌	javac	2m 31s	/patch-compile-hadoop-hdfs-project-jdkUbuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04.txt	hadoop-hdfs-project in the patch failed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04.
-1 ❌	compile	0m 27s	/patch-compile-hadoop-hdfs-project-jdkPrivateBuild-1.8.0_382-8u382-ga-1~20.04.1-b05.txt	hadoop-hdfs-project in the patch failed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05.
-1 ❌	cc	0m 27s	/patch-compile-hadoop-hdfs-project-jdkPrivateBuild-1.8.0_382-8u382-ga-1~20.04.1-b05.txt	hadoop-hdfs-project in the patch failed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05.
-1 ❌	javac	0m 27s	/patch-compile-hadoop-hdfs-project-jdkPrivateBuild-1.8.0_382-8u382-ga-1~20.04.1-b05.txt	hadoop-hdfs-project in the patch failed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05.
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	1m 51s		the patch passed
-1 ❌	mvnsite	0m 37s	/patch-mvnsite-hadoop-hdfs-project_hadoop-hdfs-rbf.txt	hadoop-hdfs-rbf in the patch failed.
+1 💚	javadoc	1m 58s		the patch passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	2m 24s		the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
-1 ❌	spotbugs	1m 23s	/patch-spotbugs-hadoop-hdfs-project_hadoop-hdfs.txt	hadoop-hdfs in the patch failed.
-1 ❌	spotbugs	0m 40s	/patch-spotbugs-hadoop-hdfs-project_hadoop-hdfs-rbf.txt	hadoop-hdfs-rbf in the patch failed.
-1 ❌	shadedclient	56m 7s		patch has errors when building and testing our client artifacts.
			_ Other Tests _
-1 ❌	unit	0m 27s	/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt	hadoop-hdfs in the patch failed.
-1 ❌	unit	0m 32s	/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt	hadoop-hdfs-rbf in the patch failed.
+0 🆗	asflicense	0m 31s		ASF License check generated no output?
		188m 16s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6238/2/artifact/out/Dockerfile
GITHUB PR	#6238
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets cc buflint bufcompat
uname	Linux 03a3415fb36f 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `1e1cd0f`
Default Java	Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6238/2/testReport/
Max. process+thread count	138 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6238/2/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2023-10-30T17:14:01Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 30s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	buf	0m 0s		buf was not available.
+0 🆗	buf	0m 0s		buf was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 4 new or modified test files.
			_ trunk Compile Tests _
+0 🆗	mvndep	15m 38s		Maven dependency ordering for branch
+1 💚	mvninstall	26m 43s		trunk passed
+1 💚	compile	3m 42s		trunk passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04
+1 💚	compile	3m 34s		trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	checkstyle	1m 0s		trunk passed
+1 💚	mvnsite	1m 35s		trunk passed
+1 💚	javadoc	1m 25s		trunk passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	1m 52s		trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	spotbugs	3m 22s		trunk passed
+1 💚	shadedclient	25m 59s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 26s		Maven dependency ordering for patch
+1 💚	mvninstall	1m 8s		the patch passed
+1 💚	compile	3m 6s		the patch passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04
+1 💚	cc	3m 6s		the patch passed
+1 💚	javac	3m 6s		the patch passed
+1 💚	compile	2m 58s		the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	cc	2m 58s		the patch passed
+1 💚	javac	2m 58s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 45s		the patch passed
+1 💚	mvnsite	1m 14s		the patch passed
+1 💚	javadoc	1m 3s		the patch passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	1m 24s		the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	spotbugs	2m 52s		the patch passed
+1 💚	shadedclient	20m 42s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	200m 16s		hadoop-hdfs in the patch passed.
+1 💚	unit	19m 19s		hadoop-hdfs-rbf in the patch passed.
+1 💚	asflicense	0m 39s		The patch does not generate ASF License warnings.
		345m 54s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6238/1/artifact/out/Dockerfile
GITHUB PR	#6238
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets cc buflint bufcompat
uname	Linux 2f5509a3f44c 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `1e1cd0f`
Default Java	Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6238/1/testReport/
Max. process+thread count	3953 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6238/1/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

haiyang1987 · 2023-10-31T09:39:14Z

Hi @Hexiaoqiao @ayushtkn @ZanderXu @zhangshuyan0
Could you please help review this pr when you have free time. Thanks~

tomscut

LGTM.

haiyang1987 · 2023-11-01T02:13:02Z

LGTM.

Thanks @tomscut for your review.

Hexiaoqiao · 2023-11-02T03:18:04Z

LGTM. +1 from my side.
But some CI result seems error now. Trigger Yetus manually, Let's wait what will it say.

hadoop-yetus · 2023-11-02T08:48:06Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 27s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 1s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	buf	0m 0s		buf was not available.
+0 🆗	buf	0m 0s		buf was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 4 new or modified test files.
			_ trunk Compile Tests _
+0 🆗	mvndep	14m 19s		Maven dependency ordering for branch
+1 💚	mvninstall	19m 57s		trunk passed
+1 💚	compile	3m 12s		trunk passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04
+1 💚	compile	3m 4s		trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	checkstyle	0m 55s		trunk passed
+1 💚	mvnsite	1m 27s		trunk passed
+1 💚	javadoc	1m 23s		trunk passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	1m 38s		trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	spotbugs	2m 51s		trunk passed
+1 💚	shadedclient	20m 38s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 26s		Maven dependency ordering for patch
+1 💚	mvninstall	1m 8s		the patch passed
+1 💚	compile	3m 6s		the patch passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04
+1 💚	cc	3m 6s		the patch passed
+1 💚	javac	3m 6s		the patch passed
+1 💚	compile	2m 56s		the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	cc	2m 56s		the patch passed
+1 💚	javac	2m 56s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 45s		the patch passed
+1 💚	mvnsite	1m 13s		the patch passed
+1 💚	javadoc	1m 2s		the patch passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	1m 24s		the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	spotbugs	2m 51s		the patch passed
+1 💚	shadedclient	20m 35s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
-1 ❌	unit	200m 30s	/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt	hadoop-hdfs in the patch passed.
+1 💚	unit	20m 13s		hadoop-hdfs-rbf in the patch passed.
+1 💚	asflicense	0m 39s		The patch does not generate ASF License warnings.
		330m 20s

Reason	Tests
Failed junit tests	hadoop.hdfs.TestDFSUtil

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6238/3/artifact/out/Dockerfile
GITHUB PR	#6238
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets cc buflint bufcompat
uname	Linux 3aff0467d0fc 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `1e1cd0f`
Default Java	Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6238/3/testReport/
Max. process+thread count	3346 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6238/3/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

haiyang1987 · 2023-11-02T09:00:06Z

LGTM. +1 from my side. But some CI result seems error now. Trigger Yetus manually, Let's wait what will it say.

Thanks @Hexiaoqiao for your review.

haiyang1987 · 2023-11-02T09:00:31Z

Test failures seems unrelated.

zhangshuyan0 · 2023-11-06T03:23:17Z

Committed to trunk. Thanks for your work @haiyang1987 @tomscut @Hexiaoqiao .

haiyang1987 · 2023-11-06T05:10:02Z

Thanks @Hexiaoqiao @zhangshuyan0 @tomscut for you review and merge it.

…he#6238). Contributed by Haiyang Hu. Reviewed-by: He Xiaoqiao <[email protected]> Reviewed-by: Tao Li <[email protected]> Signed-off-by: Shuyan Zhang <[email protected]>

github-actions bot added HDFS trunk RBF labels Oct 30, 2023

HDFS-17243. Add the parameter storage type for getBlocks method

1e1cd0f

haiyang1987 force-pushed the HDFS-17243 branch from 12e351b to 1e1cd0f Compare October 30, 2023 11:29

tomscut approved these changes Nov 1, 2023

View reviewed changes

zhangshuyan0 approved these changes Nov 6, 2023

View reviewed changes

zhangshuyan0 merged commit 4ef2322 into apache:trunk Nov 6, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HDFS-17243. Add the parameter storage type for getBlocks method #6238

HDFS-17243. Add the parameter storage type for getBlocks method #6238

haiyang1987 commented Oct 30, 2023

hadoop-yetus commented Oct 30, 2023

hadoop-yetus commented Oct 30, 2023

haiyang1987 commented Oct 31, 2023

tomscut left a comment

haiyang1987 commented Nov 1, 2023

Hexiaoqiao commented Nov 2, 2023

hadoop-yetus commented Nov 2, 2023

haiyang1987 commented Nov 2, 2023

haiyang1987 commented Nov 2, 2023

zhangshuyan0 commented Nov 6, 2023

haiyang1987 commented Nov 6, 2023

HDFS-17243. Add the parameter storage type for getBlocks method #6238

HDFS-17243. Add the parameter storage type for getBlocks method #6238

Conversation

haiyang1987 commented Oct 30, 2023

Description of PR

hadoop-yetus commented Oct 30, 2023

hadoop-yetus commented Oct 30, 2023

haiyang1987 commented Oct 31, 2023

tomscut left a comment

Choose a reason for hiding this comment

haiyang1987 commented Nov 1, 2023

Hexiaoqiao commented Nov 2, 2023

hadoop-yetus commented Nov 2, 2023

haiyang1987 commented Nov 2, 2023

haiyang1987 commented Nov 2, 2023

zhangshuyan0 commented Nov 6, 2023

haiyang1987 commented Nov 6, 2023