-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HADOOP-18894: upgrade sshd-core due to CVEs #6060
Conversation
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
09e73a3
to
03381d2
Compare
🎊 +1 overall
This message was automatically generated. |
@slfan1989 is this something that we could merge? The code is only used in tests but it makes Dependabot a bit happier and it's more maintainable to use a newer version of the lib. |
@pjfanning Can we retrigger compilation again? Should we add this dependency to LICENSE-binary? |
03381d2
to
d56a994
Compare
done |
LGTM. |
@Hexiaoqiao @ayushtkn @steveloughran Can you help review this PR? Thank you very much! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. +1 from my side. Thanks @pjfanning .
would need to be tagged as incompatible if sshd ftp jar is now needed in installations which want to use it. (I'd have moved it to its own module if SSH wasn't apparently used for of the failover detection in some deployments -that's something to ask on the hdfs/yarn lists to see if it still holds) |
@steveloughran these are test-only-dependencies. Still nice to keep them up to date especially when the old versions have CVEs. |
@pjfanning I plan to merge this PR into trunk and push it to branch3.4/branch3.4.0 after the compilation results are available. @steveloughran Do you have any other suggestions? cc: @Hexiaoqiao |
Re-trigger CI, Let's wait what it will say. |
@pjfanning We need to rebase trunk branch.
|
18d214c
to
9b5dcca
Compare
@pjfanning #6472 has been compiled successfully. I merged #6060 to the trunk branch and pushed it to branch-3.4/branch-3.4.0. |
… Fanning. Reviewed-by: He Xiaoqiao <[email protected]> Reviewed-by: Steve Loughran <[email protected]> Signed-off-by: Shilun Fan <[email protected]>
… Fanning. Reviewed-by: He Xiaoqiao <[email protected]> Reviewed-by: Steve Loughran <[email protected]> Signed-off-by: Shilun Fan <[email protected]>
… by PJ Fanning. Reviewed-by: He Xiaoqiao <[email protected]> Reviewed-by: Steve Loughran <[email protected]> Signed-off-by: Shilun Fan <[email protected]>
Description of PR
https://issues.apache.org/jira/browse/HADOOP-18894
How was this patch tested?
CI build
For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?